All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Hannes Reinecke <hare@suse.de>, Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	Shaun Tancheff <shaun.tancheff@seagate.com>,
	Damien Le Moal <damien.lemoal@hgst.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCHv2 03/14] libsas: Define ATA_CMD_NCQ_NON_DATA
Date: Tue, 12 Apr 2016 11:03:34 +0100	[thread overview]
Message-ID: <570CC7F6.1020607@huawei.com> (raw)
In-Reply-To: <1460443678-57934-4-git-send-email-hare@suse.de>

On 12/04/2016 07:47, Hannes Reinecke wrote:
> Define the NCQ NON DATA command and update libsas to handle it
> correctly.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +
>   drivers/scsi/isci/request.c            | 3 ++-
>   drivers/scsi/libsas/sas_ata.c          | 3 ++-
>   drivers/scsi/mvsas/mv_sas.c            | 3 ++-
>   drivers/scsi/pm8001/pm8001_sas.c       | 3 ++-
>   include/linux/ata.h                    | 1 +
>   include/trace/events/libata.h          | 1 +
>   7 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index fc2e767..ebaf5ab 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -1575,6 +1575,7 @@ static u8 get_ata_protocol(u8 cmd, int direction)
>   	case ATA_CMD_FPDMA_READ:
>   	case ATA_CMD_FPMDA_RECV:
>   	case ATA_CMD_FPDMA_SEND:
> +	case ATA_CMD_NCQ_NON_DATA:
>   	return SATA_PROTOCOL_FPDMA;
>

I'm going to double-check this. It may correspond to 
SATA_PROTOCOL_NONDATA, and not SATA_PROTOCOL_FPDMA.

Cheers,

>   	case ATA_CMD_ID_ATA:
> diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
> index 29456e0..b709d2b 100644
> --- a/drivers/scsi/isci/request.c
> +++ b/drivers/scsi/isci/request.c
> @@ -3171,7 +3171,8 @@ static enum sci_status isci_request_stp_request_construct(struct isci_request *i
>   	if (qc && (qc->tf.command == ATA_CMD_FPDMA_WRITE ||
>   		   qc->tf.command == ATA_CMD_FPDMA_READ ||
>   		   qc->tf.command == ATA_CMD_FPDMA_RECV ||
> -		   qc->tf.command == ATA_CMD_FPDMA_SEND)) {
> +		   qc->tf.command == ATA_CMD_FPDMA_SEND ||
> +		   qc->tf.command == ATA_CMD_NCQ_NON_DATA)) {
>   		fis->sector_count = qc->tag << 3;
>   		ireq->tc->type.stp.ncq_tag = qc->tag;
>   	}
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index fe1cd26..935c430 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -207,7 +207,8 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
>   	if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||
>   	    qc->tf.command == ATA_CMD_FPDMA_READ ||
>   	    qc->tf.command == ATA_CMD_FPDMA_RECV ||
> -	    qc->tf.command == ATA_CMD_FPDMA_SEND) {
> +	    qc->tf.command == ATA_CMD_FPDMA_SEND ||
> +	    qc->tf.command == ATA_CMD_NCQ_NON_DATA) {
>   		/* Need to zero out the tag libata assigned us */
>   		qc->tf.nsect = 0;
>   	}
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index db37149..5b9fcff 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -431,7 +431,8 @@ static u32 mvs_get_ncq_tag(struct sas_task *task, u32 *tag)
>   		if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||
>   		    qc->tf.command == ATA_CMD_FPDMA_READ ||
>   		    qc->tf.command == ATA_CMD_FPDMA_RECV ||
> -		    qc->tf.command == ATA_CMD_FPDMA_SEND) {
> +		    qc->tf.command == ATA_CMD_FPDMA_SEND ||
> +		    qc->tf.command == ATA_CMD_NCQ_NON_DATA) {
>   			*tag = qc->tag;
>   			return 1;
>   		}
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index 62abd98..dc33dfa 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -282,7 +282,8 @@ u32 pm8001_get_ncq_tag(struct sas_task *task, u32 *tag)
>   		if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||
>   		    qc->tf.command == ATA_CMD_FPDMA_READ ||
>   		    qc->tf.command == ATA_CMD_FPDMA_RECV ||
> -		    qc->tf.command == ATA_CMD_FPDMA_SEND) {
> +		    qc->tf.command == ATA_CMD_FPDMA_SEND ||
> +		    qc->tf.command == ATA_CMD_NCQ_NON_DATA) {
>   			*tag = qc->tag;
>   			return 1;
>   		}
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 00aebc4..b84210a 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -243,6 +243,7 @@ enum {
>   	ATA_CMD_WRITE_QUEUED_FUA_EXT = 0x3E,
>   	ATA_CMD_FPDMA_READ	= 0x60,
>   	ATA_CMD_FPDMA_WRITE	= 0x61,
> +	ATA_CMD_NCQ_NON_DATA	= 0x63,
>   	ATA_CMD_FPDMA_SEND	= 0x64,
>   	ATA_CMD_FPDMA_RECV	= 0x65,
>   	ATA_CMD_PIO_READ	= 0x20,
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index 8b0fbd9..0168603 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -39,6 +39,7 @@
>   		 ata_opcode_name(ATA_CMD_WRITE_QUEUED_FUA_EXT), \
>   		 ata_opcode_name(ATA_CMD_FPDMA_READ),		\
>   		 ata_opcode_name(ATA_CMD_FPDMA_WRITE),		\
> +		 ata_opcode_name(ATA_CMD_NCQ_NON_DATA),		\
>   		 ata_opcode_name(ATA_CMD_FPDMA_SEND),		\
>   		 ata_opcode_name(ATA_CMD_FPDMA_RECV),		\
>   		 ata_opcode_name(ATA_CMD_PIO_READ),		\
>



  reply	other threads:[~2016-04-12 10:03 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12  6:47 [PATCHv2 00/14] ZAC support Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 01/14] libata: do not attempt to retrieve sense code twice Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 02/14] libsas: enable FPDMA SEND/RECEIVE Hannes Reinecke
2016-04-12  7:10   ` kbuild test robot
2016-04-12  7:19   ` kbuild test robot
2016-04-12  7:25   ` Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 03/14] libsas: Define ATA_CMD_NCQ_NON_DATA Hannes Reinecke
2016-04-12 10:03   ` John Garry [this message]
2016-04-12 10:25     ` Hannes Reinecke
2016-04-14  9:06       ` John Garry
2016-04-14  9:39         ` Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 04/14] libata: Separate out ata_dev_config_ncq_send_recv() Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT Hannes Reinecke
2016-04-13 18:07   ` Tejun Heo
2016-04-14  5:44     ` Hannes Reinecke
2016-04-14 15:43       ` Tejun Heo
2016-04-14 15:59         ` Hannes Reinecke
2016-04-14 16:07           ` Tejun Heo
2016-04-15 12:32             ` Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 06/14] libata: Check log page directory before accessing pages Hannes Reinecke
2016-04-13 18:08   ` Tejun Heo
2016-04-14  5:44     ` Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 07/14] libata-trace: decode subcommands Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 08/14] libata-scsi: Generate sense code for disabled devices Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 09/14] libata: fixup ZAC device disabling Hannes Reinecke
2016-04-13 18:09   ` Tejun Heo
2016-04-14  5:48     ` Hannes Reinecke
2016-04-14 15:43       ` Tejun Heo
2016-04-12  6:47 ` [PATCHv2 10/14] libata: implement ZBC IN translation Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 11/14] libata: Implement ZBC OUT translation Hannes Reinecke
2016-04-12 18:54   ` Shaun Tancheff
2016-04-12  6:47 ` [PATCHv2 12/14] libata: NCQ encapsulation for ZAC MANAGEMENT OUT Hannes Reinecke
2016-04-12  6:47 ` [PATCHv2 13/14] libata: support device-managed ZAC devices Hannes Reinecke
2016-04-13 20:50   ` Shaun Tancheff
2016-04-12  6:47 ` [PATCHv2 14/14] libata: support host-aware and host-managed " Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570CC7F6.1020607@huawei.com \
    --to=john.garry@huawei.com \
    --cc=damien.lemoal@hgst.com \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=shaun.tancheff@seagate.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.