From: Julien Grall <julien.grall@arm.com>
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>,
Jan Beulich <jbeulich@suse.com>
Cc: wei.liu2@citrix.com, Keir Fraser <keir@xen.org>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] vm_event: Implement ARM SMC events
Date: Tue, 12 Apr 2016 16:58:37 +0100 [thread overview]
Message-ID: <570D1B2D.3030200@arm.com> (raw)
In-Reply-To: <CABfawhmHx2kmpNJ-9se05_Bhyp2_WN7dxETFqPWv+yOwxKbNeA@mail.gmail.com>
Hello Tamas,
On 12/04/2016 16:05, Tamas K Lengyel wrote:
> On Apr 11, 2016 22:31, "Jan Beulich" <jbeulich@suse.com
> <mailto:jbeulich@suse.com>> wrote:
> >
> > >>> Tamas K Lengyel <tamas@tklengyel.com
> <mailto:tamas@tklengyel.com>> 04/11/16 9:47 PM >>>
[...]
> >
> > >+ uint64_t ttbr0;
> > >+ uint64_t ttbr1;
> > >+ uint32_t _pad;
> > >+};
> >
> > This padding field is pretty strange: Without the adjustment to pc
> there are 16
> > 32-bit fields (not counting the padding one), so I don't see why
> padding would be
> > needed at all. And with pc adjusted the padding field would surely
> better go
> > ahead of the two remaining 64-bit ones.
>
> Yes, I have been shuffling this struct around and didn't check the
> layout. Will fix. I'll also try to make this struct usable for aarch64 too.
You may want to give a look to vcpu_guest_core_regs in public/arch-arm.h
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-12 15:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 19:47 [PATCH] vm_event: Implement ARM SMC events Tamas K Lengyel
2016-04-12 4:31 ` Jan Beulich
2016-04-12 5:35 ` Razvan Cojocaru
2016-04-12 15:08 ` Tamas K Lengyel
2016-04-12 15:05 ` Tamas K Lengyel
2016-04-12 15:58 ` Julien Grall [this message]
2016-04-12 17:58 ` Tamas K Lengyel
2016-04-12 7:51 ` Corneliu ZUZU
2016-04-12 15:01 ` Tamas K Lengyel
2016-04-12 16:24 ` Julien Grall
2016-04-12 17:05 ` Corneliu ZUZU
2016-04-12 17:24 ` Tamas K Lengyel
2016-04-13 8:55 ` Corneliu ZUZU
2016-04-13 10:17 ` Andrew Cooper
2016-04-13 10:53 ` Corneliu ZUZU
2016-04-13 12:02 ` Andrew Cooper
2016-04-13 13:25 ` Tamas K Lengyel
2016-04-13 15:06 ` Lars Kurth
2016-04-13 15:13 ` Tamas K Lengyel
2016-04-13 10:52 ` Julien Grall
2016-04-13 11:02 ` Corneliu ZUZU
2016-04-13 15:32 ` Tamas K Lengyel
2016-04-12 14:55 ` Konrad Rzeszutek Wilk
2016-04-12 15:22 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D1B2D.3030200@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tamas.k.lengyel@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.