From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758850AbcDMH7i (ORCPT ); Wed, 13 Apr 2016 03:59:38 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:47717 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751194AbcDMH7g (ORCPT ); Wed, 13 Apr 2016 03:59:36 -0400 Message-ID: <570DFC44.8060408@st.com> Date: Wed, 13 Apr 2016 09:59:00 +0200 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Mark Brown , Peter Griffin CC: , , , , , , , , Youssef TRIKI Subject: Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense. References: <1460474204-5351-1-git-send-email-peter.griffin@linaro.org> <1460474204-5351-3-git-send-email-peter.griffin@linaro.org> <20160413061514.GI14664@sirena.org.uk> In-Reply-To: <20160413061514.GI14664@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.50] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-13_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/13/2016 8:15 AM, Mark Brown wrote: >> >+static void st_get_satinize_powerup_voltage(struct st_vsense *vsense) >> >+{ >> >+ void __iomem *ioaddr = vsense->ioaddr; >> >+ u32 value = readl_relaxed(ioaddr); >> >+ >> >+ dev_dbg(vsense->dev, "Initial start-up value: (0x%08x)\n", value); >> >+ >> >+ /* Sanitize voltage values forcing what is provided from start-up */ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_EMMC) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_EMMC; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_EMMC; >> >+ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_NAND) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_NAND; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_NAND; >> >+ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_SPI) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_SPI; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_SPI; > This looks like a very complicated way of writing > > value &= TOP_VSENSE_CONFIG_LATCHED_PSW_SPI | > TOP_VSENSE_CONFIG_LATCHED_PSW_NAND | > TOP_VSENSE_CONFIG_REG_PSW_EMMC > > or am I missing something? Why do we need to do this anyway, it's very > surprsing? > This functions is to sanitize the vsense voltages when the regulator is probed and in some circumstances the reset value of this register does not reflect the hw status/config. For example, by default, after the reset, the bit 0 is set so the EMMC, inside the flash subsystem, is supposed to operate at 3v3. But the latched bit 24 can be 0 on a platform where it is actually set at 1v8. So the bit 0 must be reset to keep this coherent and to allow MMC framework to properly setup the Vdd when the framework starts. Hoping this can help. Regards peppe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giuseppe CAVALLARO Subject: Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense. Date: Wed, 13 Apr 2016 09:59:00 +0200 Message-ID: <570DFC44.8060408@st.com> References: <1460474204-5351-1-git-send-email-peter.griffin@linaro.org> <1460474204-5351-3-git-send-email-peter.griffin@linaro.org> <20160413061514.GI14664@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160413061514.GI14664-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown , Peter Griffin Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, maxime.coquelin-qxv4g6HH51o@public.gmane.org, patrice.chotard-qxv4g6HH51o@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Youssef TRIKI List-Id: devicetree@vger.kernel.org On 4/13/2016 8:15 AM, Mark Brown wrote: >> >+static void st_get_satinize_powerup_voltage(struct st_vsense *vsense) >> >+{ >> >+ void __iomem *ioaddr = vsense->ioaddr; >> >+ u32 value = readl_relaxed(ioaddr); >> >+ >> >+ dev_dbg(vsense->dev, "Initial start-up value: (0x%08x)\n", value); >> >+ >> >+ /* Sanitize voltage values forcing what is provided from start-up */ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_EMMC) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_EMMC; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_EMMC; >> >+ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_NAND) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_NAND; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_NAND; >> >+ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_SPI) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_SPI; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_SPI; > This looks like a very complicated way of writing > > value &= TOP_VSENSE_CONFIG_LATCHED_PSW_SPI | > TOP_VSENSE_CONFIG_LATCHED_PSW_NAND | > TOP_VSENSE_CONFIG_REG_PSW_EMMC > > or am I missing something? Why do we need to do this anyway, it's very > surprsing? > This functions is to sanitize the vsense voltages when the regulator is probed and in some circumstances the reset value of this register does not reflect the hw status/config. For example, by default, after the reset, the bit 0 is set so the EMMC, inside the flash subsystem, is supposed to operate at 3v3. But the latched bit 24 can be 0 on a platform where it is actually set at 1v8. So the bit 0 must be reset to keep this coherent and to allow MMC framework to properly setup the Vdd when the framework starts. Hoping this can help. Regards peppe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: peppe.cavallaro@st.com (Giuseppe CAVALLARO) Date: Wed, 13 Apr 2016 09:59:00 +0200 Subject: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense. In-Reply-To: <20160413061514.GI14664@sirena.org.uk> References: <1460474204-5351-1-git-send-email-peter.griffin@linaro.org> <1460474204-5351-3-git-send-email-peter.griffin@linaro.org> <20160413061514.GI14664@sirena.org.uk> Message-ID: <570DFC44.8060408@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 4/13/2016 8:15 AM, Mark Brown wrote: >> >+static void st_get_satinize_powerup_voltage(struct st_vsense *vsense) >> >+{ >> >+ void __iomem *ioaddr = vsense->ioaddr; >> >+ u32 value = readl_relaxed(ioaddr); >> >+ >> >+ dev_dbg(vsense->dev, "Initial start-up value: (0x%08x)\n", value); >> >+ >> >+ /* Sanitize voltage values forcing what is provided from start-up */ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_EMMC) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_EMMC; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_EMMC; >> >+ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_NAND) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_NAND; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_NAND; >> >+ >> >+ if (value & TOP_VSENSE_CONFIG_LATCHED_PSW_SPI) >> >+ value |= TOP_VSENSE_CONFIG_REG_PSW_SPI; >> >+ else >> >+ value &= ~TOP_VSENSE_CONFIG_REG_PSW_SPI; > This looks like a very complicated way of writing > > value &= TOP_VSENSE_CONFIG_LATCHED_PSW_SPI | > TOP_VSENSE_CONFIG_LATCHED_PSW_NAND | > TOP_VSENSE_CONFIG_REG_PSW_EMMC > > or am I missing something? Why do we need to do this anyway, it's very > surprsing? > This functions is to sanitize the vsense voltages when the regulator is probed and in some circumstances the reset value of this register does not reflect the hw status/config. For example, by default, after the reset, the bit 0 is set so the EMMC, inside the flash subsystem, is supposed to operate at 3v3. But the latched bit 24 can be 0 on a platform where it is actually set at 1v8. So the bit 0 must be reset to keep this coherent and to allow MMC framework to properly setup the Vdd when the framework starts. Hoping this can help. Regards peppe