Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

From: Leon Alrae <leon.alrae@imgtec.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	qemu-devel@nongnu.org
Cc: proljc@gmail.com, kbastian@mail.uni-paderborn.de,
	mark.cave-ayland@ilande.co.uk, agraf@suse.de,
	blauwirbel@gmail.com, jcmvbkbc@gmail.com,
	aleksandar.markovic@imgtec.com, qemu-arm@nongnu.org,
	qemu-ppc@nongnu.org, petar.jovanovic@imgtec.com,
	pbonzini@redhat.com, miodrag.dinic@imgtec.com,
	edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, afaerber@suse.de,
	aurelien@aurel32.net, rth@twiddle.net, maciej.rozycki@imgtec.com
Subject: Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit
Date: Wed, 13 Apr 2016 13:11:01 +0100	[thread overview]
Message-ID: <570E3755.4060608@imgtec.com> (raw)
In-Reply-To: <1460465891-6142-2-git-send-email-aleksandar.markovic@rt-rk.com>

On 12/04/16 13:58, Aleksandar Markovic wrote:
> @@ -322,14 +327,14 @@ int float32_is_quiet_nan( float32 a_ )
>  | NaN; otherwise returns 0.
>  *----------------------------------------------------------------------------*/
>  
> -int float32_is_signaling_nan( float32 a_ )
> +int float32_is_signaling_nan( float32 a_, float_status *status )
>  {
>      uint32_t a = float32_val(a_);
> -#if SNAN_BIT_IS_ONE
> -    return ((uint32_t)(a << 1) >= 0xff800000);
> -#else
> -    return ( ( ( a>>22 ) & 0x1FF ) == 0x1FE ) && ( a & 0x003FFFFF );
> -#endif
> +    if (status->snan_bit_is_one) {
> +        return ((uint32_t)(a << 1) >= 0xff800000);
> +    } else {
> +        return ( ( ( a>>22 ) & 0x1FF ) == 0x1FE ) && ( a & 0x003FFFFF );
> +    }

Please correct the style while touching the lines.

Thanks,
Leon