From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbcDNMjz (ORCPT ); Thu, 14 Apr 2016 08:39:55 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:41289 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932157AbcDNMjx (ORCPT ); Thu, 14 Apr 2016 08:39:53 -0400 Subject: Re: [PATCH v3 09/16] phy: da8xx-usb: new driver for DA8xx SoC USB PHY To: David Lechner References: <1458863503-31121-1-git-send-email-david@lechnology.com> <1458863503-31121-10-git-send-email-david@lechnology.com> <570E4796.7070005@ti.com> <570EA6EC.1040001@lechnology.com> CC: , , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Sekhar Nori , Kevin Hilman , Greg Kroah-Hartman , Alan Stern , Bin Liu , Lee Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:ARM PORT" , "open list:USB SUBSYSTEM" From: Kishon Vijay Abraham I Message-ID: <570F8F32.8050302@ti.com> Date: Thu, 14 Apr 2016 18:08:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <570EA6EC.1040001@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 14 April 2016 01:37 AM, David Lechner wrote: > On 04/13/2016 08:20 AM, Kishon Vijay Abraham I wrote: >> >> Don't prefer export symbols from PHY driver. That'll create unnecessary >> dependencies between the controller and the PHY. >> >> To see how to fix it, please see my comment for the previous version of your >> patch. >> >> Thanks >> Kishon >> > > > What is the proper way to give you credit for the changes you suggested? Suggested-by: is commonly used. But if this patch goes via linux-phy tree, I'll also add my Signed-off-by ;-) Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v3 09/16] phy: da8xx-usb: new driver for DA8xx SoC USB PHY Date: Thu, 14 Apr 2016 18:08:10 +0530 Message-ID: <570F8F32.8050302@ti.com> References: <1458863503-31121-1-git-send-email-david@lechnology.com> <1458863503-31121-10-git-send-email-david@lechnology.com> <570E4796.7070005@ti.com> <570EA6EC.1040001@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <570EA6EC.1040001@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org To: David Lechner Cc: petr@barix.com, sergei.shtylyov@cogentembedded.com, David.Laight@ACULAB.COM, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Sekhar Nori , Kevin Hilman , Greg Kroah-Hartman , Alan Stern , Bin Liu , Lee Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:ARM PORT" , "open list:USB SUBSYSTEM" List-Id: devicetree@vger.kernel.org Hi, On Thursday 14 April 2016 01:37 AM, David Lechner wrote: > On 04/13/2016 08:20 AM, Kishon Vijay Abraham I wrote: >> >> Don't prefer export symbols from PHY driver. That'll create unnecessary >> dependencies between the controller and the PHY. >> >> To see how to fix it, please see my comment for the previous version of your >> patch. >> >> Thanks >> Kishon >> > > > What is the proper way to give you credit for the changes you suggested? Suggested-by: is commonly used. But if this patch goes via linux-phy tree, I'll also add my Signed-off-by ;-) Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Thu, 14 Apr 2016 18:08:10 +0530 Subject: [PATCH v3 09/16] phy: da8xx-usb: new driver for DA8xx SoC USB PHY In-Reply-To: <570EA6EC.1040001@lechnology.com> References: <1458863503-31121-1-git-send-email-david@lechnology.com> <1458863503-31121-10-git-send-email-david@lechnology.com> <570E4796.7070005@ti.com> <570EA6EC.1040001@lechnology.com> Message-ID: <570F8F32.8050302@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 14 April 2016 01:37 AM, David Lechner wrote: > On 04/13/2016 08:20 AM, Kishon Vijay Abraham I wrote: >> >> Don't prefer export symbols from PHY driver. That'll create unnecessary >> dependencies between the controller and the PHY. >> >> To see how to fix it, please see my comment for the previous version of your >> patch. >> >> Thanks >> Kishon >> > > > What is the proper way to give you credit for the changes you suggested? Suggested-by: is commonly used. But if this patch goes via linux-phy tree, I'll also add my Signed-off-by ;-) Thanks Kishon