From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755026AbcDNOJA (ORCPT ); Thu, 14 Apr 2016 10:09:00 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49550 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbcDNOI6 (ORCPT ); Thu, 14 Apr 2016 10:08:58 -0400 Message-ID: <570FA46B.2080706@collabora.com> Date: Thu, 14 Apr 2016 16:08:43 +0200 From: Enric Balletbo i Serra User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Emil Velikov CC: Thierry Reding , devicetree , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , David Airlie , Rob Herring , Daniel Kurtz , drinkcat@chromium.org, Dan Carpenter , Rob Herring Subject: Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. References: <1460119972-8658-1-git-send-email-enric.balletbo@collabora.com> <1460119972-8658-4-git-send-email-enric.balletbo@collabora.com> <20160414131013.GA32237@ulmo.ba.sec> <570F9E4D.7040401@collabora.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Emil, On 14/04/16 16:06, Emil Velikov wrote: > Hi Enric, > > On 14 April 2016 at 14:42, Enric Balletbo i Serra > wrote: >> The patch was implemented first without OR'ing error codes. The reason why I >> changed this is because I received the comments that checking the error on >> every regmap_* didn't help the readability of the driver and is likely to >> not fail if the first call doesn't fail. >> >> For example, originally the code was like this: >> http://pastebin.com/rPgyji8k >> but I changed to this >> http://pastebin.com/rPgyji8k >> > Both links are the same ;-) But I believe we all get what you meant. > Ooops, sorry. This is the other link http://pastebin.com/e2KpGxHy > Just a side note: many other drivers in DRM subsystem, inconsistently > check the return value of the regmap API. Note sure how likely is any > of it [regmap_foo] to fail and/or how determined people are to handle > every possible error case. > > -Emil > Enric From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo i Serra Subject: Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support. Date: Thu, 14 Apr 2016 16:08:43 +0200 Message-ID: <570FA46B.2080706@collabora.com> References: <1460119972-8658-1-git-send-email-enric.balletbo@collabora.com> <1460119972-8658-4-git-send-email-enric.balletbo@collabora.com> <20160414131013.GA32237@ulmo.ba.sec> <570F9E4D.7040401@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Emil Velikov Cc: Thierry Reding , devicetree , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , David Airlie , Rob Herring , Daniel Kurtz , drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Dan Carpenter , Rob Herring List-Id: devicetree@vger.kernel.org Hi Emil, On 14/04/16 16:06, Emil Velikov wrote: > Hi Enric, > > On 14 April 2016 at 14:42, Enric Balletbo i Serra > wrote: >> The patch was implemented first without OR'ing error codes. The reason why I >> changed this is because I received the comments that checking the error on >> every regmap_* didn't help the readability of the driver and is likely to >> not fail if the first call doesn't fail. >> >> For example, originally the code was like this: >> http://pastebin.com/rPgyji8k >> but I changed to this >> http://pastebin.com/rPgyji8k >> > Both links are the same ;-) But I believe we all get what you meant. > Ooops, sorry. This is the other link http://pastebin.com/e2KpGxHy > Just a side note: many other drivers in DRM subsystem, inconsistently > check the return value of the regmap API. Note sure how likely is any > of it [regmap_foo] to fail and/or how determined people are to handle > every possible error case. > > -Emil > Enric -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html