From: Jens Axboe <axboe@fb.com>
To: Jan Kara <jack@suse.cz>
Cc: <linux-block@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/3] writeback: propagate the various reasons for writeback
Date: Thu, 14 Apr 2016 09:43:05 -0600 [thread overview]
Message-ID: <570FBA89.1060802@fb.com> (raw)
In-Reply-To: <20160413094821.GG15098@quack2.suse.cz>
On 04/13/2016 03:48 AM, Jan Kara wrote:
> On Tue 12-04-16 12:43:51, Jens Axboe wrote:
>> Avoid losing context by propagating the various reason why we
>> initiate writeback. If we are doing more important reclaim or
>> synchronous writeback, the lower levels should know about it.
>>
>> No intended functional changes in this patch.
>
> So far 'reason' is only used for tracing and I'd strongly prefer to keep it
> as such - otherwise the mix of flags like for_sync, for_backround, ... and
> 'reason' gets really messy. If you need more information propagated via
> wb_start_writeback() just add more flag arguments (currently there is only
> range_cyclic flag). Since there would be already three flag arguments,
> maybe it would warrant using a 'flags' argument which would be a standard
> bitmask of desired flags...
It'd be nicer if the tracing just ran off the functional parts, instead
of having a separate argument just for tracing. It's both confusing and
fragile to have two separate sets of information in there, and it's
harder to keep in sync.
But that's probably better left for another cleanup series. I'll flag
this separately.
--
Jens Axboe
next prev parent reply other threads:[~2016-04-14 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 18:43 [PATCH 0/3] writeback: minor tweaks Jens Axboe
2016-04-12 18:43 ` [PATCH 1/3] writeback: propagate the various reasons for writeback Jens Axboe
2016-04-13 9:48 ` Jan Kara
2016-04-14 15:43 ` Jens Axboe [this message]
2016-04-17 12:01 ` Jan Kara
2016-04-12 18:43 ` [PATCH 2/3] writeback: add wbc_to_write() Jens Axboe
2016-04-13 9:50 ` Jan Kara
2016-04-14 15:41 ` Jens Axboe
2016-04-12 18:43 ` [PATCH 3/3] writeback: use WRITE_SYNC for reclaim or sync writeback Jens Axboe
2016-04-13 0:08 ` [PATCH 0/3] writeback: minor tweaks Dave Chinner
2016-04-13 1:49 ` Jens Axboe
2016-04-13 6:09 ` Dave Chinner
2016-04-13 10:07 ` Jan Kara
2016-04-14 15:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FBA89.1060802@fb.com \
--to=axboe@fb.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.