From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net ([212.18.0.10]:47231 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcDNUD0 (ORCPT ); Thu, 14 Apr 2016 16:03:26 -0400 Message-ID: <570FF737.4050606@denx.de> Date: Thu, 14 Apr 2016 22:01:59 +0200 From: Marek Vasut MIME-Version: 1.0 To: Stefan Wahren , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler CC: Ksenija Stanojevic , Fabio Estevam , Juergen Borleis , Alexandre Belloni , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFT 2/5] iio: mxs-lradc: move TS config into suitable function References: <1460648909-2657-1-git-send-email-stefan.wahren@i2se.com> <1460648909-2657-3-git-send-email-stefan.wahren@i2se.com> In-Reply-To: <1460648909-2657-3-git-send-email-stefan.wahren@i2se.com> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 04/14/2016 05:48 PM, Stefan Wahren wrote: > This patch moves the touchscreen type configuration into > a more suitable function. Btw this simplifies PM ops later. > > Signed-off-by: Stefan Wahren Looks OK Reviewed-by: Marek Vasut > --- > drivers/iio/adc/mxs-lradc.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index 0576953..7118fca 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -686,6 +686,17 @@ static void mxs_lradc_prepare_pressure(struct mxs_lradc *lradc) > > static void mxs_lradc_enable_touch_detection(struct mxs_lradc *lradc) > { > + /* Configure the touchscreen type */ > + if (lradc->soc == IMX28_LRADC) { > + mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + > + if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > + mxs_lradc_reg_set(lradc, > + LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + } > + > mxs_lradc_setup_touch_detection(lradc); > > lradc->cur_plate = LRADC_TOUCH; > @@ -1491,16 +1502,6 @@ static int mxs_lradc_hw_init(struct mxs_lradc *lradc) > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(2)); > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3)); > > - /* Configure the touchscreen type */ > - if (lradc->soc == IMX28_LRADC) { > - mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - > - if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > - mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - } > - > /* Start internal temperature sensing. */ > mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2); > > -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Thu, 14 Apr 2016 22:01:59 +0200 Subject: [PATCH RFT 2/5] iio: mxs-lradc: move TS config into suitable function In-Reply-To: <1460648909-2657-3-git-send-email-stefan.wahren@i2se.com> References: <1460648909-2657-1-git-send-email-stefan.wahren@i2se.com> <1460648909-2657-3-git-send-email-stefan.wahren@i2se.com> Message-ID: <570FF737.4050606@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/14/2016 05:48 PM, Stefan Wahren wrote: > This patch moves the touchscreen type configuration into > a more suitable function. Btw this simplifies PM ops later. > > Signed-off-by: Stefan Wahren Looks OK Reviewed-by: Marek Vasut > --- > drivers/iio/adc/mxs-lradc.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index 0576953..7118fca 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -686,6 +686,17 @@ static void mxs_lradc_prepare_pressure(struct mxs_lradc *lradc) > > static void mxs_lradc_enable_touch_detection(struct mxs_lradc *lradc) > { > + /* Configure the touchscreen type */ > + if (lradc->soc == IMX28_LRADC) { > + mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + > + if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > + mxs_lradc_reg_set(lradc, > + LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + } > + > mxs_lradc_setup_touch_detection(lradc); > > lradc->cur_plate = LRADC_TOUCH; > @@ -1491,16 +1502,6 @@ static int mxs_lradc_hw_init(struct mxs_lradc *lradc) > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(2)); > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3)); > > - /* Configure the touchscreen type */ > - if (lradc->soc == IMX28_LRADC) { > - mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - > - if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > - mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - } > - > /* Start internal temperature sensing. */ > mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2); > > -- Best regards, Marek Vasut