From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Qiu Subject: Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support Date: Fri, 15 Apr 2016 15:58:37 +0800 Message-ID: <57109F2D.6020807@huawei.com> References: <1459926480-32966-1-git-send-email-qiujiang@huawei.com> <1459926480-32966-4-git-send-email-qiujiang@huawei.com> <20160408083830.GT1727@lahna.fi.intel.com> <570B9BEA.8060608@huawei.com> <20160412064657.GF1714@lahna.fi.intel.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:4663 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbcDOH7n (ORCPT ); Fri, 15 Apr 2016 03:59:43 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Linus Walleij , Mika Westerberg Cc: Alexandre Courbot , Andy Shevchenko , Alan Tull , Jamie Iles , charles.chenxin@huawei.com, "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , ACPI Devel Maling List , Linuxarm =E5=9C=A8 2016/4/15 15:40, Linus Walleij =E5=86=99=E9=81=93: > On Tue, Apr 12, 2016 at 8:46 AM, Mika Westerberg > wrote: >> On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: >>>> Currently it just complains if something goes wrong. The GPIO driv= er >>>> itself can still work just fine (including interrupts). >>>> >>>> I'm fine to change it to return an error code. >>> Agree, if add a error code for acpi_gpiochip_request_interrupts(), = it looks more pretty. >>> >>> However, this function is common for other part, maybe cause any ot= her effects if I >>> do this change, did you think so? >> I'm thinking what the callers are going to do with the error code. >> Basically it means that we were not able to attach and configure ACP= I >> event GPIOs. It does not prevent GPIO drivers from functioning so th= ey >> probably just print out some warning message and continue probing, a= nd >> we already warn in acpi_gpiochip_request_interrupts() if something f= ails. >> >> Unless Linus W insists, let's just keep it as is for now :) > I'm fine with it, don' worry. > > I'm just waiting for this patch set to mature so I can apply > it. Many thanks, I will fix these minor mentioned by Andy and get ready for= the new version ASAP. Regards, Jiang > > Yours, > Linus Walleij > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbcDOH7p (ORCPT ); Fri, 15 Apr 2016 03:59:45 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:4663 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbcDOH7n (ORCPT ); Fri, 15 Apr 2016 03:59:43 -0400 Reply-To: Subject: Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support References: <1459926480-32966-1-git-send-email-qiujiang@huawei.com> <1459926480-32966-4-git-send-email-qiujiang@huawei.com> <20160408083830.GT1727@lahna.fi.intel.com> <570B9BEA.8060608@huawei.com> <20160412064657.GF1714@lahna.fi.intel.com> To: Linus Walleij , Mika Westerberg CC: Alexandre Courbot , Andy Shevchenko , Alan Tull , "Jamie Iles" , , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "ACPI Devel Maling List" , Linuxarm From: Jiang Qiu Message-ID: <57109F2D.6020807@huawei.com> Date: Fri, 15 Apr 2016 15:58:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.160.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.57109F60.002F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fd172d1207c863a08fd01bb5b99277e1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/4/15 15:40, Linus Walleij 写道: > On Tue, Apr 12, 2016 at 8:46 AM, Mika Westerberg > wrote: >> On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: >>>> Currently it just complains if something goes wrong. The GPIO driver >>>> itself can still work just fine (including interrupts). >>>> >>>> I'm fine to change it to return an error code. >>> Agree, if add a error code for acpi_gpiochip_request_interrupts(), it looks more pretty. >>> >>> However, this function is common for other part, maybe cause any other effects if I >>> do this change, did you think so? >> I'm thinking what the callers are going to do with the error code. >> Basically it means that we were not able to attach and configure ACPI >> event GPIOs. It does not prevent GPIO drivers from functioning so they >> probably just print out some warning message and continue probing, and >> we already warn in acpi_gpiochip_request_interrupts() if something fails. >> >> Unless Linus W insists, let's just keep it as is for now :) > I'm fine with it, don' worry. > > I'm just waiting for this patch set to mature so I can apply > it. Many thanks, I will fix these minor mentioned by Andy and get ready for the new version ASAP. Regards, Jiang > > Yours, > Linus Walleij > > . >