From: "Wangnan (F)" <wangnan0@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <acme@kernel.org>, <linux-kernel@vger.kernel.org>,
<pi3orama@163.com>, Adrian Hunter <adrian.hunter@intel.com>,
He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>
Subject: Re: [PATCH v3 1/6] perf tools: Derive trigger class from auxtrace_snapshot
Date: Mon, 18 Apr 2016 10:23:46 +0800 [thread overview]
Message-ID: <57144532.3090500@huawei.com> (raw)
In-Reply-To: <20160417115037.GA31336@krava.brq.redhat.com>
On 2016/4/17 19:50, Jiri Olsa wrote:
> On Fri, Apr 15, 2016 at 06:20:15PM +0000, Wang Nan wrote:
>> Create a new class named 'trigger' to model the state of a trigger and
>> implement auxtrace_snapshot with it.
>>
>> auxtrace_record__snapshot_started and auxtrace_snapshot_err are absorbed.
>>
>> 'trigger' defines 4 state transitioning functions ('on', 'released',
>> 'toggle' and 'colddown') and 2 state query function ('is_released') and
>> ('is_toggled'). The state 'ON' and 'OFF' take higher priority than
>> 'RELEASED' and 'TOGGLED'. A trigger must be 'on' before 'enable' and
>> 'disable' take effect. A trigger can be colddown after being triggered.
> what's the COLDDOWN state for?
COLDDOWN is for auxtrace_record__snapshot_started. Once signal received,
auxtrace subsystem doesn't process following signal, until
record__read_auxtrace_snapshot finished successful. Mapping to trigger,
once the state of a trigger moves to 'TRIGGERED', there must be a state
neither RELEASED nor ERROR, which disallow triggering, but allow transiting
to RELEASED.
> could you please document all the transitions of this state machine
> in the change log and the trigger.h file?
Will do. Thank you.
> thanks,
> jirka
next prev parent reply other threads:[~2016-04-18 2:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 18:20 [PATCH v3 0/6] perf tools: Use SIGUSR2 control data dumpping Wang Nan
2016-04-15 18:20 ` [PATCH v3 1/6] perf tools: Derive trigger class from auxtrace_snapshot Wang Nan
2016-04-17 11:50 ` Jiri Olsa
2016-04-18 2:23 ` Wangnan (F) [this message]
2016-04-17 11:52 ` Jiri Olsa
2016-04-15 18:20 ` [PATCH v3 2/6] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-04-15 18:20 ` [PATCH v3 3/6] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan
2016-04-15 18:20 ` [PATCH v3 4/6] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-04-15 18:20 ` [PATCH v3 5/6] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-04-15 18:20 ` [PATCH v3 6/6] perf record: Generate tracking events for process forked by perf Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57144532.3090500@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.