From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Date: Mon, 18 Apr 2016 12:06:24 +0530 Subject: [U-Boot] [PATCH 01/10] drivers: usb: dwc3: remove devm_zalloc from linux_compact In-Reply-To: References: <1458044059-18363-1-git-send-email-mugunthanvnm@ti.com> <1458044059-18363-2-git-send-email-mugunthanvnm@ti.com> <20160315135955.GN23166@bill-the-cat> Message-ID: <57148068.8080601@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 15 April 2016 07:43 PM, Simon Glass wrote: > Hi Mugunthan, > > On 15 March 2016 at 07:59, Tom Rini wrote: >> >> On Tue, Mar 15, 2016 at 05:44:10PM +0530, Mugunthan V N wrote: >> >>> devm_zalloc() is already defined in dm/device.h header, so >>> devm_zalloc can be removed from linux_compact.h beader file. >>> >>> Signed-off-by: Mugunthan V N >> >> Reviewed-by: Tom Rini >> >> -- >> Tom > > Unfortunately I still cannot apply this as there are build errors. Can > you please take a look and resend the entire series (along with the > lonely patch) rebased to u-boot-dm/master? > > 09: drivers: usb: dwc3: remove devm_zalloc from linux_compact > arm: + omap5_uevm > + omap = devm_kzalloc((struct udevice *)dev, sizeof(*omap), GFP_KERNEL); > + ^ > + ^ > +drivers/usb/dwc3/built-in.o: In function `dwc3_omap_uboot_init': > +build/../drivers/usb/dwc3/dwc3-omap.c:380: undefined reference to > `devm_kzalloc' I didn't get this error when I built, is this error with incremental build? I tried this command "./tools/buildman/buildman -c 7 -v -C -j 32 arm" but I am not seeing buildman does a test build for each commit, am I missing something? > +arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion > fail /home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696 > +arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' > not found in the linker script > +arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation > +make[1]: *** [u-boot] Error 1 > +make: *** [sub-make] Error 2 > w+../drivers/usb/dwc3/dwc3-omap.c: In function 'dwc3_omap_uboot_init': > w+../drivers/usb/dwc3/dwc3-omap.c:380:2: warning: implicit declaration > of function 'devm_kzalloc' [-Wimplicit-function-declaration] > w+../drivers/usb/dwc3/dwc3-omap.c:380:7: warning: assignment makes > pointer from integer without a cast > 10: drivers: usb: dwc3-omap: move usb_gadget_handle_interrupts from > board files to drivers > -build/../drivers/usb/dwc3/dwc3-omap.c:380: undefined reference to > `devm_kzalloc' > +drivers/usb/dwc3/built-in.o: In function `usb_gadget_handle_interrupts': > +:(.text.usb_gadget_handle_interrupts+0x0): multiple definition of > `usb_gadget_handle_interrupts' > +board/ti/omap5_uevm/built-in.o:build/../board/ti/omap5_uevm/evm.c:122: > first defined here > +:(.text.dwc3_omap_uboot_init+0xa): undefined reference to `devm_kzalloc' > w-../drivers/usb/dwc3/dwc3-omap.c:380:2: warning: implicit declaration > of function 'devm_kzalloc' [-Wimplicit-function-declaration] > w-../drivers/usb/dwc3/dwc3-omap.c:380:7: warning: assignment makes > pointer from integer without a cast > w+../drivers/usb/dwc3/dwc3-omap.c:381:2: warning: implicit declaration > of function 'devm_kzalloc' [-Wimplicit-function-declaration] > w+../drivers/usb/dwc3/dwc3-omap.c:381:7: warning: assignment makes > pointer from integer without a cast > 11: am437x: board: do not register usb devices when CONFIG_DM_USB is defined > 12: dra7xx: board: do not register usb devices when CONFIG_DM_USB is defined > 13: drivers: usb: dwc3: add ti dwc3 misc driver for wrapper > - omap = devm_kzalloc((struct udevice *)dev, sizeof(*omap), GFP_KERNEL); > - ^ > - ^ > -drivers/usb/dwc3/built-in.o: In function `dwc3_omap_uboot_init': > -:(.text.dwc3_omap_uboot_init+0xa): undefined reference to `devm_kzalloc' > -arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion > fail /home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696 > -arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' > not found in the linker script > -arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation > w-../drivers/usb/dwc3/dwc3-omap.c: In function 'dwc3_omap_uboot_init': > w-../drivers/usb/dwc3/dwc3-omap.c:381:2: warning: implicit declaration > of function 'devm_kzalloc' [-Wimplicit-function-declaration] > w-../drivers/usb/dwc3/dwc3-omap.c:381:7: warning: assignment makes > pointer from integer without a cast > 14: drivers: usb: common: add support to get maximum speed from dt > 15: drivers: usb: dwc3: add ti dwc3 peripheral driver with driver model support > arm: + odroid-xu3 > +board/samsung/common/built-in.o: In function `board_usb_cleanup': > +build/../board/samsung/common/board.c:382: undefined reference to > `dwc3_uboot_exit' > +board/samsung/common/built-in.o: In function `usb_gadget_handle_interrupts': > +build/../board/samsung/common/exynos5-dt.c:318: undefined reference > to `dwc3_uboot_handle_interrupt' > +board/samsung/common/built-in.o: In function `board_usb_init': > +build/../board/samsung/common/exynos5-dt.c:335: undefined reference > to `dwc3_uboot_init' > +arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion > fail /home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696 > +arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' > not found in the linker script > +arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation > 16: am43xx: Add USB device boot support to SPL > Oops, I forgot to run buildman test before submitting, will send v2 ASAP. Regards Mugunthan V N