From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbcDRJyf (ORCPT ); Mon, 18 Apr 2016 05:54:35 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:51231 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbcDRJye (ORCPT ); Mon, 18 Apr 2016 05:54:34 -0400 X-263anti-spam: BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <23f9b0d638194abfda75eacfc3bcaf5b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5714AEC1.7050409@rock-chips.com> Date: Mon, 18 Apr 2016 17:54:09 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: John Keeping CC: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config References: <1460948611-32259-1-git-send-email-mark.yao@rock-chips.com> <20160418102538.0ed730ca.john@metanate.com> In-Reply-To: <20160418102538.0ed730ca.john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年04月18日 17:25, John Keeping wrote: >> >We need to take care of the vop status when use >> >rockchip_drm_crtc_mode_config, if vop is disabled, >> >the function would failed, that is terrible. >> > >> >Save connector type and output mode on drm_display_mode->private_flags >> >at encoder mode_fixup, then we can configure the type and mode safely >> >on crtc mode_set. > Since Rockchip is atomic, shouldn't this be using atomic_check hooks and > a subclassed crtc_state structure? > Right, Good idea. Thanks. -- Ｍark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Date: Mon, 18 Apr 2016 17:54:09 +0800 Message-ID: <5714AEC1.7050409@rock-chips.com> References: <1460948611-32259-1-git-send-email-mark.yao@rock-chips.com> <20160418102538.0ed730ca.john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160418102538.0ed730ca.john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA05pyIMTjml6UgMTc6MjUsIEpvaG4gS2VlcGluZyB3cm90ZToKPj4gPldlIG5l ZWQgdG8gdGFrZSBjYXJlIG9mIHRoZSB2b3Agc3RhdHVzIHdoZW4gdXNlCj4+ID5yb2NrY2hpcF9k cm1fY3J0Y19tb2RlX2NvbmZpZywgaWYgdm9wIGlzIGRpc2FibGVkLAo+PiA+dGhlIGZ1bmN0aW9u IHdvdWxkIGZhaWxlZCwgdGhhdCBpcyB0ZXJyaWJsZS4KPj4gPgo+PiA+U2F2ZSBjb25uZWN0b3Ig dHlwZSBhbmQgb3V0cHV0IG1vZGUgb24gZHJtX2Rpc3BsYXlfbW9kZS0+cHJpdmF0ZV9mbGFncwo+ PiA+YXQgZW5jb2RlciBtb2RlX2ZpeHVwLCB0aGVuIHdlIGNhbiBjb25maWd1cmUgdGhlIHR5cGUg YW5kIG1vZGUgc2FmZWx5Cj4+ID5vbiBjcnRjIG1vZGVfc2V0Lgo+IFNpbmNlIFJvY2tjaGlwIGlz IGF0b21pYywgc2hvdWxkbid0IHRoaXMgYmUgdXNpbmcgYXRvbWljX2NoZWNrIGhvb2tzIGFuZAo+ IGEgc3ViY2xhc3NlZCBjcnRjX3N0YXRlIHN0cnVjdHVyZT8KPgoKUmlnaHQsIEdvb2QgaWRlYS4K ClRoYW5rcy4KCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 18 Apr 2016 17:54:09 +0800 Subject: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config In-Reply-To: <20160418102538.0ed730ca.john@metanate.com> References: <1460948611-32259-1-git-send-email-mark.yao@rock-chips.com> <20160418102538.0ed730ca.john@metanate.com> Message-ID: <5714AEC1.7050409@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?04?18? 17:25, John Keeping wrote: >> >We need to take care of the vop status when use >> >rockchip_drm_crtc_mode_config, if vop is disabled, >> >the function would failed, that is terrible. >> > >> >Save connector type and output mode on drm_display_mode->private_flags >> >at encoder mode_fixup, then we can configure the type and mode safely >> >on crtc mode_set. > Since Rockchip is atomic, shouldn't this be using atomic_check hooks and > a subclassed crtc_state structure? > Right, Good idea. Thanks. -- ?ark Yao