All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes
Date: Tue, 19 Apr 2016 08:36:01 +0300	[thread overview]
Message-ID: <5715C3C1.5000006@ti.com> (raw)
In-Reply-To: <1523377.BVFxig5LNh@avalon>


[-- Attachment #1.1.1: Type: text/plain, Size: 3007 bytes --]


On 19/04/16 05:17, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Monday 18 Apr 2016 18:42:11 Tomi Valkeinen wrote:
>> With certain kernel config options many omapdrm files fail to compile
>> due to missing include of linux/gpio/consumer.h and linux/of.h.
>>
>> This patch adds those includes.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Reported-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>  drivers/gpu/drm/omapdrm/displays/encoder-opa362.c           | 1 +
>>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c                | 1 +
>>  drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 1 +
>>  drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  | 1 +
>>  drivers/gpu/drm/omapdrm/dss/hdmi4.c                         | 1 +
>>  drivers/gpu/drm/omapdrm/dss/hdmi5.c                         | 1 +
>>  6 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
>> b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c index
>> 8c246c213e06..9f06a87e80c4 100644
>> --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
>> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
>> @@ -15,6 +15,7 @@
>>   */
>>
>>  #include <linux/gpio.h>
> 
> This driver uses the gpiod API only, you can remove gpio.h and of_gpio.h.

True. I don't want to mix fixes and cleanups, so I made a new patch for
that:

commit cdde6dcbf9fa0c5eadb42aac956a8ec3676aafb0 (HEAD -> 4.7/omapdrm)
Author: Tomi Valkeinen <tomi.valkeinen@ti.com>
Date:   Tue Apr 19 08:33:25 2016 +0300

    drm/omap: remove unneeded gpio includes

    encoder-opa362.c and panel-sharp-ls037v7dw01.c do not use the legacy
    GPIO API, so we can remove the including of gpio.h and of_gpio.h.

    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
index 9f06a87e80c4..e9b62a1bb5c5 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
@@ -14,12 +14,10 @@
  * the Free Software Foundation.
  */

-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
-#include <linux/of_gpio.h>

 #include <video/omapdss.h>

diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
index 1de5146c83c0..bbf529f15971 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
@@ -10,11 +10,9 @@
  */

 #include <linux/delay.h>
-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/regulator/consumer.h>


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-04-19  5:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 15:42 [PATCH 1/4] drm/omap: Fix missing includes Tomi Valkeinen
2016-04-18 15:42 ` [PATCH 2/4] drm/omap: remove unnecessary pitch round-up Tomi Valkeinen
2016-04-19  2:11   ` Laurent Pinchart
2016-04-18 15:42 ` [PATCH 3/4] drm/omap: remove align_pitch() Tomi Valkeinen
2016-04-19  2:12   ` Laurent Pinchart
2016-04-19  6:15     ` Tomi Valkeinen
2016-04-19  8:34       ` Laurent Pinchart
2016-04-18 15:42 ` [PATCH 4/4] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() Tomi Valkeinen
2016-04-19  2:17 ` [PATCH 1/4] drm/omap: Fix missing includes Laurent Pinchart
2016-04-19  5:36   ` Tomi Valkeinen [this message]
2016-04-19  8:32     ` Laurent Pinchart
2016-04-19  8:48       ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5715C3C1.5000006@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.