From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v3 3/3] drm/i915/guc: local optimisations
 and updating comments
Date: Tue, 19 Apr 2016 16:08:37 +0100
Message-ID: <571649F5.2030504@linux.intel.com>
References: <1461066350-32642-1-git-send-email-david.s.gordon@intel.com>
 <1461066350-32642-3-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id B32F76E7D0
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Apr 2016 15:10:10 +0000 (UTC)
In-Reply-To: <1461066350-32642-3-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE5LzA0LzE2IDEyOjQ1LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBUaWR5aW5nIHVwIGd1Y19p
bml0X3Byb2NfZGVzYygpIGFuZCBhZGRpbmcgY29tbWVudGFyeSB0byB0aGUgY2xpZW50Cj4gc3Ry
dWN0dXJlIGFmdGVyIHRoZSByZWNlbnQgY2hhbmdlIGluIEd1QyBwYWdlIG1hcHBpbmcgc3RyYXRl
Z3kuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwu
Y29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j
IHwgMzggKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysKPiAgIDIg
ZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4KPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggMTM1ZjA5NC4u
NWJiYjEzYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJt
aXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9u
LmMKPiBAQCAtMzU4LDEyICszNTgsMTQgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRfcHJvY19kZXNj
KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPiAgIHN0YXRpYyB2b2lkIGd1Y19pbml0X2N0eF9kZXNj
KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPiAgIAkJCSAgICAgIHN0cnVjdCBpOTE1X2d1Y19jbGll
bnQgKmNsaWVudCkKPiAgIHsKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpjbGllbnRf
b2JqID0gY2xpZW50LT5jbGllbnRfb2JqOwo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAq
ZW5naW5lOwo+ICAgCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHggPSBjbGllbnQtPm93bmVyOwo+
ICAgCXN0cnVjdCBndWNfY29udGV4dF9kZXNjIGRlc2M7Cj4gICAJc3RydWN0IHNnX3RhYmxlICpz
ZzsKPiAgIAllbnVtIGludGVsX2VuZ2luZV9pZCBpZDsKPiArCXUzMiBnZnhfYWRkcjsKPgo+ICAg
CW1lbXNldCgmZGVzYywgMCwgc2l6ZW9mKGRlc2MpKTsKPgo+IEBAIC0zOTIsMTYgKzM5NCwxNyBA
QCBzdGF0aWMgdm9pZCBndWNfaW5pdF9jdHhfZGVzYyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsCj4g
ICAJCWxyYy0+Y29udGV4dF9kZXNjID0gKHUzMiljdHhfZGVzYzsKPgo+ICAgCQkvKiBUaGUgc3Rh
dGUgcGFnZSBpcyBhZnRlciBQUEhXU1AgKi8KPiAtCQlscmMtPnJpbmdfbGNyYSA9IGk5MTVfZ2Vt
X29ial9nZ3R0X29mZnNldChvYmopICsKPiAtCQkJCUxSQ19TVEFURV9QTiAqIFBBR0VfU0laRTsK
PiArCQlnZnhfYWRkciA9IGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChvYmopOwo+ICsJCWxyYy0+
cmluZ19sY3JhID0gZ2Z4X2FkZHIgKyBMUkNfU1RBVEVfUE4gKiBQQUdFX1NJWkU7Cj4gICAJCWxy
Yy0+Y29udGV4dF9pZCA9IChjbGllbnQtPmN0eF9pbmRleCA8PCBHVUNfRUxDX0NUWElEX09GRlNF
VCkgfAo+ICAgCQkJCShlbmdpbmUtPmd1Y19pZCA8PCBHVUNfRUxDX0VOR0lORV9PRkZTRVQpOwo+
Cj4gICAJCW9iaiA9IGN0eC0+ZW5naW5lW2lkXS5yaW5nYnVmLT5vYmo7Cj4gKwkJZ2Z4X2FkZHIg
PSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKTsKPgo+IC0JCWxyYy0+cmluZ19iZWdpbiA9
IGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChvYmopOwo+IC0JCWxyYy0+cmluZ19lbmQgPSBscmMt
PnJpbmdfYmVnaW4gKyBvYmotPmJhc2Uuc2l6ZSAtIDE7Cj4gLQkJbHJjLT5yaW5nX25leHRfZnJl
ZV9sb2NhdGlvbiA9IGxyYy0+cmluZ19iZWdpbjsKPiArCQlscmMtPnJpbmdfYmVnaW4gPSBnZnhf
YWRkcjsKPiArCQlscmMtPnJpbmdfZW5kID0gZ2Z4X2FkZHIgKyBvYmotPmJhc2Uuc2l6ZSAtIDE7
Cj4gKwkJbHJjLT5yaW5nX25leHRfZnJlZV9sb2NhdGlvbiA9IGdmeF9hZGRyOwo+ICAgCQlscmMt
PnJpbmdfY3VycmVudF90YWlsX3BvaW50ZXJfdmFsdWUgPSAwOwo+Cj4gICAJCWRlc2MuZW5naW5l
c191c2VkIHw9ICgxIDw8IGVuZ2luZS0+Z3VjX2lkKTsKPiBAQCAtNDEwLDIyICs0MTMsMTcgQEAg
c3RhdGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+ICAg
CVdBUk5fT04oZGVzYy5lbmdpbmVzX3VzZWQgPT0gMCk7Cj4KPiAgIAkvKgo+IC0JICogVGhlIENQ
VSBhZGRyZXNzIGlzIG9ubHkgbmVlZGVkIGF0IGNlcnRhaW4gcG9pbnRzLCBzbyBrbWFwX2F0b21p
YyBvbgo+IC0JICogZGVtYW5kIGluc3RlYWQgb2Ygc3RvcmluZyBpdCBpbiB0aGUgY3R4IGRlc2Ny
aXB0b3IuCj4gLQkgKiBYWFg6IE1heSBtYWtlIGRlYnVnIGVhc2llciB0byBoYXZlIGl0IG1hcHBl
ZAo+ICsJICogVGhlIGRvb3JiZWxsLCBwcm9jZXNzIGRlc2NyaXB0b3IsIGFuZCB3b3JrcXVldWUg
YXJlIGFsbCBwYXJ0cwo+ICsJICogb2YgdGhlIGNsaWVudCBvYmplY3QsIHdoaWNoIHRoZSBHdUMg
d2lsbCByZWZlcmVuY2UgdmlhIHRoZSBHR1RUCj4gICAJICovCj4gLQlkZXNjLmRiX3RyaWdnZXJf
Y3B1ID0gMDsKPiAtCWRlc2MuZGJfdHJpZ2dlcl91ayA9IGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0
ICsKPiAtCQlpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKPiAt
CWRlc2MuZGJfdHJpZ2dlcl9waHkgPSBjbGllbnQtPmRvb3JiZWxsX29mZnNldCArCj4gLQkJc2df
ZG1hX2FkZHJlc3MoY2xpZW50LT5jbGllbnRfb2JqLT5wYWdlcy0+c2dsKTsKPiAtCj4gLQlkZXNj
LnByb2Nlc3NfZGVzYyA9IGNsaWVudC0+cHJvY19kZXNjX29mZnNldCArCj4gLQkJaTkxNV9nZW1f
b2JqX2dndHRfb2Zmc2V0KGNsaWVudC0+Y2xpZW50X29iaik7Cj4gLQo+IC0JZGVzYy53cV9hZGRy
ID0gY2xpZW50LT53cV9vZmZzZXQgKwo+IC0JCWk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChjbGll
bnQtPmNsaWVudF9vYmopOwo+IC0KPiArCWdmeF9hZGRyID0gaTkxNV9nZW1fb2JqX2dndHRfb2Zm
c2V0KGNsaWVudF9vYmopOwo+ICsJZGVzYy5kYl90cmlnZ2VyX3BoeSA9IHNnX2RtYV9hZGRyZXNz
KGNsaWVudF9vYmotPnBhZ2VzLT5zZ2wpICsKPiArCQkJCWNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0
Owo+ICsJZGVzYy5kYl90cmlnZ2VyX2NwdSA9ICh1aW50cHRyX3QpY2xpZW50LT5jbGllbnRfYmFz
ZSArCj4gKwkJCQljbGllbnQtPmRvb3JiZWxsX29mZnNldDsKClRoaXMgY2hhbmdlZCBmcm9tIHpl
cm8gdG8gdGhlIGFkZHJlc3MuIFdhcyBpdCBidWdneSBiZWZvcmU/Cgo+ICsJZGVzYy5kYl90cmln
Z2VyX3VrID0gZ2Z4X2FkZHIgKyBjbGllbnQtPmRvb3JiZWxsX29mZnNldDsKPiArCWRlc2MucHJv
Y2Vzc19kZXNjID0gZ2Z4X2FkZHIgKyBjbGllbnQtPnByb2NfZGVzY19vZmZzZXQ7Cj4gKwlkZXNj
LndxX2FkZHIgPSBnZnhfYWRkciArIGNsaWVudC0+d3Ffb2Zmc2V0Owo+ICAgCWRlc2Mud3Ffc2l6
ZSA9IGNsaWVudC0+d3Ffc2l6ZTsKPgo+ICAgCS8qCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2d1Yy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgK
PiBpbmRleCAxOWNhNTkzLi5jNTAzY2NkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2d1Yy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgK
PiBAQCAtMjksNiArMjksMjkgQEAKPgo+ICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0Owo+
Cj4gKy8qCj4gKyAqIFRoaXMgc3RydWN0dXJlIHByaW1hcmlseSBkZXNjcmliZXMgdGhlIEdFTSBv
YmplY3Qgc2hhcmVkIHdpdGggdGhlIEd1Qy4KPiArICogVGhlIEdFTSBvYmplY3QgaXMgaGVsZCBm
b3IgdGhlIGVudGlyZSBsaWZldGltZSBvZiBvdXIgaW50ZXJhY3Rpb24gd2l0aAo+ICsgKiB0aGUg
R3VDLCBiZWluZyBhbGxvY2F0ZWQgYmVmb3JlIHRoZSBHdUMgaXMgbG9hZGVkIHdpdGggaXRzIGZp
cm13YXJlLgo+ICsgKiBCZWNhdXNlIHRoZXJlJ3Mgbm8gd2F5IHRvIHVwZGF0ZSB0aGUgYWRkcmVz
cyB1c2VkIGJ5IHRoZSBHdUMgYWZ0ZXIKPiArICogaW5pdGlhbGlzYXRpb24sIHRoZSBzaGFyZWQg
b2JqZWN0IG11c3Qgc3RheSBwaW5uZWQgaW50byB0aGUgR0dUVCBhcwo+ICsgKiBsb25nIGFzIHRo
ZSBHdUMgaXMgaW4gdXNlLiBXZSBhbHNvIGtlZXAgdGhlIGZpcnN0IHBhZ2UgKG9ubHkpIG1hcHBl
ZAo+ICsgKiBpbnRvIGtlcm5lbCBhZGRyZXNzIHNwYWNlLCBhcyBpdCBpbmNsdWRlcyBzaGFyZWQg
ZGF0YSB0aGF0IG11c3QgYmUKPiArICogdXBkYXRlZCBvbiBldmVyeSByZXF1ZXN0IHN1Ym1pc3Np
b24uCj4gKyAqCj4gKyAqIFRoZSBzaW5nbGUgR0VNIG9iamVjdCBkZXNjcmliZWQgaGVyZSBpcyBh
Y3R1YWxseSBtYWRlIHVwIG9mIHNldmVyYWwKPiArICogc2VwYXJhdGUgYXJlYXMsIGFzIGZhciBh
cyB0aGUgR3VDIGlzIGNvbmNlcm5lZC4gVGhlIGZpcnN0IHBhZ2UgKGtlcHQKPiArICoga21hcCdk
KSBpbmNsdWRlcyB0aGUgInByb2Nlc3MgZGVjcmlwdG9yIiB3aGljaCBob2xkcyBzZXF1ZW5jZSBk
YXRhIGZvcgoKVHlwbyAtIGRlc2NyaXB0b3IuIDopIChzcG90dGVkIGJ5IFRodW5kZXJiaXJkKQoK
PiArICogdGhlIGRvb3JiZWxsLCBhbmQgb25lIGNhY2hlbGluZSB3aGljaCBhY3R1YWxseSAqaXMq
IHRoZSBkb29yYmVsbDsgYQo+ICsgKiB3cml0ZSB0byB0aGlzIHdpbGwgInJpbmciIHRoZSBkb29y
YmVsbCAoaS5lLiBzZW5kIGFuIGludGVycnVwdCB0byB0aGUKPiArICogR3VDKS4gVGhlIHN1YnNl
cXVlbnQgIHBhZ2VzIG9mIHRoZSBjbGllbnQgb2JqZWN0IGNvbnN0aXR1dGUgdGhlIHdvcmsKPiAr
ICogcXVldWUgKGEgY2lyY3VsYXIgYXJyYXkgb2Ygd29yayBpdGVtcyksIGFnYWluIGRlc2NyaWJl
ZCBpbiB0aGUgcHJvY2Vzcwo+ICsgKiBkZXNjcmlwdG9yLiBXb3JrIHF1ZXVlIHBhZ2VzIGFyZSBt
YXBwZWQgbW9tZW50YXJpbHkgYXMgcmVxdWlyZWQuCj4gKyAqCj4gKyAqIEZpbmFsbHksIHdlIGFs
c28ga2VlcCBhIGZldyBzdGF0aXN0aWNzIGhlcmUsIGluY2x1ZGluZyB0aGUgbnVtYmVyIG9mCj4g
KyAqIHN1Ym1pc3Npb25zIHRvIGVhY2ggZW5naW5lLCBhbmQgYSByZWNvcmQgb2YgdGhlIGxhc3Qg
c3VibWlzc2lvbiBmYWlsdXJlCj4gKyAqIChpZiBhbnkpLgo+ICsgKi8KPiAgIHN0cnVjdCBpOTE1
X2d1Y19jbGllbnQgewo+ICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpjbGllbnRfb2Jq
Owo+ICAgCXZvaWQgKmNsaWVudF9iYXNlOwkJLyogZmlyc3QgcGFnZSAob25seSkgb2YgYWJvdmUJ
Ki8KPgoKTG9va3MgZmluZSwgb25seSBxdWVzdGlvbiBtYXJrIG92ZXIgZGVzYy5kYl90cmlnZ2Vy
X2NwdSBpcyBwcmV2ZW50aW5nIHItYi4KClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK
SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=