On 04/19/2016 01:05 PM, Sascha Silbe wrote: > Dear Kevin, > > Kevin Wolf writes: > > [...] >> Isn't the JSON schema (qapi/block-core.json) considered the >> authoritative source for interface specifications these days? I think if >> we want to document the shortcomings for the time being, we should >> document it in both places. > > Interesting. What exactly is the relationship between qmp-commands.hx > and qapi/block-core.json? Ultimately, we want to make qmp-commands.hx go away, and have everything generated from qapi/*.json. Marc-Andre has proposed some patches along those lines (back in the 2.5 timeframe, but dependent on other qapi patches that are still pending review). > > At any rate, you're right that we should update both. See v2. Until we've automated the docs from a single source file, that is the correct approach. > > (And I've forgot the for-2.6 prefix for the patch itself again. Bah.) > > Sascha > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org