From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932357AbcDTBaP (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Apr 2016 21:30:15 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:43734 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932084AbcDTBaM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Apr 2016 21:30:12 -0400
Subject: Re: [PATCH v11 5/9] arm64: Kprobes with single stepping support
To: David Long <dave.long@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        William Cohen <wcohen@redhat.com>,
        "Pratyush Anand" <panand@redhat.com>,
        Steve Capper <steve.capper@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>
References: <1457501543-24197-1-git-send-email-dave.long@linaro.org>
 <1457501543-24197-6-git-send-email-dave.long@linaro.org>
CC: Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        John Blackwood <john.blackwood@ccur.com>, Feng Kan <fkan@apm.com>,
        Zi Shen Lim <zlim.lnx@gmail.com>, Dave P Martin <Dave.Martin@arm.com>,
        Yang Shi <yang.shi@linaro.org>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Kees Cook <keescook@chromium.org>,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        "Mark Brown" <broonie@kernel.org>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Mark Salyzyn <salyzyn@android.com>, James Morse <james.morse@arm.com>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Robin Murphy <Robin.Murphy@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Balamurugan Shanmugam <bshanmugam@apm.com>,
        Hanjun Guo <guohanjun@huawei.com>,
        Ding Tianhong <dingtianhong@huawei.com>, <wangnan0@huawei.com>
From: Li Bin <huawei.libin@huawei.com>
Message-ID: <5716DB78.2010109@huawei.com>
Date: Wed, 20 Apr 2016 09:29:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1457501543-24197-6-git-send-email-dave.long@linaro.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.23.78]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020204.5716DB88.0015,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 39ce1250fc935d2560b2abc29c11d61c
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

on 2016/3/9 13:32, David Long wrote:
> +int __kprobes arch_prepare_kprobe(struct kprobe *p)
> +{
> +	unsigned long probe_addr = (unsigned long)p->addr;

Here should verify the addr alignment:

	if (probe_addr & 0x3)
		return -EINVAL;

Thanks,
Li Bin

> +
> +	/* copy instruction */
> +	p->opcode = le32_to_cpu(*p->addr);
> +
> +	if (in_exception_text(probe_addr))
> +		return -EINVAL;
> +
> +	/* decode instruction */
> +	switch (arm_kprobe_decode_insn(p->addr, &p->ainsn)) {
> +	case INSN_REJECTED:	/* insn not supported */
> +		return -EINVAL;
> +
> +	case INSN_GOOD_NO_SLOT:	/* insn need simulation */
> +		return -EINVAL;
> +
> +	case INSN_GOOD:	/* instruction uses slot */
> +		p->ainsn.insn = get_insn_slot();
> +		if (!p->ainsn.insn)
> +			return -ENOMEM;
> +		break;
> +	};
> +
> +	/* prepare the instruction */
> +	arch_prepare_ss_slot(p);
> +
> +	return 0;
> +}
> +

From mboxrd@z Thu Jan  1 00:00:00 1970
From: huawei.libin@huawei.com (Li Bin)
Date: Wed, 20 Apr 2016 09:29:28 +0800
Subject: [PATCH v11 5/9] arm64: Kprobes with single stepping support
In-Reply-To: <1457501543-24197-6-git-send-email-dave.long@linaro.org>
References: <1457501543-24197-1-git-send-email-dave.long@linaro.org>
 <1457501543-24197-6-git-send-email-dave.long@linaro.org>
Message-ID: <5716DB78.2010109@huawei.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi David,

on 2016/3/9 13:32, David Long wrote:
> +int __kprobes arch_prepare_kprobe(struct kprobe *p)
> +{
> +	unsigned long probe_addr = (unsigned long)p->addr;

Here should verify the addr alignment:

	if (probe_addr & 0x3)
		return -EINVAL;

Thanks,
Li Bin

> +
> +	/* copy instruction */
> +	p->opcode = le32_to_cpu(*p->addr);
> +
> +	if (in_exception_text(probe_addr))
> +		return -EINVAL;
> +
> +	/* decode instruction */
> +	switch (arm_kprobe_decode_insn(p->addr, &p->ainsn)) {
> +	case INSN_REJECTED:	/* insn not supported */
> +		return -EINVAL;
> +
> +	case INSN_GOOD_NO_SLOT:	/* insn need simulation */
> +		return -EINVAL;
> +
> +	case INSN_GOOD:	/* instruction uses slot */
> +		p->ainsn.insn = get_insn_slot();
> +		if (!p->ainsn.insn)
> +			return -ENOMEM;
> +		break;
> +	};
> +
> +	/* prepare the instruction */
> +	arch_prepare_ss_slot(p);
> +
> +	return 0;
> +}
> +