From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932383AbcDTHLu (ORCPT ); Wed, 20 Apr 2016 03:11:50 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10794 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbcDTHLs (ORCPT ); Wed, 20 Apr 2016 03:11:48 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 20 Apr 2016 00:11:47 -0700 Subject: Re: next-20160401+: ARM: DRA7: linux-next regression: mm/slab: clean-up kmem_cache_node setup To: Joonsoo Kim , Nishanth Menon References: <570816F8.9070301@ti.com> <20160411020203.GA25211@js1304-P5Q-DELUXE> <570B8E0D.7020203@nvidia.com> CC: Russell King , Tony Lindgren , lkml , linux-next , Andrew Morton , linux-omap , "linux-arm-kernel@lists.infradead.org" From: Jon Hunter Message-ID: <57172BAD.5050200@nvidia.com> Date: Wed, 20 Apr 2016 08:11:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570B8E0D.7020203@nvidia.com> X-Originating-IP: [10.21.132.108] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joonsoo, On 11/04/16 12:44, Jon Hunter wrote: > On 11/04/16 03:02, Joonsoo Kim wrote: >> On Fri, Apr 08, 2016 at 03:39:20PM -0500, Nishanth Menon wrote: >>> Hi, >>> >>> http://marc.info/?l=linux-omap&m=146014314115625&w=2 series works with >>> v4.6-rc2 kernel, however, it fails with linux-next for suspend-to-ram >>> (mem) on BeagleBoard-X15 >>> >>> next-20160327 - good >>> next-20160329 - good >>> next-20160330 - Fails to boot - I2C crashes >>> next-20160331- Fails to boot - USB crashes >>> next-20160401 -> bad >>> next-20160408 -> bad >>> >>> Bisect log of next-20160408 vs v4.6-rc2 -> >>> http://pastebin.ubuntu.com/15697856/ >>> >>> # first bad commit: [2b629704a2b6a5b239f23750e5517a9d8c3a4e8c] >>> mm/slab: clean-up kmem_cache_node setup >>> >> >> Hello, >> >> I made a mistake on that patch. Could you try to test below one on >> top of it. >> >> Thanks. >> >> --------->8---------------- >> From d3af3cc409527e9be6beb62ea395cde67f3c5029 Mon Sep 17 00:00:00 2001 >> From: Joonsoo Kim >> Date: Mon, 11 Apr 2016 10:48:29 +0900 >> Subject: [PATCH] mm/slab: clean-up kmem_cache_node setup-fix >> >> After calling free_block(), we need to re-calculate array_cache's >> avail counter. Fix it. >> >> And, it's better to free objects in shared array when it is >> really necessary. Check it before calling free_block(). >> >> Signed-off-by: Joonsoo Kim >> --- >> mm/slab.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/slab.c b/mm/slab.c >> index fcd5fbb..27cb390 100644 >> --- a/mm/slab.c >> +++ b/mm/slab.c >> @@ -927,9 +927,10 @@ static int setup_kmem_cache_node(struct kmem_cache *cachep, >> >> n = get_node(cachep, node); >> spin_lock_irq(&n->list_lock); >> - if (n->shared) { >> + if (n->shared && force_change) { >> free_block(cachep, n->shared->entry, >> n->shared->avail, node, &list); >> + n->shared->avail = 0; >> } >> >> if (!n->shared || force_change) { > > This also fixes a regression on -next for Tegra that was bisected down > to the same culprit. So ... > > Tested-by: Jon Hunter This fix still doesn't appear to have made it into -next and this has been broken now for nearly 3 weeks. Any chance we can get this into -next? Cheers Jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: next-20160401+: ARM: DRA7: linux-next regression: mm/slab: clean-up kmem_cache_node setup Date: Wed, 20 Apr 2016 08:11:41 +0100 Message-ID: <57172BAD.5050200@nvidia.com> References: <570816F8.9070301@ti.com> <20160411020203.GA25211@js1304-P5Q-DELUXE> <570B8E0D.7020203@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:10794 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbcDTHLs (ORCPT ); Wed, 20 Apr 2016 03:11:48 -0400 In-Reply-To: <570B8E0D.7020203@nvidia.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Joonsoo Kim , Nishanth Menon Cc: Russell King , Tony Lindgren , lkml , linux-next , Andrew Morton , linux-omap , "linux-arm-kernel@lists.infradead.org" Hi Joonsoo, On 11/04/16 12:44, Jon Hunter wrote: > On 11/04/16 03:02, Joonsoo Kim wrote: >> On Fri, Apr 08, 2016 at 03:39:20PM -0500, Nishanth Menon wrote: >>> Hi, >>> >>> http://marc.info/?l=linux-omap&m=146014314115625&w=2 series works with >>> v4.6-rc2 kernel, however, it fails with linux-next for suspend-to-ram >>> (mem) on BeagleBoard-X15 >>> >>> next-20160327 - good >>> next-20160329 - good >>> next-20160330 - Fails to boot - I2C crashes >>> next-20160331- Fails to boot - USB crashes >>> next-20160401 -> bad >>> next-20160408 -> bad >>> >>> Bisect log of next-20160408 vs v4.6-rc2 -> >>> http://pastebin.ubuntu.com/15697856/ >>> >>> # first bad commit: [2b629704a2b6a5b239f23750e5517a9d8c3a4e8c] >>> mm/slab: clean-up kmem_cache_node setup >>> >> >> Hello, >> >> I made a mistake on that patch. Could you try to test below one on >> top of it. >> >> Thanks. >> >> --------->8---------------- >> From d3af3cc409527e9be6beb62ea395cde67f3c5029 Mon Sep 17 00:00:00 2001 >> From: Joonsoo Kim >> Date: Mon, 11 Apr 2016 10:48:29 +0900 >> Subject: [PATCH] mm/slab: clean-up kmem_cache_node setup-fix >> >> After calling free_block(), we need to re-calculate array_cache's >> avail counter. Fix it. >> >> And, it's better to free objects in shared array when it is >> really necessary. Check it before calling free_block(). >> >> Signed-off-by: Joonsoo Kim >> --- >> mm/slab.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/slab.c b/mm/slab.c >> index fcd5fbb..27cb390 100644 >> --- a/mm/slab.c >> +++ b/mm/slab.c >> @@ -927,9 +927,10 @@ static int setup_kmem_cache_node(struct kmem_cache *cachep, >> >> n = get_node(cachep, node); >> spin_lock_irq(&n->list_lock); >> - if (n->shared) { >> + if (n->shared && force_change) { >> free_block(cachep, n->shared->entry, >> n->shared->avail, node, &list); >> + n->shared->avail = 0; >> } >> >> if (!n->shared || force_change) { > > This also fixes a regression on -next for Tegra that was bisected down > to the same culprit. So ... > > Tested-by: Jon Hunter This fix still doesn't appear to have made it into -next and this has been broken now for nearly 3 weeks. Any chance we can get this into -next? Cheers Jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonathanh@nvidia.com (Jon Hunter) Date: Wed, 20 Apr 2016 08:11:41 +0100 Subject: next-20160401+: ARM: DRA7: linux-next regression: mm/slab: clean-up kmem_cache_node setup In-Reply-To: <570B8E0D.7020203@nvidia.com> References: <570816F8.9070301@ti.com> <20160411020203.GA25211@js1304-P5Q-DELUXE> <570B8E0D.7020203@nvidia.com> Message-ID: <57172BAD.5050200@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joonsoo, On 11/04/16 12:44, Jon Hunter wrote: > On 11/04/16 03:02, Joonsoo Kim wrote: >> On Fri, Apr 08, 2016 at 03:39:20PM -0500, Nishanth Menon wrote: >>> Hi, >>> >>> http://marc.info/?l=linux-omap&m=146014314115625&w=2 series works with >>> v4.6-rc2 kernel, however, it fails with linux-next for suspend-to-ram >>> (mem) on BeagleBoard-X15 >>> >>> next-20160327 - good >>> next-20160329 - good >>> next-20160330 - Fails to boot - I2C crashes >>> next-20160331- Fails to boot - USB crashes >>> next-20160401 -> bad >>> next-20160408 -> bad >>> >>> Bisect log of next-20160408 vs v4.6-rc2 -> >>> http://pastebin.ubuntu.com/15697856/ >>> >>> # first bad commit: [2b629704a2b6a5b239f23750e5517a9d8c3a4e8c] >>> mm/slab: clean-up kmem_cache_node setup >>> >> >> Hello, >> >> I made a mistake on that patch. Could you try to test below one on >> top of it. >> >> Thanks. >> >> --------->8---------------- >> From d3af3cc409527e9be6beb62ea395cde67f3c5029 Mon Sep 17 00:00:00 2001 >> From: Joonsoo Kim >> Date: Mon, 11 Apr 2016 10:48:29 +0900 >> Subject: [PATCH] mm/slab: clean-up kmem_cache_node setup-fix >> >> After calling free_block(), we need to re-calculate array_cache's >> avail counter. Fix it. >> >> And, it's better to free objects in shared array when it is >> really necessary. Check it before calling free_block(). >> >> Signed-off-by: Joonsoo Kim >> --- >> mm/slab.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/slab.c b/mm/slab.c >> index fcd5fbb..27cb390 100644 >> --- a/mm/slab.c >> +++ b/mm/slab.c >> @@ -927,9 +927,10 @@ static int setup_kmem_cache_node(struct kmem_cache *cachep, >> >> n = get_node(cachep, node); >> spin_lock_irq(&n->list_lock); >> - if (n->shared) { >> + if (n->shared && force_change) { >> free_block(cachep, n->shared->entry, >> n->shared->avail, node, &list); >> + n->shared->avail = 0; >> } >> >> if (!n->shared || force_change) { > > This also fixes a regression on -next for Tegra that was bisected down > to the same culprit. So ... > > Tested-by: Jon Hunter This fix still doesn't appear to have made it into -next and this has been broken now for nearly 3 weeks. Any chance we can get this into -next? Cheers Jon