From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932953AbcDTIWE (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Apr 2016 04:22:04 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:21334 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932447AbcDTIWA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Apr 2016 04:22:00 -0400
Subject: Re: [PATCH v5 3/6] perf record: Force enable --timestamp-filename
 when --switch-output is provided
To: Jiri Olsa <jolsa@redhat.com>
References: <1460991332-185772-1-git-send-email-wangnan0@huawei.com>
 <1460991332-185772-4-git-send-email-wangnan0@huawei.com>
 <20160420075945.GA18012@krava.redhat.com>
CC: <acme@kernel.org>, <linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Jiri Olsa <jolsa@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>,
        He Kuang <hekuang@huawei.com>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>
From: "Wangnan (F)" <wangnan0@huawei.com>
Message-ID: <57173BFD.2040906@huawei.com>
Date: Wed, 20 Apr 2016 16:21:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160420075945.GA18012@krava.redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020205.57173C0A.013B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 17507004c0b87331358ed2c5ad4be445
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/4/20 15:59, Jiri Olsa wrote:
> On Mon, Apr 18, 2016 at 02:55:29PM +0000, Wang Nan wrote:
>> Without this patch, the last output doesn't have timestamp appended if
>> --timestamp-filename is not explicitly provided. For example:
>>
>>    # perf record -a --switch-output &
>>    [1] 11224
>>    # kill -s SIGUSR2 11224
>>    [ perf record: dump data: Woken up 1 times ]
>>    # [ perf record: Dump perf.data.2015122622372823 ]
>>
>>    # fg
>>    perf record -a --switch-output
>>    ^C[ perf record: Woken up 1 times to write data ]
>>    [ perf record: Captured and wrote 0.027 MB perf.data (540 samples) ]
>>
>>    # ls -l
>>    total 836
>>    -rw------- 1 root root  33256 Dec 26 22:37 perf.data   <---- *Odd*
>>    -rw------- 1 root root 817156 Dec 26 22:37 perf.data.2015122622372823
> I'm getting this:
>
> [root@krava perf]# ./perf record -a --switch-output &
> [root@krava perf]# kill -s SIGUSR2 18974
> [ perf record: dump data: Woken up 4 times ]
> [ perf record: Dump perf.data.2016042009574314 ]
>
> [root@krava perf]# ./perf report -i perf.data.2016042009574314
> perf: Segmentation fault
> -------- backtrace --------
> ./perf[0x552b0b]
> /lib64/libc.so.6(+0x34a50)[0x7f711b434a50]
> /lib64/libc.so.6(strlen+0x2a)[0x7f711b48b33a]
> ./perf(perf_hpp__reset_sort_width+0x4f)[0x4e9b1f]
> ./perf[0x54b113]
> ./perf(perf_evlist__tui_browse_hists+0x91)[0x551361]
> ./perf(cmd_report+0x1a34)[0x434b44]
> ./perf[0x485681]
> ./perf(main+0x672)[0x424382]
> /lib64/libc.so.6(__libc_start_main+0xf0)[0x7f711b420700]
> ./perf(_start+0x29)[0x4244a9]
> [0x0]

Can't reproduce... Can you get reproduce problem without this patch (3/6)?

My local tree is based on newest perf/core (commit ccd62a8 "perf trace:
Fix build when DWARF unwind isn't available"). Could you please check your
source?

Thank you.

>
> thanks,
> jirka