From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
vinod.koul@intel.com, tiwai@suse.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH v5 2/4] ALSA: compress: Add function to indicate the stream has gone bad
Date: Wed, 20 Apr 2016 11:10:21 -0500 [thread overview]
Message-ID: <5717A9ED.50706@linux.intel.com> (raw)
In-Reply-To: <1461156003-24422-3-git-send-email-ckeepax@opensource.wolfsonmicro.com>
> + * snd_compr_stop_error: Report a fatal error on a stream
> + * @stream: pointer to stream
> + * @state: state to transition the stream to
> + *
> + * Stop the stream and set its state.
> + *
> + * Should be called with compressed device lock held.
> + */
> +int snd_compr_stop_error(struct snd_compr_stream *stream,
> + snd_pcm_state_t state)
> +{
> + if (stream->runtime->state == state)
> + return 0;
> +
> + stream->runtime->state = state;
Minor nit-pick: should there be a consistency check to make sure the new
state makes sense - or maybe just a log to help debug? e.g. XRUN should
only come if the state in run or draining stages, applying the new state
unconditionally could lead to issues.
And question for my education since I see no lock/mutex: is the state
always consistent or is there a risk of this state being changed while
some other thread or interrupt handling modifies it was well?
next prev parent reply other threads:[~2016-04-20 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 12:39 [PATCH v5 0/4] Propagate errors out from compressed streams Charles Keepax
2016-04-20 12:40 ` [PATCH v5 1/4] ALSA: compress: Replace complex if statement with switch Charles Keepax
2016-04-20 12:40 ` [PATCH v5 2/4] ALSA: compress: Add function to indicate the stream has gone bad Charles Keepax
2016-04-20 13:08 ` Vinod Koul
2016-04-20 14:54 ` Charles Keepax
2016-04-21 2:25 ` Vinod Koul
2016-04-20 16:10 ` Pierre-Louis Bossart [this message]
2016-04-21 8:26 ` Charles Keepax
2016-04-21 12:37 ` Pierre-Louis Bossart
2016-04-20 12:40 ` [PATCH v5 3/4] ASoC: wm_adsp: Use new snd_compr_stop_error to signal stream failure Charles Keepax
2016-04-20 13:09 ` Vinod Koul
2016-04-20 12:40 ` [PATCH v5 4/4] ASoC: compress: Pass error out of soc_compr_pointer Charles Keepax
2016-04-20 13:09 ` [PATCH v5 0/4] Propagate errors out from compressed streams Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717A9ED.50706@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.