From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH v5 12/14] arm64, acpi, numa: NUMA support based on SRAT and SLIT Date: Wed, 20 Apr 2016 09:29:45 -0700 Message-ID: <5717AE79.5060605@gmail.com> References: <1461116439-22991-1-git-send-email-ddaney.cavm@gmail.com> <1461116439-22991-13-git-send-email-ddaney.cavm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:33069 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbcDTQ3t (ORCPT ); Wed, 20 Apr 2016 12:29:49 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Ganapatrao Kulkarni Cc: Dennis Chen , Mark Rutland , linux-ia64@vger.kernel.org, David Daney , Catalin Marinas , Will Deacon , Lv Zheng , "H. Peter Anvin" , Frank Rowand , x86@kernel.org, Robert Moore , linux-acpi@vger.kernel.org, Ingo Molnar , Grant Likely , Len Brown , Fenghua Yu , Marc Zyngier , Robert Richter , Rob Herring , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , devel@acpica.org, Tony Luck , "Rafael J. Wysocki" , linux-kernel@v On 04/20/2016 01:31 AM, Ganapatrao Kulkarni wrote: > On Wed, Apr 20, 2016 at 1:11 PM, Dennis Chen wrote: >> On 20 April 2016 at 09:40, David Daney wrote: [...] >>> @@ -388,7 +389,9 @@ static int __init dummy_numa_init(void) >>> void __init arm64_numa_init(void) >>> { >>> if (!numa_off) { >>> - if (!numa_init(of_numa_init)) >>> + if (!acpi_disabled && !numa_init(arm64_acpi_numa_init)) >>> + return; >>> + if (acpi_disabled && !numa_init(of_numa_init)) >>> return; >>> } >>> >> On top of the latest version of the dt-based numa patch, if 'numa=off' >> specified in the command line, >> this function will fallback to invoke dummy_numa_init(), which give >> rise the question here is, do we need to >> touch any ACPI related stuff in the case? If not, then the output > > no, ACPI is not fallback configuration for DT and vice versa. > >> message "No NUMA configuration found" followed >> seems is not necessary since it's a little bit confusing in case of >> numa has already been turned off explicitly. > > thanks, this print can be moved out. > from function dummy_numa_init and it can be added in function arm64_numa_init > as a last line of if (!numa_off) to indicate, ACPI/DT based NUMA > configuration failed. > > more appropriate would be, > pr_info("%s\n", "NUMA configuration failed or not found"); > Although purely cosmetic, I agree that we need to improve the messages as to not confuse people. I will rework the messages with your suggestions in mind to see if we can get something that is both concise and unambiguously reflects what the user asked for. David. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbcDTQ3w (ORCPT ); Wed, 20 Apr 2016 12:29:52 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33069 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbcDTQ3t (ORCPT ); Wed, 20 Apr 2016 12:29:49 -0400 Message-ID: <5717AE79.5060605@gmail.com> Date: Wed, 20 Apr 2016 09:29:45 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ganapatrao Kulkarni CC: Dennis Chen , Mark Rutland , linux-ia64@vger.kernel.org, David Daney , Catalin Marinas , Will Deacon , Lv Zheng , "H. Peter Anvin" , Frank Rowand , x86@kernel.org, Robert Moore , linux-acpi@vger.kernel.org, Ingo Molnar , Grant Likely , Len Brown , Fenghua Yu , Marc Zyngier , Robert Richter , Rob Herring , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , devel@acpica.org, Tony Luck , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Hanjun Guo , Ganapatrao Kulkarni Subject: Re: [PATCH v5 12/14] arm64, acpi, numa: NUMA support based on SRAT and SLIT References: <1461116439-22991-1-git-send-email-ddaney.cavm@gmail.com> <1461116439-22991-13-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2016 01:31 AM, Ganapatrao Kulkarni wrote: > On Wed, Apr 20, 2016 at 1:11 PM, Dennis Chen wrote: >> On 20 April 2016 at 09:40, David Daney wrote: [...] >>> @@ -388,7 +389,9 @@ static int __init dummy_numa_init(void) >>> void __init arm64_numa_init(void) >>> { >>> if (!numa_off) { >>> - if (!numa_init(of_numa_init)) >>> + if (!acpi_disabled && !numa_init(arm64_acpi_numa_init)) >>> + return; >>> + if (acpi_disabled && !numa_init(of_numa_init)) >>> return; >>> } >>> >> On top of the latest version of the dt-based numa patch, if 'numa=off' >> specified in the command line, >> this function will fallback to invoke dummy_numa_init(), which give >> rise the question here is, do we need to >> touch any ACPI related stuff in the case? If not, then the output > > no, ACPI is not fallback configuration for DT and vice versa. > >> message "No NUMA configuration found" followed >> seems is not necessary since it's a little bit confusing in case of >> numa has already been turned off explicitly. > > thanks, this print can be moved out. > from function dummy_numa_init and it can be added in function arm64_numa_init > as a last line of if (!numa_off) to indicate, ACPI/DT based NUMA > configuration failed. > > more appropriate would be, > pr_info("%s\n", "NUMA configuration failed or not found"); > Although purely cosmetic, I agree that we need to improve the messages as to not confuse people. I will rework the messages with your suggestions in mind to see if we can get something that is both concise and unambiguously reflects what the user asked for. David. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ddaney.cavm@gmail.com (David Daney) Date: Wed, 20 Apr 2016 09:29:45 -0700 Subject: [PATCH v5 12/14] arm64, acpi, numa: NUMA support based on SRAT and SLIT In-Reply-To: References: <1461116439-22991-1-git-send-email-ddaney.cavm@gmail.com> <1461116439-22991-13-git-send-email-ddaney.cavm@gmail.com> Message-ID: <5717AE79.5060605@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/20/2016 01:31 AM, Ganapatrao Kulkarni wrote: > On Wed, Apr 20, 2016 at 1:11 PM, Dennis Chen wrote: >> On 20 April 2016 at 09:40, David Daney wrote: [...] >>> @@ -388,7 +389,9 @@ static int __init dummy_numa_init(void) >>> void __init arm64_numa_init(void) >>> { >>> if (!numa_off) { >>> - if (!numa_init(of_numa_init)) >>> + if (!acpi_disabled && !numa_init(arm64_acpi_numa_init)) >>> + return; >>> + if (acpi_disabled && !numa_init(of_numa_init)) >>> return; >>> } >>> >> On top of the latest version of the dt-based numa patch, if 'numa=off' >> specified in the command line, >> this function will fallback to invoke dummy_numa_init(), which give >> rise the question here is, do we need to >> touch any ACPI related stuff in the case? If not, then the output > > no, ACPI is not fallback configuration for DT and vice versa. > >> message "No NUMA configuration found" followed >> seems is not necessary since it's a little bit confusing in case of >> numa has already been turned off explicitly. > > thanks, this print can be moved out. > from function dummy_numa_init and it can be added in function arm64_numa_init > as a last line of if (!numa_off) to indicate, ACPI/DT based NUMA > configuration failed. > > more appropriate would be, > pr_info("%s\n", "NUMA configuration failed or not found"); > Although purely cosmetic, I agree that we need to improve the messages as to not confuse people. I will rework the messages with your suggestions in mind to see if we can get something that is both concise and unambiguously reflects what the user asked for. David. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Date: Wed, 20 Apr 2016 16:29:45 +0000 Subject: Re: [PATCH v5 12/14] arm64, acpi, numa: NUMA support based on SRAT and SLIT Message-Id: <5717AE79.5060605@gmail.com> List-Id: References: <1461116439-22991-1-git-send-email-ddaney.cavm@gmail.com> <1461116439-22991-13-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ganapatrao Kulkarni Cc: Dennis Chen , Mark Rutland , linux-ia64@vger.kernel.org, David Daney , Catalin Marinas , Will Deacon , Lv Zheng , "H. Peter Anvin" , Frank Rowand , x86@kernel.org, Robert Moore , linux-acpi@vger.kernel.org, Ingo Molnar , Grant Likely , Len Brown , Fenghua Yu , Marc Zyngier , Robert Richter , Rob Herring , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , devel@acpica.org, Tony Luck , "Rafael J. Wysocki" , linux-kernel@v On 04/20/2016 01:31 AM, Ganapatrao Kulkarni wrote: > On Wed, Apr 20, 2016 at 1:11 PM, Dennis Chen wrote: >> On 20 April 2016 at 09:40, David Daney wrote: [...] >>> @@ -388,7 +389,9 @@ static int __init dummy_numa_init(void) >>> void __init arm64_numa_init(void) >>> { >>> if (!numa_off) { >>> - if (!numa_init(of_numa_init)) >>> + if (!acpi_disabled && !numa_init(arm64_acpi_numa_init)) >>> + return; >>> + if (acpi_disabled && !numa_init(of_numa_init)) >>> return; >>> } >>> >> On top of the latest version of the dt-based numa patch, if 'numa=off' >> specified in the command line, >> this function will fallback to invoke dummy_numa_init(), which give >> rise the question here is, do we need to >> touch any ACPI related stuff in the case? If not, then the output > > no, ACPI is not fallback configuration for DT and vice versa. > >> message "No NUMA configuration found" followed >> seems is not necessary since it's a little bit confusing in case of >> numa has already been turned off explicitly. > > thanks, this print can be moved out. > from function dummy_numa_init and it can be added in function arm64_numa_init > as a last line of if (!numa_off) to indicate, ACPI/DT based NUMA > configuration failed. > > more appropriate would be, > pr_info("%s\n", "NUMA configuration failed or not found"); > Although purely cosmetic, I agree that we need to improve the messages as to not confuse people. I will rework the messages with your suggestions in mind to see if we can get something that is both concise and unambiguously reflects what the user asked for. David.