From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbcDTSdZ (ORCPT ); Wed, 20 Apr 2016 14:33:25 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:33597 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbcDTSdY (ORCPT ); Wed, 20 Apr 2016 14:33:24 -0400 Subject: Re: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-6-git-send-email-noralf@tronnes.org> <20160420174414.GQ2510@phenom.ffwll.local> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <5717CB6D.8000708@tronnes.org> Date: Wed, 20 Apr 2016 20:33:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160420174414.GQ2510@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 20.04.2016 19:44, skrev Daniel Vetter: > On Wed, Apr 20, 2016 at 05:25:26PM +0200, Noralf Trønnes wrote: >> Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot. >> When the framebuffer memory is allocated using dma_alloc_writecombine() >> instead of vmalloc(), I get cache syncing problems. >> This solves it: >> >> static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info, >> struct vm_area_struct *vma) >> { >> fb_deferred_io_mmap(info, vma); >> vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > Hm, do we need pgpropt_writecombine? There recently was some discussion > (on the arc platform) that fbdev pgprots need to be fixed up in fbdev > code. I have no idea, just repeating from memory ... I need it or else I get partial lines that doesn't get updated on the display. fbdev code that doesn't set (struct fb_ops *)->fb_mmap, gets this for free in the default fb_mmap implementation (drivers/video/fbdev/core/fbmem.c). It calls fb_pgprotect() at the end which is an architecture specific function that on many platforms uses pgprot_writecombine(), but not on all. And looking at some of the fb_mmap implementations, some of them sets vm_page_prot to nocache for instance, so I think the safest bet is to do this here and not in the fbdev core. And we can't call fb_pgprotect() from fb_deferred_io_mmap() either because we don't have access to the file pointer that powerpc needs. I think the case you refer to was solved with using fb_pgprotect() for the platform in question and it didn't involve deferred io. > -Daniel > >> return 0; >> } >> >> Signed-off-by: Noralf Trønnes >> --- >> drivers/video/fbdev/core/fb_defio.c | 3 ++- >> include/linux/fb.h | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c >> index 57721c7..74b5bca 100644 >> --- a/drivers/video/fbdev/core/fb_defio.c >> +++ b/drivers/video/fbdev/core/fb_defio.c >> @@ -164,7 +164,7 @@ static const struct address_space_operations fb_deferred_io_aops = { >> .set_page_dirty = fb_deferred_io_set_page_dirty, >> }; >> >> -static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) >> +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) >> { >> vma->vm_ops = &fb_deferred_io_vm_ops; >> vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP; >> @@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) >> vma->vm_private_data = info; >> return 0; >> } >> +EXPORT_SYMBOL(fb_deferred_io_mmap); >> >> /* workqueue callback */ >> static void fb_deferred_io_work(struct work_struct *work) >> diff --git a/include/linux/fb.h b/include/linux/fb.h >> index dfe8835..a964d07 100644 >> --- a/include/linux/fb.h >> +++ b/include/linux/fb.h >> @@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, >> } >> >> /* drivers/video/fb_defio.c */ >> +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma); >> extern void fb_deferred_io_init(struct fb_info *info); >> extern void fb_deferred_io_open(struct fb_info *info, >> struct inode *inode, >> -- >> 2.2.2 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Date: Wed, 20 Apr 2016 18:33:17 +0000 Subject: Re: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap Message-Id: <5717CB6D.8000708@tronnes.org> List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-6-git-send-email-noralf@tronnes.org> <20160420174414.GQ2510@phenom.ffwll.local> In-Reply-To: <20160420174414.GQ2510@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Den 20.04.2016 19:44, skrev Daniel Vetter: > On Wed, Apr 20, 2016 at 05:25:26PM +0200, Noralf Tr=F8nnes wrote: >> Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot. >> When the framebuffer memory is allocated using dma_alloc_writecombine() >> instead of vmalloc(), I get cache syncing problems. >> This solves it: >> >> static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info, >> struct vm_area_struct *vma) >> { >> fb_deferred_io_mmap(info, vma); >> vma->vm_page_prot =3D pgprot_writecombine(vma->vm_page_prot); > Hm, do we need pgpropt_writecombine? There recently was some discussion > (on the arc platform) that fbdev pgprots need to be fixed up in fbdev > code. I have no idea, just repeating from memory ... I need it or else I get partial lines that doesn't get updated on the=20 display. fbdev code that doesn't set (struct fb_ops *)->fb_mmap, gets this for free in the default fb_mmap implementation (drivers/video/fbdev/core/fbmem.c). It calls fb_pgprotect() at the end which is an architecture specific function that on many platforms uses pgprot_writecombine(), but not on all. And looking at some of the fb_mmap implementations, some of them sets vm_page_prot to nocache for instance, so I think the safest bet is to do this here and not in the fbdev core. And we can't call fb_pgprotect() from fb_deferred_io_mmap() either because we don't have access to the file pointer that powerpc needs. I think the case you refer to was solved with using fb_pgprotect() for the platform in question and it didn't involve deferred io. > -Daniel > >> return 0; >> } >> >> Signed-off-by: Noralf Tr=F8nnes >> --- >> drivers/video/fbdev/core/fb_defio.c | 3 ++- >> include/linux/fb.h | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/c= ore/fb_defio.c >> index 57721c7..74b5bca 100644 >> --- a/drivers/video/fbdev/core/fb_defio.c >> +++ b/drivers/video/fbdev/core/fb_defio.c >> @@ -164,7 +164,7 @@ static const struct address_space_operations fb_defe= rred_io_aops =3D { >> .set_page_dirty =3D fb_deferred_io_set_page_dirty, >> }; >> =20 >> -static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_str= uct *vma) >> +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vm= a) >> { >> vma->vm_ops =3D &fb_deferred_io_vm_ops; >> vma->vm_flags |=3D VM_DONTEXPAND | VM_DONTDUMP; >> @@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info,= struct vm_area_struct *vma) >> vma->vm_private_data =3D info; >> return 0; >> } >> +EXPORT_SYMBOL(fb_deferred_io_mmap); >> =20 >> /* workqueue callback */ >> static void fb_deferred_io_work(struct work_struct *work) >> diff --git a/include/linux/fb.h b/include/linux/fb.h >> index dfe8835..a964d07 100644 >> --- a/include/linux/fb.h >> +++ b/include/linux/fb.h >> @@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, = u32 d_pitch, >> } >> =20 >> /* drivers/video/fb_defio.c */ >> +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vm= a); >> extern void fb_deferred_io_init(struct fb_info *info); >> extern void fb_deferred_io_open(struct fb_info *info, >> struct inode *inode, >> --=20 >> 2.2.2 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap Date: Wed, 20 Apr 2016 20:33:17 +0200 Message-ID: <5717CB6D.8000708@tronnes.org> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-6-git-send-email-noralf@tronnes.org> <20160420174414.GQ2510@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id E57336E22E for ; Wed, 20 Apr 2016 18:33:23 +0000 (UTC) In-Reply-To: <20160420174414.GQ2510@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAyMC4wNC4yMDE2IDE5OjQ0LCBza3JldiBEYW5pZWwgVmV0dGVyOgo+IE9uIFdlZCwgQXBy IDIwLCAyMDE2IGF0IDA1OjI1OjI2UE0gKzAyMDAsIE5vcmFsZiBUcsO4bm5lcyB3cm90ZToKPj4g RXhwb3J0IGZiX2RlZmVycmVkX2lvX21tYXAgc28gZHJpdmVycyBjYW4gY2hhbmdlIHZtYS0+dm1f cGFnZV9wcm90Lgo+PiBXaGVuIHRoZSBmcmFtZWJ1ZmZlciBtZW1vcnkgaXMgYWxsb2NhdGVkIHVz aW5nIGRtYV9hbGxvY193cml0ZWNvbWJpbmUoKQo+PiBpbnN0ZWFkIG9mIHZtYWxsb2MoKSwgSSBn ZXQgY2FjaGUgc3luY2luZyBwcm9ibGVtcy4KPj4gVGhpcyBzb2x2ZXMgaXQ6Cj4+Cj4+IHN0YXRp YyBpbnQgZHJtX2ZiZGV2X2NtYV9kZWZlcnJlZF9pb19tbWFwKHN0cnVjdCBmYl9pbmZvICppbmZv LAo+PiAJCQkJCSAgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpCj4+IHsKPj4gCWZiX2RlZmVy cmVkX2lvX21tYXAoaW5mbywgdm1hKTsKPj4gCXZtYS0+dm1fcGFnZV9wcm90ID0gcGdwcm90X3dy aXRlY29tYmluZSh2bWEtPnZtX3BhZ2VfcHJvdCk7Cj4gSG0sIGRvIHdlIG5lZWQgcGdwcm9wdF93 cml0ZWNvbWJpbmU/IFRoZXJlIHJlY2VudGx5IHdhcyBzb21lIGRpc2N1c3Npb24KPiAob24gdGhl IGFyYyBwbGF0Zm9ybSkgdGhhdCBmYmRldiBwZ3Byb3RzIG5lZWQgdG8gYmUgZml4ZWQgdXAgaW4g ZmJkZXYKPiBjb2RlLiBJIGhhdmUgbm8gaWRlYSwganVzdCByZXBlYXRpbmcgZnJvbSBtZW1vcnkg Li4uCgpJIG5lZWQgaXQgb3IgZWxzZSBJIGdldCBwYXJ0aWFsIGxpbmVzIHRoYXQgZG9lc24ndCBn ZXQgdXBkYXRlZCBvbiB0aGUgCmRpc3BsYXkuCmZiZGV2IGNvZGUgdGhhdCBkb2Vzbid0IHNldCAo c3RydWN0IGZiX29wcyAqKS0+ZmJfbW1hcCwgZ2V0cyB0aGlzIGZvciBmcmVlCmluIHRoZSBkZWZh dWx0IGZiX21tYXAgaW1wbGVtZW50YXRpb24gKGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYm1l bS5jKS4KSXQgY2FsbHMgZmJfcGdwcm90ZWN0KCkgYXQgdGhlIGVuZCB3aGljaCBpcyBhbiBhcmNo aXRlY3R1cmUgc3BlY2lmaWMKZnVuY3Rpb24gdGhhdCBvbiBtYW55IHBsYXRmb3JtcyB1c2VzIHBn cHJvdF93cml0ZWNvbWJpbmUoKSwgYnV0IG5vdCBvbiBhbGwuCkFuZCBsb29raW5nIGF0IHNvbWUg b2YgdGhlIGZiX21tYXAgaW1wbGVtZW50YXRpb25zLCBzb21lIG9mIHRoZW0gc2V0cwp2bV9wYWdl X3Byb3QgdG8gbm9jYWNoZSBmb3IgaW5zdGFuY2UsIHNvIEkgdGhpbmsgdGhlIHNhZmVzdCBiZXQg aXMgdG8gZG8KdGhpcyBoZXJlIGFuZCBub3QgaW4gdGhlIGZiZGV2IGNvcmUuIEFuZCB3ZSBjYW4n dCBjYWxsIGZiX3BncHJvdGVjdCgpIGZyb20KZmJfZGVmZXJyZWRfaW9fbW1hcCgpIGVpdGhlciBi ZWNhdXNlIHdlIGRvbid0IGhhdmUgYWNjZXNzIHRvIHRoZSBmaWxlCnBvaW50ZXIgdGhhdCBwb3dl cnBjIG5lZWRzLgpJIHRoaW5rIHRoZSBjYXNlIHlvdSByZWZlciB0byB3YXMgc29sdmVkIHdpdGgg dXNpbmcgZmJfcGdwcm90ZWN0KCkgZm9yCnRoZSBwbGF0Zm9ybSBpbiBxdWVzdGlvbiBhbmQgaXQg ZGlkbid0IGludm9sdmUgZGVmZXJyZWQgaW8uCgo+IC1EYW5pZWwKPgo+PiAJcmV0dXJuIDA7Cj4+ IH0KPj4KPj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5v cmc+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIHwgMyAr Ky0KPj4gICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAgICAgICAgICB8IDEgKwo+PiAgIDIg ZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJfZGVmaW8uYyBiL2RyaXZlcnMvdmlk ZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4+IGluZGV4IDU3NzIxYzcuLjc0YjViY2EgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4+ICsrKyBiL2Ry aXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4+IEBAIC0xNjQsNyArMTY0LDcgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCBhZGRyZXNzX3NwYWNlX29wZXJhdGlvbnMgZmJfZGVmZXJyZWRf aW9fYW9wcyA9IHsKPj4gICAJLnNldF9wYWdlX2RpcnR5ID0gZmJfZGVmZXJyZWRfaW9fc2V0X3Bh Z2VfZGlydHksCj4+ICAgfTsKPj4gICAKPj4gLXN0YXRpYyBpbnQgZmJfZGVmZXJyZWRfaW9fbW1h cChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpCj4+ICtp bnQgZmJfZGVmZXJyZWRfaW9fbW1hcChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgc3RydWN0IHZtX2Fy ZWFfc3RydWN0ICp2bWEpCj4+ICAgewo+PiAgIAl2bWEtPnZtX29wcyA9ICZmYl9kZWZlcnJlZF9p b192bV9vcHM7Cj4+ICAgCXZtYS0+dm1fZmxhZ3MgfD0gVk1fRE9OVEVYUEFORCB8IFZNX0RPTlRE VU1QOwo+PiBAQCAtMTczLDYgKzE3Myw3IEBAIHN0YXRpYyBpbnQgZmJfZGVmZXJyZWRfaW9fbW1h cChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpCj4+ICAg CXZtYS0+dm1fcHJpdmF0ZV9kYXRhID0gaW5mbzsKPj4gICAJcmV0dXJuIDA7Cj4+ICAgfQo+PiAr RVhQT1JUX1NZTUJPTChmYl9kZWZlcnJlZF9pb19tbWFwKTsKPj4gICAKPj4gICAvKiB3b3JrcXVl dWUgY2FsbGJhY2sgKi8KPj4gICBzdGF0aWMgdm9pZCBmYl9kZWZlcnJlZF9pb193b3JrKHN0cnVj dCB3b3JrX3N0cnVjdCAqd29yaykKPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZmIuaCBi L2luY2x1ZGUvbGludXgvZmIuaAo+PiBpbmRleCBkZmU4ODM1Li5hOTY0ZDA3IDEwMDY0NAo+PiAt LS0gYS9pbmNsdWRlL2xpbnV4L2ZiLmgKPj4gKysrIGIvaW5jbHVkZS9saW51eC9mYi5oCj4+IEBA IC02NzMsNiArNjczLDcgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fZmJfcGFkX2FsaWduZWRfYnVm ZmVyKHU4ICpkc3QsIHUzMiBkX3BpdGNoLAo+PiAgIH0KPj4gICAKPj4gICAvKiBkcml2ZXJzL3Zp ZGVvL2ZiX2RlZmlvLmMgKi8KPj4gK2ludCBmYl9kZWZlcnJlZF9pb19tbWFwKHN0cnVjdCBmYl9p bmZvICppbmZvLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSk7Cj4+ICAgZXh0ZXJuIHZvaWQg ZmJfZGVmZXJyZWRfaW9faW5pdChzdHJ1Y3QgZmJfaW5mbyAqaW5mbyk7Cj4+ICAgZXh0ZXJuIHZv aWQgZmJfZGVmZXJyZWRfaW9fb3BlbihzdHJ1Y3QgZmJfaW5mbyAqaW5mbywKPj4gICAJCQkJc3Ry dWN0IGlub2RlICppbm9kZSwKPj4gLS0gCj4+IDIuMi4yCj4+CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK