From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA49C04FF3 for ; Mon, 24 May 2021 16:06:35 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A15261132 for ; Mon, 24 May 2021 16:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A15261132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621872394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2kac1SOeXYjak1gpQETARd2XbJOOXOPHID5KSm5YSt4=; b=ZkFlICeadOKTxCp3AYlshVXtbtoNhq5B8rIFZ0q6BCfm8p9yWyms4+hxKZ14KjCKAgG0Jv nbj0UtaGKituKGXFMrec3TnYGjJ8+aeaV+BngV2kc+7aats7/xncwfEAoDubJ4g0qIQnR6 wGeJ/nl1JlTNZpmliV0v2c8tjlIfLx0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-NBXz0ci3MOOyKotKl4MLXg-1; Mon, 24 May 2021 12:06:32 -0400 X-MC-Unique: NBXz0ci3MOOyKotKl4MLXg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 945818049CB; Mon, 24 May 2021 16:06:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A269100238C; Mon, 24 May 2021 16:06:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CF48355342; Mon, 24 May 2021 16:06:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14OG6R8s000337 for ; Mon, 24 May 2021 12:06:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2D6BE10023AB; Mon, 24 May 2021 16:06:27 +0000 (UTC) Received: from x2.localnet (ovpn-116-120.rdu2.redhat.com [10.10.116.120]) by smtp.corp.redhat.com (Postfix) with ESMTP id A884D100238C; Mon, 24 May 2021 16:06:21 +0000 (UTC) From: Steve Grubb To: linux-audit@redhat.com, John Johansen , Casey Schaufler Subject: Re: [PATCH v26 22/25] Audit: Add new record for multiple process LSM attributes Date: Mon, 24 May 2021 12:06:19 -0400 Message-ID: <5718096.lOV4Wx5bFT@x2> Organization: Red Hat In-Reply-To: <01af5c96-9e10-80f2-970d-a98cf087f82d@schaufler-ca.com> References: <20210513200807.15910-1-casey@schaufler-ca.com> <2582635.mvXUDI8C0e@x2> <01af5c96-9e10-80f2-970d-a98cf087f82d@schaufler-ca.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello Casey, On Monday, May 24, 2021 11:53:30 AM EDT Casey Schaufler wrote: > On 5/22/2021 7:00 PM, Steve Grubb wrote: > > On Friday, May 21, 2021 6:05:41 PM EDT Casey Schaufler wrote: > >>>> The record is produced only in cases where there is more than one > >>>> security module with a process "context". > >>>> In cases where this record is produced the subj= fields of > >>>> other records in the audit event will be set to "subj=?". > >>>> > >>>> An example of the MAC_TASK_CONTEXTS (1420) record is: > >>>> > >>>> type=UNKNOWN[1420] > >>>> msg=audit(1600880931.832:113) > >>>> subj_apparmor==unconfined > >>> > >>> It should be just a single "=" in the line above. > >> > >> AppArmor provides the 2nd "=" as part of the subject context. > >> What's here is correct. I won't argue that it won't case confusion > >> or worse. > > > > We have a specification for a very long time: > > > > https://github.com/linux-audit/audit-documentation/wiki/SPEC-Writing-Good > > -Events > > > > Everyone has to obey rules or no tools work. > > Right. Would quoting the value subj_apparmor="=unconfined" suffice? Yes, if you really need that '=' as part of the value. I'd try to do away with it entirely if possible. Generally '==' is used to convey "equal to". Where '=' means "is assigned". I'd argue that they are interchangable in meaning and can simply be converted to the log's expected format. > I think that's what the rulebook says, but I like to be sure. :-) -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit