From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 21 Apr 2016 11:03:57 -0600
Subject: [U-Boot] [RESEND PATCH V3 1/6] dm: gpio: add a default gpio
 xlate routine
In-Reply-To: <1461166659-28276-2-git-send-email-eric@nelint.com>
References: <CAPnjgZ2jZ7opVw_5Hy2D2h=r4apJ-6jhJWWZKToNb3f0fiMfqQ@mail.gmail.com>
 <1461166659-28276-1-git-send-email-eric@nelint.com>
 <1461166659-28276-2-git-send-email-eric@nelint.com>
Message-ID: <571907FD.7060005@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/20/2016 09:37 AM, Eric Nelson wrote:
> Many drivers use a common form of offset + flags for device
> tree nodes. e.g.:
> 	<&gpio1 2 GPIO_ACTIVE_LOW>
>
> This patch adds a common implementation of this type of parsing
> and calls it when a gpio driver doesn't supply its' own xlate
> routine.
>
> This will allow removal of the driver-specific versions in a
> handful of drivers and simplify the addition of new drivers.

> diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c

> +int gpio_xlate_offs_flags(struct udevice *dev,
> +					 struct gpio_desc *desc,
> +					 struct fdtdec_phandle_args *args)
> +{
> +	if (args->args_count < 1)
> +		return -EINVAL;
> +
> +	desc->offset = args->args[0];
> +
> +        if (args->args_count < 2)
> +		return 0;

Nit: There's an indentation inconsistency there.

Aside from that, the series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>