From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atJm8-0008HG-Qb for qemu-devel@nongnu.org; Thu, 21 Apr 2016 14:56:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atJm5-0001I8-Io for qemu-devel@nongnu.org; Thu, 21 Apr 2016 14:56:28 -0400 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:35010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atJm4-0001I4-W3 for qemu-devel@nongnu.org; Thu, 21 Apr 2016 14:56:25 -0400 Received: by mail-lb0-x22e.google.com with SMTP id os9so32097863lbb.2 for ; Thu, 21 Apr 2016 11:56:24 -0700 (PDT) References: <1460044433-19282-1-git-send-email-sergey.fedorov@linaro.org> <1460044433-19282-3-git-send-email-sergey.fedorov@linaro.org> <20160418165116.4a27b947.cornelia.huck@de.ibm.com> <20160418173409.44564649.cornelia.huck@de.ibm.com> <5715019C.60203@gmail.com> <57190FB1.2070001@gmail.com> <87shyeua0x.fsf@linaro.org> From: Sergey Fedorov Message-ID: <57192255.7000305@gmail.com> Date: Thu, 21 Apr 2016 21:56:21 +0300 MIME-Version: 1.0 In-Reply-To: <87shyeua0x.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: Cornelia Huck , Sergey Fedorov , qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Christian Borntraeger , Alexander Graf On 21/04/16 20:49, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 18/04/16 18:47, Sergey Fedorov wrote: >>> On 18/04/16 18:34, Cornelia Huck wrote: >>>> On Mon, 18 Apr 2016 16:51:16 +0200 >>>> Cornelia Huck wrote: >>>> >>>>> On Thu, 7 Apr 2016 18:53:44 +0300 >>>>> Sergey Fedorov wrote: >>>>> >>>>>> From: Sergey Fedorov >>>>>> >>>>>> Signed-off-by: Sergey Fedorov >>>>>> Signed-off-by: Sergey Fedorov >>>>>> --- >>>>>> pc-bios/s390-ccw/Makefile | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile >>>>>> index 4208cb429593..5ce6d4ccbaf5 100644 >>>>>> --- a/pc-bios/s390-ccw/Makefile >>>>>> +++ b/pc-bios/s390-ccw/Makefile >>>>>> @@ -20,7 +20,7 @@ s390-ccw.elf: $(OBJECTS) >>>>>> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS)," Building $(TARGET_DIR)$@") >>>>>> >>>>>> s390-ccw.img: s390-ccw.elf >>>>>> - $(call quiet-command,strip --strip-unneeded $< -o $@," Stripping $(TARGET_DIR)$@") >>>>>> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@," Stripping $(TARGET_DIR)$@") >>>>>> >>>>>> $(OBJECTS): Makefile >>>>>> >>>>> Thanks, applied to s390-next. >>>> Uhm, scratch that. >>>> >>>> This fails to build with --disable-strip, as $STRIP is unset in that >>>> case: >>>> >>>> Building s390-ccw/s390-ccw.elf >>>> Stripping s390-ccw/s390-ccw.img >>>> /bin/sh: --strip-unneeded: command not found >>>> make[1]: *** [s390-ccw.img] Error 127 >>>> >>>> >>>> The catch is that we always want to strip that binary. Care to send a >>>> patch that deals with that? >>>> >>> I see the problem. I don't promise to fix it soon, but I could try >>> dealing with this as I have time. I don't mind if someone else can just >>> fix it with their own patch :) >> It's not straightforward to fix. We need to detect a correct >> cross-prefix for strip. There is something in roms/Makefile: >> >> # >> # cross compiler auto detection >> # >> path := $(subst :, ,$(PATH)) >> system := $(shell uname -s | tr "A-Z" "a-z") >> >> # first find cross binutils in path >> find-cross-ld = $(firstword $(wildcard $(patsubst >> %,%/$(1)-*$(system)*-ld,$(path)))) >> # then check we have cross gcc too >> find-cross-gcc = $(firstword $(wildcard $(patsubst %ld,%gcc,$(call >> find-cross-ld,$(1))))) >> # finally strip off path + toolname so we get the prefix >> find-cross-prefix = $(subst gcc,,$(notdir $(call find-cross-gcc,$(1)))) >> >> powerpc64_cross_prefix := $(call find-cross-prefix,powerpc64) >> powerpc_cross_prefix := $(call find-cross-prefix,powerpc) >> x86_64_cross_prefix := $(call find-cross-prefix,x86_64) > Ohh that's cool. I wonder if it could be used to solve the tcg/tests > problem? Which problem? :) Kind regards, Sergey