From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH RFT V2 3/3] iio: mxs-lradc: implement suspend/resume support Date: Thu, 21 Apr 2016 22:45:53 +0200 Message-ID: <57193C01.20709@denx.de> References: <1461269478-449-1-git-send-email-stefan.wahren@i2se.com> <1461269478-449-4-git-send-email-stefan.wahren@i2se.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1461269478-449-4-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren , Jonathan Cameron , Dmitry Torokhov , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: Fabio Estevam , Juergen Borleis , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-input@vger.kernel.org On 04/21/2016 10:11 PM, Stefan Wahren wrote: > This patch implements suspend/resume support for mxs-lradc. > It's possible to use the touchscreen as wakeup source. > > Signed-off-by: Stefan Wahren > --- > drivers/iio/adc/mxs-lradc.c | 61 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index cfc558f..6bd387f 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1745,10 +1746,70 @@ static int mxs_lradc_remove(struct platform_device *pdev) > return 0; > } > > +static int __maybe_unused mxs_lradc_suspend(struct device *dev) > +{ > + struct iio_dev *iio = dev_get_drvdata(dev); > + struct mxs_lradc *lradc = iio_priv(iio); > + struct input_dev *input = lradc->ts_input; Can lradc->ts_input contain some non-valid pointer ? You should make sure it's either inited to NULL or valid pointer, which I'm not sure you do. > + int ret = 0; > + > + if (input) { > + mutex_lock(&input->mutex); > + > + /* Enable touchscreen wakeup irq */ > + if (input->users && device_may_wakeup(dev)) > + ret = enable_irq_wake(lradc->irq[0]); > + else > + mxs_lradc_disable_ts(lradc); > + > + mutex_unlock(&input->mutex); > + } > + > + if (ret) > + return ret; > + > + mxs_lradc_hw_stop(lradc); > + > + clk_disable_unprepare(lradc->clk); > + > + return ret; > +} > + > +static int __maybe_unused mxs_lradc_resume(struct device *dev) > +{ > + struct iio_dev *iio = dev_get_drvdata(dev); > + struct mxs_lradc *lradc = iio_priv(iio); > + struct input_dev *input = lradc->ts_input; > + int ret; > + > + ret = clk_prepare_enable(lradc->clk); > + if (ret) > + return ret; > + > + mxs_lradc_hw_init(lradc); > + > + if (input) { > + mutex_lock(&input->mutex); > + > + /* Disable touchscreen wakeup irq */ > + if (input->users && device_may_wakeup(dev)) > + ret = disable_irq_wake(lradc->irq[0]); > + else > + mxs_lradc_enable_touch_detection(lradc); > + > + mutex_unlock(&input->mutex); > + } > + > + return ret; > +} > + > +static SIMPLE_DEV_PM_OPS(mxs_lradc_pm_ops, mxs_lradc_suspend, mxs_lradc_resume); > + > static struct platform_driver mxs_lradc_driver = { > .driver = { > .name = DRIVER_NAME, > .of_match_table = mxs_lradc_dt_ids, > + .pm = &mxs_lradc_pm_ops, > }, > .probe = mxs_lradc_probe, > .remove = mxs_lradc_remove, > Looks OK otherwise: Reviewed-by: Marek Vasut -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net ([212.18.0.10]:38475 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbcDUVEw (ORCPT ); Thu, 21 Apr 2016 17:04:52 -0400 Message-ID: <57193C01.20709@denx.de> Date: Thu, 21 Apr 2016 22:45:53 +0200 From: Marek Vasut MIME-Version: 1.0 To: Stefan Wahren , Jonathan Cameron , Dmitry Torokhov , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler CC: Fabio Estevam , Juergen Borleis , linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFT V2 3/3] iio: mxs-lradc: implement suspend/resume support References: <1461269478-449-1-git-send-email-stefan.wahren@i2se.com> <1461269478-449-4-git-send-email-stefan.wahren@i2se.com> In-Reply-To: <1461269478-449-4-git-send-email-stefan.wahren@i2se.com> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 04/21/2016 10:11 PM, Stefan Wahren wrote: > This patch implements suspend/resume support for mxs-lradc. > It's possible to use the touchscreen as wakeup source. > > Signed-off-by: Stefan Wahren > --- > drivers/iio/adc/mxs-lradc.c | 61 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index cfc558f..6bd387f 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1745,10 +1746,70 @@ static int mxs_lradc_remove(struct platform_device *pdev) > return 0; > } > > +static int __maybe_unused mxs_lradc_suspend(struct device *dev) > +{ > + struct iio_dev *iio = dev_get_drvdata(dev); > + struct mxs_lradc *lradc = iio_priv(iio); > + struct input_dev *input = lradc->ts_input; Can lradc->ts_input contain some non-valid pointer ? You should make sure it's either inited to NULL or valid pointer, which I'm not sure you do. > + int ret = 0; > + > + if (input) { > + mutex_lock(&input->mutex); > + > + /* Enable touchscreen wakeup irq */ > + if (input->users && device_may_wakeup(dev)) > + ret = enable_irq_wake(lradc->irq[0]); > + else > + mxs_lradc_disable_ts(lradc); > + > + mutex_unlock(&input->mutex); > + } > + > + if (ret) > + return ret; > + > + mxs_lradc_hw_stop(lradc); > + > + clk_disable_unprepare(lradc->clk); > + > + return ret; > +} > + > +static int __maybe_unused mxs_lradc_resume(struct device *dev) > +{ > + struct iio_dev *iio = dev_get_drvdata(dev); > + struct mxs_lradc *lradc = iio_priv(iio); > + struct input_dev *input = lradc->ts_input; > + int ret; > + > + ret = clk_prepare_enable(lradc->clk); > + if (ret) > + return ret; > + > + mxs_lradc_hw_init(lradc); > + > + if (input) { > + mutex_lock(&input->mutex); > + > + /* Disable touchscreen wakeup irq */ > + if (input->users && device_may_wakeup(dev)) > + ret = disable_irq_wake(lradc->irq[0]); > + else > + mxs_lradc_enable_touch_detection(lradc); > + > + mutex_unlock(&input->mutex); > + } > + > + return ret; > +} > + > +static SIMPLE_DEV_PM_OPS(mxs_lradc_pm_ops, mxs_lradc_suspend, mxs_lradc_resume); > + > static struct platform_driver mxs_lradc_driver = { > .driver = { > .name = DRIVER_NAME, > .of_match_table = mxs_lradc_dt_ids, > + .pm = &mxs_lradc_pm_ops, > }, > .probe = mxs_lradc_probe, > .remove = mxs_lradc_remove, > Looks OK otherwise: Reviewed-by: Marek Vasut -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Thu, 21 Apr 2016 22:45:53 +0200 Subject: [PATCH RFT V2 3/3] iio: mxs-lradc: implement suspend/resume support In-Reply-To: <1461269478-449-4-git-send-email-stefan.wahren@i2se.com> References: <1461269478-449-1-git-send-email-stefan.wahren@i2se.com> <1461269478-449-4-git-send-email-stefan.wahren@i2se.com> Message-ID: <57193C01.20709@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/21/2016 10:11 PM, Stefan Wahren wrote: > This patch implements suspend/resume support for mxs-lradc. > It's possible to use the touchscreen as wakeup source. > > Signed-off-by: Stefan Wahren > --- > drivers/iio/adc/mxs-lradc.c | 61 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index cfc558f..6bd387f 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1745,10 +1746,70 @@ static int mxs_lradc_remove(struct platform_device *pdev) > return 0; > } > > +static int __maybe_unused mxs_lradc_suspend(struct device *dev) > +{ > + struct iio_dev *iio = dev_get_drvdata(dev); > + struct mxs_lradc *lradc = iio_priv(iio); > + struct input_dev *input = lradc->ts_input; Can lradc->ts_input contain some non-valid pointer ? You should make sure it's either inited to NULL or valid pointer, which I'm not sure you do. > + int ret = 0; > + > + if (input) { > + mutex_lock(&input->mutex); > + > + /* Enable touchscreen wakeup irq */ > + if (input->users && device_may_wakeup(dev)) > + ret = enable_irq_wake(lradc->irq[0]); > + else > + mxs_lradc_disable_ts(lradc); > + > + mutex_unlock(&input->mutex); > + } > + > + if (ret) > + return ret; > + > + mxs_lradc_hw_stop(lradc); > + > + clk_disable_unprepare(lradc->clk); > + > + return ret; > +} > + > +static int __maybe_unused mxs_lradc_resume(struct device *dev) > +{ > + struct iio_dev *iio = dev_get_drvdata(dev); > + struct mxs_lradc *lradc = iio_priv(iio); > + struct input_dev *input = lradc->ts_input; > + int ret; > + > + ret = clk_prepare_enable(lradc->clk); > + if (ret) > + return ret; > + > + mxs_lradc_hw_init(lradc); > + > + if (input) { > + mutex_lock(&input->mutex); > + > + /* Disable touchscreen wakeup irq */ > + if (input->users && device_may_wakeup(dev)) > + ret = disable_irq_wake(lradc->irq[0]); > + else > + mxs_lradc_enable_touch_detection(lradc); > + > + mutex_unlock(&input->mutex); > + } > + > + return ret; > +} > + > +static SIMPLE_DEV_PM_OPS(mxs_lradc_pm_ops, mxs_lradc_suspend, mxs_lradc_resume); > + > static struct platform_driver mxs_lradc_driver = { > .driver = { > .name = DRIVER_NAME, > .of_match_table = mxs_lradc_dt_ids, > + .pm = &mxs_lradc_pm_ops, > }, > .probe = mxs_lradc_probe, > .remove = mxs_lradc_remove, > Looks OK otherwise: Reviewed-by: Marek Vasut -- Best regards, Marek Vasut