From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Stephen Hemminger <shemming@brocade.com>
Cc: netdev@vger.kernel.org, phil@nwl.cc
Subject: Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action
Date: Thu, 21 Apr 2016 17:27:39 -0400 [thread overview]
Message-ID: <571945CB.4080801@mojatatu.com> (raw)
In-Reply-To: <20160313232651.354f6087@xeon-e3>
Sorry dropped the ball on this..
On 16-03-14 02:26 AM, Stephen Hemminger wrote:
> On Wed, 9 Mar 2016 07:04:36 -0500
> Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>
> This code has diverged way from the general rule that ip utilities display
> format should match the command format. For example the properties shown
> on "ip route show" match those of "ip route add".
>
Valid point (and thanks for catching this since i tend to be the biggest
whiner on this topic ;-> I will make the changes - doesnt seem to be
far off already.
Note: in ife case it may not always symetric because there are optional
fields which may be absent in a request to the kernel but present in
a response.
> Also over the last several years, the code in iproute2 has switched from casting
> RTA_DATA() everywhere to a cleaner interface rte_getattr_u32() more like what
> is used in mnl library.
>
Will convert where it makes sense..
> The code has also gotten deeply intended creating lots of lines that are too long.
>
Is this you or the script saying the above? How is the conclusion that
we have deep indentation come about?
I checked there are some code lines that are > 80 characters because
it doesnt make sense to break them down.
> WARNING: 'doesnt' may be misspelled - perhaps 'doesn't'?
> #21:
What, checking my spelling now? ;->
I am on the internets dude!
> then provide a default so the user doesnt have to specify it.
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #25:
> "Distributing Linux Traffic Control Classifier-Action Subsystem"
>
75 character? ;-> What happened to 80?
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #143:
> new file mode 100644
>
> ERROR: "foo * bar" should be "foo *bar"
Will fix above and rest shortly.
Also, promise to send man page later. Ive coerced someone to do it;->
cheers,
jamal
next prev parent reply other threads:[~2016-04-21 21:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 12:04 [net-next PATCH iproute2 v2 0/1] tc ife action Jamal Hadi Salim
2016-03-09 12:04 ` [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action Jamal Hadi Salim
2016-03-09 13:12 ` Phil Sutter
2016-03-10 12:42 ` Jamal Hadi Salim
2016-03-10 13:12 ` Phil Sutter
2016-03-14 6:26 ` Stephen Hemminger
2016-04-21 21:27 ` Jamal Hadi Salim [this message]
[not found] ` <e6070b054b0748f48991187bb4ccfccd@HQ1WP-EXMB11.corp.brocade.com>
2016-04-21 21:36 ` Stephen Hemminger
2016-04-21 21:41 ` Jamal Hadi Salim
2016-04-21 22:09 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571945CB.4080801@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.