Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9

["piotr.lewicki" <piotr.lewicki@elfin.de>]

Hello.
I'm new here and I didn't know how to prepare patch correctly- I just 
used instructions from meta-raspberrypi README.

I can resend it if you want. Especially now when the patch is not 
necessary anymore, because Andrei Gherzan has merged latest revision of 
omxplayer to master (patch with explicit linking vchostif lib was taken 
from there).

Please provide me with instruction on how to create a patch properly.

Thank you,
Piotr Lewicki

On 22.04.2016 05:01, Gary Thomas wrote:
> On 2016-04-22 02:44, Mark Hatle wrote:
>> On 4/21/16 6:31 PM, Khem Raj wrote:
>>> resend this patch to OE-Core mailing list. and also add
>>> Upstream-Status: to patch
>>
>> I don't see a "why" anywhere.
>>
>> Something wrong with libav, something better with ffmpeg, etc?
>>
>
> libav was replaced in OE-core by ffmpeg
>
>>
>>>
>>> On Wed, Apr 20, 2016 at 6:11 AM, piotr.lewicki 
>>> <piotr.lewicki@elfin.de> wrote:
>>>> ---
>>>> .../omxplayer/explicitly_link_with_vchostif_library.patch | 13 
>>>> +++++++++++++
>>>> recipes-multimedia/omxplayer/omxplayer_git.bb |  5 +++--
>>>>   2 files changed, 16 insertions(+), 2 deletions(-)
>>>>   create mode 100644 
>>>> recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>>
>>>> diff --git 
>>>> a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch 
>>>> b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch 
>>>>
>>>> new file mode 100644
>>>> index 0000000..642f63a
>>>> --- /dev/null
>>>> +++ 
>>>> b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>> @@ -0,0 +1,13 @@
>>>> +diff --git a/Makefile b/Makefile
>>>> +index 80b63b1..bcfadfb 100644
>>>> +--- a/Makefile
>>>> ++++ b/Makefile
>>>> +@@ -51,7 +51,7 @@ version:
>>>> +       bash gen_version.sh > version.h
>>>> +
>>>> + omxplayer.bin: version $(OBJS)
>>>> +-      $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm 
>>>> -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat 
>>>> -lswscale -lswresample -lpcre
>>>> ++      $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm 
>>>> -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec 
>>>> -lavformat -lswscale -lswresample -lpcre
>>>> +       $(STRIP) omxplayer.bin
>>>> +
>>>> + help.h: README.md Makefile
>>>> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb 
>>>> b/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> index c8251fe..c2b1342 100644
>>>> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> @@ -7,8 +7,8 @@ SECTION = "console/utils"
>>>>   LICENSE = "GPLv2"
>>>>   LIC_FILES_CHKSUM = 
>>>> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>>>
>>>> -DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl 
>>>> samba libssh"
>>>> -PR = "r4"
>>>> +DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl 
>>>> samba libssh"
>>>> +PR = "r5"
>>>>
>>>>   SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
>>>>   SRC_URI = 
>>>> "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master 
>>>> \
>>>> @@ -19,6 +19,7 @@ SRC_URI = 
>>>> "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
>>>>              file://fix-tar-command-with-DIST.patch \
>>>>              file://use-native-pkg-config.patch \
>>>> file://don-t-preserve-file-attributes-when-cp.patch \
>>>> + file://explicitly_link_with_vchostif_library.patch \
>>>>              "
>>>>   S = "${WORKDIR}/git"
>>>>
>>>> -- 
>>>> 2.5.0
>>>>
>>>> -- 
>>>> _______________________________________________
>>>> yocto mailing list
>>>> yocto@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/yocto
>>
>
>