From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932587AbcDYNci (ORCPT ); Mon, 25 Apr 2016 09:32:38 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:53636 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932379AbcDYNcg (ORCPT ); Mon, 25 Apr 2016 09:32:36 -0400 Subject: Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi To: David Lechner References: <1460826020-1256-1-git-send-email-david@lechnology.com> <1460826020-1256-4-git-send-email-david@lechnology.com> CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kevin Hilman , , , From: Sekhar Nori Message-ID: <571E1C13.9050204@ti.com> Date: Mon, 25 Apr 2016 19:00:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460826020-1256-4-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On Saturday 16 April 2016 10:30 PM, David Lechner wrote: > All other devices are disabled by default and not all boards will use > these devices, so these should be disabled too.. > > da850-evm.dtb already had status = "okay" for these devices. > da850-enbw-cmc.dts did not, so they were added. > > Signed-off-by: David Lechner > Tested-by: Kevin Hilman I applied this and other patches in this series. One nit-pick though. The commit description should be independently readable and not only as continuation of the headline. Even if this means repeating portion of the headline. I fixed this for most of the patches in this series. For example, for this patch, I have: ARM: dts: da850: disable mdio and eth0 in da850.dtsi Disable mdio and eth0 in da850.dtsi file. All other devices are disabled by default and not all boards will use these devices, so these should be disabled too. da850-evm.dtb already had status = "okay" for these devices. da850-enbw-cmc.dts did not, so they were added. Signed-off-by: David Lechner Tested-by: Kevin Hilman [nsekhar@ti.com: commit description updates] Signed-off-by: Sekhar Nori Its a minor change and I wont reply to all the patches with the changes I made. But I pushed the updated v4.7/dt branch in my tree. Do take a look at the commit description there. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi Date: Mon, 25 Apr 2016 19:00:59 +0530 Message-ID: <571E1C13.9050204@ti.com> References: <1460826020-1256-1-git-send-email-david@lechnology.com> <1460826020-1256-4-git-send-email-david@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1460826020-1256-4-git-send-email-david@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org To: David Lechner Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi David, On Saturday 16 April 2016 10:30 PM, David Lechner wrote: > All other devices are disabled by default and not all boards will use > these devices, so these should be disabled too.. > > da850-evm.dtb already had status = "okay" for these devices. > da850-enbw-cmc.dts did not, so they were added. > > Signed-off-by: David Lechner > Tested-by: Kevin Hilman I applied this and other patches in this series. One nit-pick though. The commit description should be independently readable and not only as continuation of the headline. Even if this means repeating portion of the headline. I fixed this for most of the patches in this series. For example, for this patch, I have: ARM: dts: da850: disable mdio and eth0 in da850.dtsi Disable mdio and eth0 in da850.dtsi file. All other devices are disabled by default and not all boards will use these devices, so these should be disabled too. da850-evm.dtb already had status = "okay" for these devices. da850-enbw-cmc.dts did not, so they were added. Signed-off-by: David Lechner Tested-by: Kevin Hilman [nsekhar@ti.com: commit description updates] Signed-off-by: Sekhar Nori Its a minor change and I wont reply to all the patches with the changes I made. But I pushed the updated v4.7/dt branch in my tree. Do take a look at the commit description there. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Mon, 25 Apr 2016 19:00:59 +0530 Subject: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi In-Reply-To: <1460826020-1256-4-git-send-email-david@lechnology.com> References: <1460826020-1256-1-git-send-email-david@lechnology.com> <1460826020-1256-4-git-send-email-david@lechnology.com> Message-ID: <571E1C13.9050204@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi David, On Saturday 16 April 2016 10:30 PM, David Lechner wrote: > All other devices are disabled by default and not all boards will use > these devices, so these should be disabled too.. > > da850-evm.dtb already had status = "okay" for these devices. > da850-enbw-cmc.dts did not, so they were added. > > Signed-off-by: David Lechner > Tested-by: Kevin Hilman I applied this and other patches in this series. One nit-pick though. The commit description should be independently readable and not only as continuation of the headline. Even if this means repeating portion of the headline. I fixed this for most of the patches in this series. For example, for this patch, I have: ARM: dts: da850: disable mdio and eth0 in da850.dtsi Disable mdio and eth0 in da850.dtsi file. All other devices are disabled by default and not all boards will use these devices, so these should be disabled too. da850-evm.dtb already had status = "okay" for these devices. da850-enbw-cmc.dts did not, so they were added. Signed-off-by: David Lechner Tested-by: Kevin Hilman [nsekhar at ti.com: commit description updates] Signed-off-by: Sekhar Nori Its a minor change and I wont reply to all the patches with the changes I made. But I pushed the updated v4.7/dt branch in my tree. Do take a look at the commit description there. Thanks, Sekhar