From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbcDZIO4 (ORCPT ); Tue, 26 Apr 2016 04:14:56 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:33466 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbcDZIOw (ORCPT ); Tue, 26 Apr 2016 04:14:52 -0400 Subject: Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev To: Felipe Balbi , Greg Kroah-Hartman References: <1461612094-30939-1-git-send-email-grygorii.strashko@ti.com> <87d1pcrj0t.fsf@intel.com> CC: , , , Sekhar Nori , David Fisher , Catalin Marinas , "Thang Q. Nguyen" , Yoshihiro Shimoda From: Grygorii Strashko Message-ID: <571F2357.9080509@ti.com> Date: Tue, 26 Apr 2016 11:14:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87d1pcrj0t.fsf@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2016 09:17 AM, Felipe Balbi wrote: > > Hi, > > Grygorii Strashko writes: >> Now not all DMA paremters configured properly for "xhci-hcd" platform >> device which is created manually. For example: dma_pfn_offset, dam_ops >> and iommu configuration will not corresponds "dwc3" devices >> configuration. As result, this will cause problems like wrong DMA >> addresses translation on platforms with LPAE enabled like Keystone 2. >> >> When platform is using DT boot mode the DMA configuration will be >> parsed and applied from DT, so, to fix this issue, reuse >> of_dma_configure() API and retrieve DMA configuartion for "xhci-hcd" >> from DWC3 device node. > > patch is incomplete. You left out non-DT users which might suffer from > the same problem. > Honestly, I don't know how to fix it gracefully for non-DT case. I can update commit message to mention that this is fix for DT case only. -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Tue, 26 Apr 2016 11:14:15 +0300 Subject: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev In-Reply-To: <87d1pcrj0t.fsf@intel.com> References: <1461612094-30939-1-git-send-email-grygorii.strashko@ti.com> <87d1pcrj0t.fsf@intel.com> Message-ID: <571F2357.9080509@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/26/2016 09:17 AM, Felipe Balbi wrote: > > Hi, > > Grygorii Strashko writes: >> Now not all DMA paremters configured properly for "xhci-hcd" platform >> device which is created manually. For example: dma_pfn_offset, dam_ops >> and iommu configuration will not corresponds "dwc3" devices >> configuration. As result, this will cause problems like wrong DMA >> addresses translation on platforms with LPAE enabled like Keystone 2. >> >> When platform is using DT boot mode the DMA configuration will be >> parsed and applied from DT, so, to fix this issue, reuse >> of_dma_configure() API and retrieve DMA configuartion for "xhci-hcd" >> from DWC3 device node. > > patch is incomplete. You left out non-DT users which might suffer from > the same problem. > Honestly, I don't know how to fix it gracefully for non-DT case. I can update commit message to mention that this is fix for DT case only. -- regards, -grygorii