From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFC24C433EF for ; Tue, 11 Jan 2022 23:04:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75E7882F89; Wed, 12 Jan 2022 00:04:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="hfKgXJjk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7ED0282F89; Wed, 12 Jan 2022 00:04:19 +0100 (CET) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6DD1283022 for ; Wed, 12 Jan 2022 00:04:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20220111230411epoutp045154f2211728f3a1b1b78ad75ebd7383~JWcdI_0r90158001580epoutp04U for ; Tue, 11 Jan 2022 23:04:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20220111230411epoutp045154f2211728f3a1b1b78ad75ebd7383~JWcdI_0r90158001580epoutp04U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1641942251; bh=xGZROq9e9mNuDtYnUsyRtORTeK2iDQOcnWz7xB/CfTo=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=hfKgXJjkML68dCtP1RjCV/DYxl0JrcFp5abjaLZjTmkNA4ma8/VU+gG+pJOoCTXVg Q9x1AAVAbpDBL4wFcqLIuJN+kbAjUOYMAdm5kdeEnuHFiyS4KyQXuF+FsT01Vh8mmS o4hb7FSXKCBA7DxgKnyvk+YNVScnDgFT6ZU51xTA= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20220111230411epcas1p336504e654e8c4308ca87006206e974c2~JWccw7cmh2621326213epcas1p3S; Tue, 11 Jan 2022 23:04:11 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.38.232]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4JYR8R2tbLz4x9Q7; Tue, 11 Jan 2022 23:04:07 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 4C.09.21932.2BC0ED16; Wed, 12 Jan 2022 08:03:15 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220111230406epcas1p31d22a8f83fc128557ff2f327672c458d~JWcYj3rbI3168531685epcas1p3F; Tue, 11 Jan 2022 23:04:06 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220111230406epsmtrp2c84c688f45b1a70255c8440c185b19f5~JWcYjunia0563705637epsmtrp2p; Tue, 11 Jan 2022 23:04:06 +0000 (GMT) X-AuditID: b6c32a38-929ff700000255ac-0c-61de0cb2d70a Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id A6.A1.08738.6EC0ED16; Wed, 12 Jan 2022 08:04:06 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220111230406epsmtip129412227435a7e3c9c57a5a4e5ece594~JWcYT1Tm90732407324epsmtip1Z; Tue, 11 Jan 2022 23:04:06 +0000 (GMT) Subject: Re: [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode To: "gtXfined H." Cc: peng.fan@nxp.com, ley.foon.tan@intel.com, u-boot@lists.denx.de From: Jaehoon Chung Message-ID: <571db934-3fe0-ff40-f197-63176a3f726e@samsung.com> Date: Wed, 12 Jan 2022 08:04:49 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplk+LIzCtJLcpLzFFi42LZdljTQHczz71Eg9fNzBYPXuxksbi/u5HR 4seqL6wWb/d2sjuweOycdZfdY/Gel0weZ+/sYPTY+G4HUwBLVLZNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr6dTVF+aUmq QkZ+cYmtUmpBSk6BaYFecWJucWleul5eaomVoYGBkSlQYUJ2xvFzzxkLJohWNC/4ydjA2Mbf xcjJISFgIjFtwR/GLkYuDiGBHYwSXf0f2EESQgKfGCUap+hDJD4zSiz784epi5EDrGP541qI +C5GidaNL9ghnPeMEk/OTmAG6RYWcJbYs78ZbJKIgIpE38yfLCA2s4CTxJsfn1hBbDYBHYnt 344zgdi8AnYSX84dB6thEVCVaLk1DaxXVCBS4v6P5ewQNYISJ2c+AavhFAiUuH1iBhPETHGJ W0/mQ9nyEtvfzmEGOUhC4CO7xKHmq+wQf7pInPl/kQXCFpZ4dXwLVFxK4vO7vWwQDcsYJe7c /gvlrGeUOLB9CRtElbHE/qWTwf5nFtCUWL9LHyKsKLHz91xGiM18Eu++9rBCgohXoqNNCKJE ReLS65dMMLvuPvnPCmF7SMw9e5V1AqPiLCS/zULyzywk/8xCWLyAkWUVo1hqQXFuemqxYYEJ PLaT83M3MYLTo5bFDsa5bz/oHWJk4mA8xCjBwawkwlsWczdRiDclsbIqtSg/vqg0J7X4EKMp MLQnMkuJJucDE3ReSbyhiaWBiZmRsYmFoZmhkjhv79TTiUIC6YklqdmpqQWpRTB9TBycUg1M Cyc9uvrmwqSnQVYzpA8euXPn6ySVjfxWxxcfFedKTYphZVZSXsfX2ebwey/bzE12a61uC6dX ek/JnWNWc6Lygsnn8mlLD3L2Lu6uq4gOtwhZV/KRV1fKfurRkOCDnExTs2+o7Js3x2Z3o+ur xSunHhbwr/DSfZEVZpWXcnaeiqaO1YG/nZf+uVWHz3rXu+dP6sbbbQvs45rKiyL2qdxSUzda OeFz4dJPj5wNr/x/cOPxrx13O3d8Yzr0US+D8THr730uebHZmYdOTFfPVZxzXUlEo+tXY+Kt qUssuaLKHr50/SMRbTHz/cagGasdfQ3Dis+FZbnHGB5nOd162dCjcNYsl8Pq4m+WHc75/pTh ghJLcUaioRZzUXEiAKs3+wQYBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsWy7bCSnO4znnuJBnd2q1g8eLGTxeL+7kZG ix+rvrBavN3bye7A4rFz1l12j8V7XjJ5nL2zg9Fj47sdTAEsUVw2Kak5mWWpRfp2CVwZx889 ZyyYIFrRvOAnYwNjG38XIweHhICJxPLHtV2MXBxCAjsYJWa9uMzSxcgJFJeS+Px0KhtEjbDE 4cPFEDVvGSU6r6xmAqkRFnCW2LO/mR3EFhFQkeib+ROsl1nASeLNj0+sEA2tTBJT3m1kBkmw CehIbP92HKyZV8BO4su542ANLAKqEi23poENEhWIlFh3fBk7RI2gxMmZT8BqOAUCJW6fmMEE sUBd4s+8S8wQtrjErSfzoeLyEtvfzmGewCg0C0n7LCQts5C0zELSsoCRZRWjZGpBcW56brFh gVFearlecWJucWleul5yfu4mRnA8aGntYNyz6oPeIUYmDsZDjBIczEoivGUxdxOFeFMSK6tS i/Lji0pzUosPMUpzsCiJ817oOhkvJJCeWJKanZpakFoEk2Xi4JRqYDr/8vHiRuN3O+I3WC+c Zz0n/fWBqKklH75vWsv/SHaSyP9vioeZXofveM2/6P7yxIASV7egfsW425PORXF+8w6fciYs ktX6VIDEZq9bhSsYrG9uaJ/R3qtom6a4y2/Xz98y09a9yr256H/rqbXeyc4Xd9sdP/4x9bqK V1b8lqDy2Zt/qDi8Nj/7YGZd16QrW8sdbj9gVJIp1ehpO8M0JUZ0muHNFnXL+e1PeRxLTqWF ylyyudTU/fFT2tLzHQtMH2bP3seZ+az3aO5HncwuDRvFrd+bpyxR8TgR4Xt85eaj37sCG0Pl b8/oSZw/LchNnF99tesDjskOJbcbynTS96+Xk5nO3JlgvCJw7f9FMZ+UWIozEg21mIuKEwH9 Obc09gIAAA== X-CMS-MailID: 20220111230406epcas1p31d22a8f83fc128557ff2f327672c458d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220111102419epcas1p17569dac08e8ccb4e3a07e74e70d83023 References: <20220111102411.16666-1-hmz007@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/11/22 8:05 PM, gtXfined H. wrote: > Hi, > >> Which board did you test? When you do power-on, is it reproduced every > time? > > I am using Rockchip RK3399 based board - NanoPi R4S for this test. > It doesn't appear every time, but it should be encountered once about 20 > times. > I have run "setenv bootcmd reset; saveenv; reset" for automated testing. This patch doesn't clarify. The below commit had been fixed that doesn't work when data read. "mmc: dw_mmc: Fixes data read when receiving DTO interrupt in FIFO mode" It seems that not clearing during reset card. (power glitch or other problem..?) Best Regards, Jaehoon Chung > > >> Could you change from your ID to your name? > > This is my first time sending a patch, sorry I didn't notice this, do I > need to resend this patch? > > > BR, > Jensen, Huang > > > On Tue, Jan 11, 2022 at 6:38 PM Jaehoon Chung > wrote: > >> Hi, >> >> On 1/11/22 7:24 PM, hmz007 wrote: >>> Clearing the DTO interrupt should be unnecessary, and it would >>> potentially result in never receiving this interrupt again. >>> >>> Do power-on or reset from uboot for a while can reproduce the issue: >>> dwmci_data_transfer: Timeout waiting for data! >>> mmc_load_image_raw_sector: mmc block read error >> >> Which board did you test? When you do power-on, is it reproduced every >> time? >> >>> >>> Tested on NanoPi R4S with SanDisk Extreme PRO 32GB. >>> >>> Fixes: 8cb9d3ed3a ("mmc: dw_mmc: Fixes data read when receiving DTO >> interrupt in FIFO mode") >>> Signed-off-by: hmz007 >> >> Could you change from your ID to your name? >> >> Best Regards, >> Jaehoon Chung >> >>> --- >>> drivers/mmc/dw_mmc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c >>> index a949dad574..8fa26b340b 100644 >>> --- a/drivers/mmc/dw_mmc.c >>> +++ b/drivers/mmc/dw_mmc.c >>> @@ -168,7 +168,7 @@ static int dwmci_data_transfer(struct dwmci_host >> *host, struct mmc_data *data) >>> if (data->flags == MMC_DATA_READ && >>> (mask & (DWMCI_INTMSK_RXDR | >> DWMCI_INTMSK_DTO))) { >>> dwmci_writel(host, DWMCI_RINTSTS, >>> - DWMCI_INTMSK_RXDR | >> DWMCI_INTMSK_DTO); >>> + DWMCI_INTMSK_RXDR); >>> while (size) { >>> ret = dwmci_fifo_ready(host, >>> DWMCI_FIFO_EMPTY, >>> >> >> >