From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: tidy up gen8_init_scratch Date: Wed, 27 Apr 2016 11:15:31 +0100 Message-ID: <57209143.4030309@intel.com> References: <1461662839-14690-1-git-send-email-matthew.auld@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id E06946EA49 for ; Wed, 27 Apr 2016 10:15:41 +0000 (UTC) In-Reply-To: <1461662839-14690-1-git-send-email-matthew.auld@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Matthew Auld List-Id: intel-gfx@lists.freedesktop.org T24gMjYvMDQvMTYgMTA6MjcsIE1hdHRoZXcgQXVsZCB3cm90ZToKPiBVc2UgZ290byB0ZWFyZG93 biBwYXRoIGFuZCBhbHNvIGVuc3VyZSB3ZSByZXNldCBhbnkgc3RydWN0IG1lbWJlcnMgd2hpY2gK PiB3b3VsZCBvdGhlcndpc2UgY29udGFpbiBhbiBlcnJvciBlbmNvZGVkIHBvaW50ZXIsIGFuZCBj b3VsZCBiZSBtaXN0YWtlbgo+IGZvciBhIHZhbGlkIGFkZHJlc3MuCj4KPiBDYzogSm9vbmFzIExh aHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxkQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMTEgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f Z3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IGluZGV4IDBkNjY2 YjMuLmE3MjNiNzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f Z3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBAIC04 NjYsMzEgKzg2NiwzMSBAQCBzdGF0aWMgdm9pZCBnZW44X2ZyZWVfcGFnZV90YWJsZXMoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgIHN0YXRpYyBpbnQgZ2VuOF9pbml0X3NjcmF0Y2goc3RydWN0 IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0pCj4gICB7Cj4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IHZtLT5kZXY7Cj4gKwlpbnQgcmV0Owo+Cj4gICAJdm0tPnNjcmF0Y2hfcGFnZSA9IGFsbG9j X3NjcmF0Y2hfcGFnZShkZXYpOwo+IC0JaWYgKElTX0VSUih2bS0+c2NyYXRjaF9wYWdlKSkKPiAt CQlyZXR1cm4gUFRSX0VSUih2bS0+c2NyYXRjaF9wYWdlKTsKPiArCWlmIChJU19FUlIodm0tPnNj cmF0Y2hfcGFnZSkpIHsKPiArCQlyZXQgPSBQVFJfRVJSKHZtLT5zY3JhdGNoX3BhZ2UpOwo+ICsJ CWdvdG8gZmFpbF9zY3JhdGNoOwo+ICsJfQo+Cj4gICAJdm0tPnNjcmF0Y2hfcHQgPSBhbGxvY19w dChkZXYpOwo+ICAgCWlmIChJU19FUlIodm0tPnNjcmF0Y2hfcHQpKSB7Cj4gLQkJZnJlZV9zY3Jh dGNoX3BhZ2UoZGV2LCB2bS0+c2NyYXRjaF9wYWdlKTsKPiAtCQlyZXR1cm4gUFRSX0VSUih2bS0+ c2NyYXRjaF9wdCk7Cj4gKwkJcmV0ID0gUFRSX0VSUih2bS0+c2NyYXRjaF9wdCk7Cj4gKwkJZ290 byBmYWlsX3B0Owo+ICAgCX0KPgo+ICAgCXZtLT5zY3JhdGNoX3BkID0gYWxsb2NfcGQoZGV2KTsK PiAgIAlpZiAoSVNfRVJSKHZtLT5zY3JhdGNoX3BkKSkgewo+IC0JCWZyZWVfcHQoZGV2LCB2bS0+ c2NyYXRjaF9wdCk7Cj4gLQkJZnJlZV9zY3JhdGNoX3BhZ2UoZGV2LCB2bS0+c2NyYXRjaF9wYWdl KTsKPiAtCQlyZXR1cm4gUFRSX0VSUih2bS0+c2NyYXRjaF9wZCk7Cj4gKwkJcmV0ID0gUFRSX0VS Uih2bS0+c2NyYXRjaF9wZCk7Cj4gKwkJZ290byBmYWlsX3BkOwo+ICAgCX0KPgo+ICAgCWlmIChV U0VTX0ZVTExfNDhCSVRfUFBHVFQoZGV2KSkgewo+ICAgCQl2bS0+c2NyYXRjaF9wZHAgPSBhbGxv Y19wZHAoZGV2KTsKPiAgIAkJaWYgKElTX0VSUih2bS0+c2NyYXRjaF9wZHApKSB7Cj4gLQkJCWZy ZWVfcGQoZGV2LCB2bS0+c2NyYXRjaF9wZCk7Cj4gLQkJCWZyZWVfcHQoZGV2LCB2bS0+c2NyYXRj aF9wdCk7Cj4gLQkJCWZyZWVfc2NyYXRjaF9wYWdlKGRldiwgdm0tPnNjcmF0Y2hfcGFnZSk7Cj4g LQkJCXJldHVybiBQVFJfRVJSKHZtLT5zY3JhdGNoX3BkcCk7Cj4gKwkJCXJldCA9IFBUUl9FUlIo dm0tPnNjcmF0Y2hfcGRwKTsKPiArCQkJZ290byBmYWlsX3BkcDsKPiAgIAkJfQo+ICAgCX0KPgo+ IEBAIC05MDAsNiArOTAwLDIwIEBAIHN0YXRpYyBpbnQgZ2VuOF9pbml0X3NjcmF0Y2goc3RydWN0 IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0pCj4gICAJCWdlbjhfaW5pdGlhbGl6ZV9wZHAodm0sIHZt LT5zY3JhdGNoX3BkcCk7Cj4KPiAgIAlyZXR1cm4gMDsKPiArCj4gK2ZhaWxfcGRwOgo+ICsJdm0t PnNjcmF0Y2hfcGRwID0gTlVMTDsKPiArCWZyZWVfcGQoZGV2LCB2bS0+c2NyYXRjaF9wZCk7Cj4g K2ZhaWxfcGQ6Cj4gKwl2bS0+c2NyYXRjaF9wZCA9IE5VTEw7Cj4gKwlmcmVlX3B0KGRldiwgdm0t PnNjcmF0Y2hfcHQpOwo+ICtmYWlsX3B0Ogo+ICsJdm0tPnNjcmF0Y2hfcHQgPSBOVUxMOwo+ICsJ ZnJlZV9zY3JhdGNoX3BhZ2UoZGV2LCB2bS0+c2NyYXRjaF9wYWdlKTsKPiArZmFpbF9zY3JhdGNo Ogo+ICsJdm0tPnNjcmF0Y2hfcGFnZSA9IE5VTEw7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiAgIH0K Pgo+ICAgc3RhdGljIGludCBnZW44X3BwZ3R0X25vdGlmeV92Z3Qoc3RydWN0IGk5MTVfaHdfcHBn dHQgKnBwZ3R0LCBib29sIGNyZWF0ZSkKCldlbGwsIEkgYWdyZWUgaXQncyBhIGdvb2QgaWRlYSBu b3QgdG8gYXNzaWduIG5vbi1OVUxMIHBvaW50ZXIgdmFsdWVzIHRvIAptZW1iZXJzIG9mIGFuIE9V VCBwYXJhbWV0ZXIsIGJ1dCBwZXJoYXBzIGNvbnNpZGVyIGEgc3RyYXRlZ3kgb2YgCmFzc2lnbmlu ZyB0byBhIGxvY2FsLCBjaGVja2luZyB0aGUgcmVzdWx0LCBhbmQgc3RvcmluZyBpbiB0aGUgcGFy YW1ldGVyIApibG9jayBvbmx5IGFmdGVyIHdlIGtub3cgdGhhdCBpdCdzIGEgZ29vZCBwb2ludGVy LiBNYXliZSBldmVuIGtlZXAgQUxMIAp0aGUgdGVtcG9yYXJ5IHBvaW50ZXJzIGxvY2FsIGFuZCBv bmx5IGFzc2lnbiAqYW55KiBvZiB0aGVtIHdoZW4gd2Uga25vdyAKd2UgY2FuIGFzc2lnbiAqYWxs KiBvZiB0aGVtIGFuZCByZXR1cm4gc3VjY2Vzcy4gVGhhdCB3YXkgdGhlcmUncyBubyAKY2xlYW51 cCBvZiB0aGUgcmVzdWx0IGJsb2NrIHJlcXVpcmVkIGluIHRoZSBlcnJvciBwYXRoLCBvbmx5IGZy ZWVpbmcgb2YgCnN0aWxsLWxvY2FsIHZhbHVlcy4KCkJUVywgYXMgaXQgYXBwZWFycyB0aGF0IHRo aXMgZnVuY3Rpb24gY2FuIGJlIGNhbGxlZCBtb3JlIHRoYW4gb25jZSBpbiAKdGhlIGxpZmV0aW1l IG9mIHRoZSBkcml2ZXIsIGRvIHdlIGtub3cgdGhhdCBhbGwgdGhlc2UgcG9pbnRlcnMgd2lsbCBi ZSAKTlVMTCBvbiBlbnRyeT8gRXZlbiBvbiB0aGUgc2Vjb25kIGFuZCBzdWJzZXF1ZW50IGNhbGxz PwoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=