From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914AbcD0Pqv (ORCPT ); Wed, 27 Apr 2016 11:46:51 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34824 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbcD0Pqr (ORCPT ); Wed, 27 Apr 2016 11:46:47 -0400 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit References: <1461339084-3849-1-git-send-email-nicolas.dichtel@6wind.com> <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com> <57201287.80002@gmail.com> <57206A47.2010906@6wind.com> <5720B0A2.1030405@gmail.com> To: Balbir Singh , netdev@vger.kernel.org Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, aar@pengutronix.de, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, dev@openvswitch.org, steffen.klassert@secunet.com, herbert@gondor.apana.org.au From: Nicolas Dichtel Organization: 6WIND Message-ID: <5720DED8.4090706@6wind.com> Date: Wed, 27 Apr 2016 17:46:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <5720B0A2.1030405@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 27/04/2016 14:29, Balbir Singh a écrit : [snip] > Please try > > https://www.kernel.org/doc/Documentation/accounting/getdelays.c A patch follows this mail to fix that. > > iotop uses it as well. My concern is ABI breakage of user space. My test is ok here, I didn't see a problem. Code review (from here http://repo.or.cz/w/iotop.git) is also ok. Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit Date: Wed, 27 Apr 2016 17:46:32 +0200 Message-ID: <5720DED8.4090706@6wind.com> References: <1461339084-3849-1-git-send-email-nicolas.dichtel@6wind.com> <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com> <57201287.80002@gmail.com> <57206A47.2010906@6wind.com> <5720B0A2.1030405@gmail.com> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org, kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org, jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org, linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org To: Balbir Singh , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <5720B0A2.1030405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org TGUgMjcvMDQvMjAxNiAxNDoyOSwgQmFsYmlyIFNpbmdoIGEgw6ljcml0IDoKW3NuaXBdCj4gUGxl YXNlIHRyeQo+IAo+IGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL0RvY3VtZW50YXRpb24vYWNj b3VudGluZy9nZXRkZWxheXMuYwpBIHBhdGNoIGZvbGxvd3MgdGhpcyBtYWlsIHRvIGZpeCB0aGF0 LgoKPiAKPiBpb3RvcCB1c2VzIGl0IGFzIHdlbGwuIE15IGNvbmNlcm4gaXMgQUJJIGJyZWFrYWdl IG9mIHVzZXIgc3BhY2UuCk15IHRlc3QgaXMgb2sgaGVyZSwgSSBkaWRuJ3Qgc2VlIGEgcHJvYmxl bS4KQ29kZSByZXZpZXcgKGZyb20gaGVyZSBodHRwOi8vcmVwby5vci5jei93L2lvdG9wLmdpdCkg aXMgYWxzbyBvay4KCgpSZWdhcmRzLApOaWNvbGFzCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRldiBtYWlsaW5nIGxpc3QKZGV2QG9wZW52c3dpdGNoLm9y ZwpodHRwOi8vb3BlbnZzd2l0Y2gub3JnL21haWxtYW4vbGlzdGluZm8vZGV2Cg==