From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yisen Zhuang Subject: Re: [PATCH v2 net-next 11/13] Documentation: Bindings: Update DT binding for separating dsaf dev support Date: Thu, 28 Apr 2016 09:45:31 +0800 Message-ID: <57216B3B.8000306@huawei.com> References: <1461402317-136499-1-git-send-email-Yisen.Zhuang@huawei.com> <1461402317-136499-12-git-send-email-Yisen.Zhuang@huawei.com> <20160426124847.GA26682@rob-hp-laptop> <57203309.1090501@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Mark Rutland , "devicetree@vger.kernel.org" , salil.mehta@huawei.com, Catalin Marinas , xieqianqian@huawei.com, Pawel Moll , Ian Campbell , netdev , lipeng321@huawei.com, Will Deacon , Linuxarm , Wei Xu , huangdaode , Kumar Gala , yankejian , David Miller , "linux-arm-kernel@lists.infradead.org" , liguozhu@huawei.com To: Rob Herring Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org SGkgUm9iLAoKVGhhbmtzIGZvciB5b3UgY29tbWVudHMuCgrlnKggMjAxNi80LzI3IDIzOjI1LCBS b2IgSGVycmluZyDlhpnpgZM6Cj4gT24gVHVlLCBBcHIgMjYsIDIwMTYgYXQgMTA6MzMgUE0sIFlp c2VuIFpodWFuZyA8WWlzZW4uemh1YW5nQGh1YXdlaS5jb20+IHdyb3RlOgo+PiBIaSBSb2IgYW5k IERhdmlkLAo+Pgo+PiBQbGVhc2Ugc2VlIG15IGNvbW1lbnRzIGlubGluZS4KPj4KPj4gRGF2aWQg aGF2ZSBtZXJnZWQgdGhpcyBzZXJpZXMgdG8gbmV0LW5leHQsIGJ1dCB3ZSBuZWVkIHRvIG1vZGlm eSBzb21lIGNvZGVzIGFjY29yZGluZwo+PiB0byBSb2IncyBjb21tZW50cy4gSSBhbSBub3Qgc3Vy ZSBpZiBpIG5lZWQgdG8gc2VuZCBWMyBmb3IgdGhpcyBzZXJpZXMsIG9yIHNlcGFyYXRlCj4+IHBh dGNoZXMgb2YgZG9jdW1lbnRhdGlvbiB0byBpbmRlcGVuZGVudCBzZXJpZXMgYW5kIGdlbmVyYXRl IGEgbmV3IHBhdGNoIGZvciBobnMgYmFzZQo+PiBvbiBjdXJyZW50IG5ldC1uZXh0Pwo+IAo+IFRo YXQncyBEYXZpZCdzIGNhbGwuIEknbSBndWVzc2luZyBoZSB3YW50cyBmb2xsb3ctdXAgcGF0Y2hl cyBvbiB0b3Agb2YgdGhlc2UuCgpPa2F5LCBJIHdpbGwgc2VuZCBhIG5ldyBzZXJpZXMgYmFzZSBv biBjdXJyZW50IG5ldC1uZXh0LgoKPiAKPj4g5ZyoIDIwMTYvNC8yNiAyMDo0OCwgUm9iIEhlcnJp bmcg5YaZ6YGTOgo+Pj4gT24gU2F0LCBBcHIgMjMsIDIwMTYgYXQgMDU6MDU6MTVQTSArMDgwMCwg WWlzZW4gWmh1YW5nIHdyb3RlOgo+Pj4+IEJlY2F1c2UgZGVidWcgZHNhZiBwb3J0IHdhcyBzZXBh cmF0ZWQgZnJvbSBzZXJ2aWNlIGRzYWYgcG9ydCwgdGhpcyBwYXRjaAo+Pj4+IHVwZGF0ZXMgdGhl IHJlbGF0ZWQgaW5mb3JtYXRpb24gb2YgRFQgYmluZGluZy4KPj4+Cj4+PiBTZXBhcmF0ZWQgd2hl bj8gTmV3IHZlcnNpb24gb2YgdGhlIGgvdz8gSWYgc28sIHdoZXJlJ3MgdGhlIG5ldwo+Pj4gY29t cGF0aWJsZSBzdHJpbmc/IFRoaXMgaXMgcXVpdGUgYSBiaWcgYmluZGluZyBjaGFuZ2UuCj4+Cj4+ IFRoZXJlIGlzbid0IGFueSBjaGFuZ2Ugb2YgaC93LiBJIHNlcGFyYXRlZCBkZWJ1ZyBkc2FmIHBv cnQgZnJvbSBzZXZpY2UgZHNhZgo+PiBwb3J0IHRvIG1ha2UgdGhlIGNvZGUgbW9yZSBzaW1wbGUg YW5kIHJlYWRhYmlsaXR5Lgo+IAo+IE9rYXkuCj4gCj4gWy4uLl0KPiAKPj4+PiArICBzZXJkZXMt c3lzY29uIHJhdGhlciB0aGFuIHRoaXMgYWRkcmVzcy4KPj4+PiAgICBUaGUgdGhpcmQgcmVnaW9u IGlzIHRoZSBQUEUgcmVnaXN0ZXIgYmFzZSBhbmQgc2l6ZS4KPj4+PiAtICBUaGUgZm91cnRoIHJl Z2lvbiBpcyBkc2EgZmFicmljIGJhc2UgcmVnaXN0ZXIgYW5kIHNpemUuCj4+Pj4gLSAgVGhlIGZp ZnRoIHJlZ2lvbiBpcyBjcGxkIGJhc2UgcmVnaXN0ZXIgYW5kIHNpemUsIGl0IGlzIG5vdCByZXF1 aXJlZCBpZiBkbyBub3QgdXNlIGNwbGQuCj4+Pj4gLS0gcGh5LWhhbmRsZTogcGh5IGhhbmRsZSBv ZiBwaHlzaWNsIHBvcnQsIDAgaWYgbm90IGFueSBwaHkgZGV2aWNlLiBzZWUgZXRoZXJuZXQudHh0 IFsxXS4KPj4+PiArICBUaGUgZm91cnRoIHJlZ2lvbiBpcyBkc2EgZmFicmljIGJhc2UgcmVnaXN0 ZXIgYW5kIHNpemUuIEl0IGlzIG5vdCByZXF1aXJlZCBmb3IKPj4+PiArICBzaW5nbGUtcG9ydCBt b2RlLgo+Pj4+ICstIHJlZy1uYW1lczogbWF5IGJlIHBwZS1iYXNlIGFuZChvcikgZHNhZi1iYXNl LiBJdCBpcyB1c2VkIHRvIGZpbmQgdGhlCj4+Pj4gKyAgY29ycmVzcG9uZGluZyByZWcncyBpbmRl eC4KPj4+Cj4+PiBCdXQgeW91IGhhdmUgdXAgdG8gNSByZWdpb25zLgo+Pj4KPj4+IFRoZSB2YXJp YWJsZSBuYXR1cmUgb2Ygd2hhdCByZWdpb25zIHlvdSBoYXZlIHRlbGxzIG1lIHlvdSBuZWVkIG1v cmUKPj4+IHNwZWNpZmljIGNvbXBhdGlibGUgc3RyaW5ncyBmb3IgZWFjaCBjaGlwLgo+Pgo+PiB3 ZSBkaWRuJ3QgYWRkIHN1cHBvcnQgb2YgbmV3IGgvdy4gV2UgYWRkZWQgdGhlc2UgcmVnaW9ucyB0 byBtYWtlIGNvZGUgc2ltcGxlIGFuZCByZWFkYWJpbGl0eS4KPj4gSWYgd2UgbmVlZCB0byBhZGQg c3VwcG9ydCBvZiBuZXh0IGgvdyB2ZXJzaW9uIG5leHQgdGltZSwgd2UgZG9uJ3QgbmVlZCB0byBh ZGQgbWFueSBicmFuY2hlcwo+PiBmb3IgdGhlc2UgYXR0cmlidXRlcy4gU28gd2UgZGlkbid0IGFk ZCBhIG5ldyBjb21wYXRpYmxlIGhlcmUuCj4gCj4gTm90IHN1cmUgd2hhdCB5b3UgbWVhbiBieSBi cmFuY2hlcy4gSXQncyBmaW5lIHRvIHB1dCBwcm9wZXJ0aWVzIGZvcgo+IHRoaW5ncyB0aGF0IHZh cnkgYW1vbmcgaC93IHZlcnNpb25zLCBidXQgbmV3IGNvbXBhdGlibGUgc3RyaW5ncyB3aWxsCj4g YmUgbmVlZGVkIGZvciBhbnkgbmV3IHZlcnNpb25zLgoKSSBtZWFuIHRoYW4gd2UgcHV0IHByb3Bl cnRpZXMgZm9yIHRoaW5ncyB0aGF0IHZhcnkgYW1vbmcgaC93IHZlcnNpb25zLiBJZiB3ZSBhZGQg c3VwcG9ydCBmb3IKbmV3IGgvdyB2ZXJzaW9ucyBuZXh0IHRpbWUsIHdlIHdpbGwgYWRkIG5ldyBj b21wYXRpYmxlIHN0cmluZ3MuCgo+IAo+IAo+Pj4+ICstIHBvcnQ6IHN1Ym5vZGVzIG9mIGRzYWYu IEEgZHNhZiBub2RlIG1heSBjb250YWluIHNldmVyYWwgcG9ydCBub2RlcyhEZXBlbmRpbmcKPj4+ PiArICBvbiBtb2RlIG9mIGRzYWYpLiBQb3J0IG5vZGUgY29udGFpbiBzb21lIGF0dHJpYnV0ZXMg bGlzdGVkIGJlbG93Ogo+Pj4+ICstIHBvcnQtaWQ6IGlzIHBoeXNpY2FsIHBvcnQgaW5kZXggaW4g b25lIGRzYWYuCj4+Pgo+Pj4gSW5kZXhlcyBzaG91bGQgZ2VuZXJhbGx5IGJlIGF2b2lkZWQuIFdo YXQgZG9lcyB0aGUgbnVtYmVyIGNvcnJlc3BvbmQKPj4+IHRvIGluIGgvdyAoaWYgYW55dGhpbmcp Pwo+Pgo+PiBwb3J0LWlkIGlzIGluZGV4IGZvciBhIHBvcnQgaW4gZHNhZiwgaXQgaXMgY29ycmVz cG9uZCB0byBpbmRleCBvZiBQSFkgc2hvd2VkIGJlbG93Lgo+IAo+IE9rYXksIHlvdSBzaG91bGQg dXNlIHJlZyBwcm9wZXJ0eSBoZXJlIGluc3RlYWQuCgpBZ3JlZSwgdGhhbmtzLgoKPiAKPj4KPj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Q1BVCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAgICAgICAgICAgICAgICAgICB8ICAgICAgICAgICB8Cj4+ICAgICAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tICAgIC0tLS0tLS0tLSAg IC0tLS0tLS0tLQo+PiAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgICAgICAgICAg ICAgICAgfCAgICB8ICAgICAgIHwgICB8ICAgfCAgIHwKPj4gICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICBQUEUgICAgICAgICAgICAgICAgIHwgICAgfCAgUFBFICB8ICAgfCAgUFBFICB8Cj4+ ICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICAgICB8ICAgIHwg ICB8ICAgfCAgIHwgICB8ICAgfAo+PiAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg ICAgICAgICAgICAgICAgfCAgICB8ICAgfCAgIHwgICB8ICAgfCAgIHwKPj4gICAgIHwgICAgICAg ICAgICAgICAgICAgICAgY3Jvc3NiYXIgICAgICAgICAgICAgIHwgICAgfCAgIHwgICB8ICAgfCAg IHwgICB8Cj4+ICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICAg ICB8ICAgIHwgICB8ICAgfCAgIHwgICB8ICAgfAo+PiAgICAgfCAgIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0gICAgICAgfCAgICB8ICAgfCAgIHwgICB8ICAgfCAgIHwKPj4gICAg IHwgICB8ICAgICB8ICAgICB8ICAgICAgfCAgICAgIHwgICAgICB8ICAgICAgIHwgICAgfCAgIHwg ICB8ICAgfCAgIHwgICB8Cj4+ICAgICB8ICAgfCAgICAgfCAgICAgfCAgICAgIHwgICAgICB8ICAg ICAgfCAgICAgICB8ICAgIHwgICB8ICAgfCAgIHwgICB8ICAgfAo+PiAgICAgfCAgTUFDICAgTUFD ICAgTUFDICAgIE1BQyAgICBNQUMgICAgTUFDICAgICAgfCAgICB8ICBNQUMgIHwgICB8ICBNQUMg IHwKPj4gICAgIHwgICB8ICAgICB8ICAgICB8ICAgICAgfCAgICAgIHwgICAgICB8ICAgICAgIHwg ICAgfCAgIHwgICB8ICAgfCAgIHwgICB8Cj4+ICAgICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tICAgIC0tLS0tLS0tLSAgIC0tLS0tLS0tLQo+PiAgICAgICAg IHwgICAgIHwgICAgIHwgICAgICB8ICAgICAgfCAgICAgIHwgICAgXCAgICAgICAgLyAgfCAgICAg ICAgLyAgfAo+PiAgICAgICAgUEhZICAgUEhZICAgUEhZICAgIFBIWSAgICBQSFkgICAgUEhZICAg IFwgICAgICAvICBQSFkgICAgICAvICBQSFkKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXCAgICAvICAgICAgICAgICAvCj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcICAvICAgICAgICAgICAvCj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERTQUYodGhyZWUgcGxh dGZvcm0gZGV2aWNlKQo+Pgo+Pj4KPj4+PiArLSBwaHktaGFuZGxlOiBwaHkgaGFuZGxlIG9mIHBo eXNpY2wgcG9ydC4gSXQgaXMgbm90IHJlcXVpcmVkIGlmIHRoZXJlIGlzbid0Cj4gCj4gQW5vdGhl ciB0eXBvIGhlcmUuCgpBZ3JlZSwgdGhhbmtzLgoKPiAKPiBSb2IKPiAKPiAuCj4gCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yisen.zhuang@huawei.com (Yisen Zhuang) Date: Thu, 28 Apr 2016 09:45:31 +0800 Subject: [PATCH v2 net-next 11/13] Documentation: Bindings: Update DT binding for separating dsaf dev support In-Reply-To: References: <1461402317-136499-1-git-send-email-Yisen.Zhuang@huawei.com> <1461402317-136499-12-git-send-email-Yisen.Zhuang@huawei.com> <20160426124847.GA26682@rob-hp-laptop> <57203309.1090501@huawei.com> Message-ID: <57216B3B.8000306@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, Thanks for you comments. ? 2016/4/27 23:25, Rob Herring ??: > On Tue, Apr 26, 2016 at 10:33 PM, Yisen Zhuang wrote: >> Hi Rob and David, >> >> Please see my comments inline. >> >> David have merged this series to net-next, but we need to modify some codes according >> to Rob's comments. I am not sure if i need to send V3 for this series, or separate >> patches of documentation to independent series and generate a new patch for hns base >> on current net-next? > > That's David's call. I'm guessing he wants follow-up patches on top of these. Okay, I will send a new series base on current net-next. > >> ? 2016/4/26 20:48, Rob Herring ??: >>> On Sat, Apr 23, 2016 at 05:05:15PM +0800, Yisen Zhuang wrote: >>>> Because debug dsaf port was separated from service dsaf port, this patch >>>> updates the related information of DT binding. >>> >>> Separated when? New version of the h/w? If so, where's the new >>> compatible string? This is quite a big binding change. >> >> There isn't any change of h/w. I separated debug dsaf port from sevice dsaf >> port to make the code more simple and readability. > > Okay. > > [...] > >>>> + serdes-syscon rather than this address. >>>> The third region is the PPE register base and size. >>>> - The fourth region is dsa fabric base register and size. >>>> - The fifth region is cpld base register and size, it is not required if do not use cpld. >>>> -- phy-handle: phy handle of physicl port, 0 if not any phy device. see ethernet.txt [1]. >>>> + The fourth region is dsa fabric base register and size. It is not required for >>>> + single-port mode. >>>> +- reg-names: may be ppe-base and(or) dsaf-base. It is used to find the >>>> + corresponding reg's index. >>> >>> But you have up to 5 regions. >>> >>> The variable nature of what regions you have tells me you need more >>> specific compatible strings for each chip. >> >> we didn't add support of new h/w. We added these regions to make code simple and readability. >> If we need to add support of next h/w version next time, we don't need to add many branches >> for these attributes. So we didn't add a new compatible here. > > Not sure what you mean by branches. It's fine to put properties for > things that vary among h/w versions, but new compatible strings will > be needed for any new versions. I mean than we put properties for things that vary among h/w versions. If we add support for new h/w versions next time, we will add new compatible strings. > > >>>> +- port: subnodes of dsaf. A dsaf node may contain several port nodes(Depending >>>> + on mode of dsaf). Port node contain some attributes listed below: >>>> +- port-id: is physical port index in one dsaf. >>> >>> Indexes should generally be avoided. What does the number correspond >>> to in h/w (if anything)? >> >> port-id is index for a port in dsaf, it is correspond to index of PHY showed below. > > Okay, you should use reg property here instead. Agree, thanks. > >> >> CPU >> | >> ----------------------------------- >> | | | >> ---------------------------------------------- --------- --------- >> | | | | | | | | >> | PPE | | PPE | | PPE | >> | | | | | | | | | >> | | | | | | | | | >> | crossbar | | | | | | | >> | | | | | | | | | >> | ---------------------------------- | | | | | | | >> | | | | | | | | | | | | | | >> | | | | | | | | | | | | | | >> | MAC MAC MAC MAC MAC MAC | | MAC | | MAC | >> | | | | | | | | | | | | | | >> ---------------------------------------------- --------- --------- >> | | | | | | \ / | / | >> PHY PHY PHY PHY PHY PHY \ / PHY / PHY >> \ / / >> \ / / >> DSAF(three platform device) >> >>> >>>> +- phy-handle: phy handle of physicl port. It is not required if there isn't > > Another typo here. Agree, thanks. > > Rob > > . >