From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V17 1/3] dmaengine: qcom_hidma: implement lower level hardware interface Date: Thu, 28 Apr 2016 15:30:07 -0400 Message-ID: <572264BF.5010703@codeaurora.org> References: <1460384473-5775-1-git-send-email-okaya@codeaurora.org> <1460384473-5775-2-git-send-email-okaya@codeaurora.org> <20160426032805.GA2274@localhost> <571F8397.5000803@codeaurora.org> <20160426162441.GJ2274@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:58610 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbcD1TaN (ORCPT ); Thu, 28 Apr 2016 15:30:13 -0400 In-Reply-To: <20160426162441.GJ2274@localhost> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Vinod Koul Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, shankerd@codeaurora.org, vikrams@codeaurora.org, marc.zyngier@arm.com, mark.rutland@arm.com, eric.auger@linaro.org, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Andy Shevchenko , linux-kernel@vger.kernel.org On 4/26/2016 12:24 PM, Vinod Koul wrote: >> + >> > + dev_err(lldev->dev, "error 0x%x, resetting...\n", >> > + cause); > right justify this and others as well please > Can you please point me to other lines that need to be fixed please? It looks good to me though it doesn't to you. I want to make sure that I'm touching the right ones. You seem to prefer a tab following an open parenthesis in your code. Do you want me to add a tab for every single multi-line such that it comes this for instance? ret = readl_poll_timeout(lldev->trca + HIDMA_TRCA_CTRLSTS_REG, val, HIDMA_CH_STATE(val) == HIDMA_CH_DISABLED, 1000, 10000); instead of ret = readl_poll_timeout(lldev->trca + HIDMA_TRCA_CTRLSTS_REG, val, HIDMA_CH_STATE(val) == HIDMA_CH_DISABLED, 1000, 10000); >>>> > >> +int hidma_ll_resume(struct hidma_lldev *lldev) >>>> > >> +{ >>>> > >> + return hidma_ll_enable(lldev); >>>> > >> +} >>> > > >>> > > why do we need this empty function, use hidma_ll_enable. >> > >> > hidma_ll_enable is a common function that gets called from multiple places. >> > hidma_ll_resume and hidma_ll_pause is used by the OS interface for pausing >> > and resuming the DMA channel. > is there a reason why we can't have the code in resume and that being called > internally as well as externally? > I'll have the pause code in OS layer call hidma_ll_enable and get rid of pause function here. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Thu, 28 Apr 2016 15:30:07 -0400 Subject: [PATCH V17 1/3] dmaengine: qcom_hidma: implement lower level hardware interface In-Reply-To: <20160426162441.GJ2274@localhost> References: <1460384473-5775-1-git-send-email-okaya@codeaurora.org> <1460384473-5775-2-git-send-email-okaya@codeaurora.org> <20160426032805.GA2274@localhost> <571F8397.5000803@codeaurora.org> <20160426162441.GJ2274@localhost> Message-ID: <572264BF.5010703@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 4/26/2016 12:24 PM, Vinod Koul wrote: >> + >> > + dev_err(lldev->dev, "error 0x%x, resetting...\n", >> > + cause); > right justify this and others as well please > Can you please point me to other lines that need to be fixed please? It looks good to me though it doesn't to you. I want to make sure that I'm touching the right ones. You seem to prefer a tab following an open parenthesis in your code. Do you want me to add a tab for every single multi-line such that it comes this for instance? ret = readl_poll_timeout(lldev->trca + HIDMA_TRCA_CTRLSTS_REG, val, HIDMA_CH_STATE(val) == HIDMA_CH_DISABLED, 1000, 10000); instead of ret = readl_poll_timeout(lldev->trca + HIDMA_TRCA_CTRLSTS_REG, val, HIDMA_CH_STATE(val) == HIDMA_CH_DISABLED, 1000, 10000); >>>> > >> +int hidma_ll_resume(struct hidma_lldev *lldev) >>>> > >> +{ >>>> > >> + return hidma_ll_enable(lldev); >>>> > >> +} >>> > > >>> > > why do we need this empty function, use hidma_ll_enable. >> > >> > hidma_ll_enable is a common function that gets called from multiple places. >> > hidma_ll_resume and hidma_ll_pause is used by the OS interface for pausing >> > and resuming the DMA channel. > is there a reason why we can't have the code in resume and that being called > internally as well as externally? > I'll have the pause code in OS layer call hidma_ll_enable and get rid of pause function here. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project