From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403F3C433E0 for ; Thu, 21 Jan 2021 19:57:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A423923A54 for ; Thu, 21 Jan 2021 19:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A423923A54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2g51-0002HU-BI for qemu-devel@archiver.kernel.org; Thu, 21 Jan 2021 14:57:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2g3t-000124-Fg for qemu-devel@nongnu.org; Thu, 21 Jan 2021 14:56:09 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:32860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2g3r-0001PH-Sg for qemu-devel@nongnu.org; Thu, 21 Jan 2021 14:56:09 -0500 Received: by mail-pj1-x102f.google.com with SMTP id lw17so5298527pjb.0 for ; Thu, 21 Jan 2021 11:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Q9dAf5Suv6GtYs6hJpO/VPS6ykV1whvtSBZk5N2yUY0=; b=UJS/6jTakQM2jjdKoqzhFZqBSY5X+jQEFRlgdd774Z1NmH78BBijlHLrH8CdSoU2jn /R5739hakQf1GHKI2CMlVFoaspfl21cNT/EkpeZzvVHDJWNXTdL/SJ6wEGHcnph4BnRw V2zS9ug2qvo17OEaQbtJNnGFd0NO5ZMCpDhhN4Azm8R5DDOlbiKEjIsVwHbf6ikXx+fS EGkYdSP/GXN+F600ExcPtrhqCO9Ps+280R7Bsh7nKJsq2b7FhF1zil/daP8xElYs98k5 fZVykF3sYKXXcL7tK04CO/bcG9E8CSWhfo3KWqC8sZ7edYPzHkJWLUM+uUZX3aqtpnXE xhIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q9dAf5Suv6GtYs6hJpO/VPS6ykV1whvtSBZk5N2yUY0=; b=raA0RGxzzdHKvribKsCXfMLo/fCsspvvIbjfn6OrnEix60kYptCrvpE+TPh7uPeTTP qEnIE7iRU9C7pt/9R256ldX+dAQi688zqXFQ5i+OdkK5Q7cvjKLjW7JPHOju1j0rTok5 ytrObfX/LXS8RRZAk0ZEWqDQxUMGQ2RccGB9OBU7D0tzKWeZcMmQkvK63Tn18KRPaDb7 CrJvdzZFGQg7GwpWa288+/ZQ1bs5hSioNOuOfPkE50IM4G7UBInZ2Vr4Xifd6F2U6Bcr vP27V45L6ffn8FmxWWn9oWuIGHAGvBmAWL5Kj9mzqQyrZ1NVcRW8SBfJCAhm5YFPR0uU Xbjg== X-Gm-Message-State: AOAM532uG3y5Ol2Zmlmme6FSJgl1ZS6xxLC1YRmum7cMzTjnpgmJQZm6 bP6c6aNWi0VaguoC/1r01psM0A== X-Google-Smtp-Source: ABdhPJwt5mJLfk22+vsHbYLDNFzoWTOYtmOQhB9xh+M5ukl8P+votO+ncQQzgFs0eltPe9aXnRSU9g== X-Received: by 2002:a17:90a:a608:: with SMTP id c8mr1115405pjq.61.1611258966334; Thu, 21 Jan 2021 11:56:06 -0800 (PST) Received: from [192.168.3.43] (cpe-66-75-72-126.hawaii.res.rr.com. [66.75.72.126]) by smtp.gmail.com with ESMTPSA id k4sm6214106pfk.44.2021.01.21.11.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 11:56:05 -0800 (PST) Subject: Re: [PATCH 3/6] target/mips: Convert Loongson DIV.G opcodes to decodetree To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210112215504.2093955-1-f4bug@amsat.org> <20210112215504.2093955-4-f4bug@amsat.org> From: Richard Henderson Message-ID: <5722a920-f627-d9d1-2350-28f7b86319c1@linaro.org> Date: Thu, 21 Jan 2021 09:56:02 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210112215504.2093955-4-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/12/21 11:55 AM, Philippe Mathieu-Daudé wrote: > DIV.G and DDIV.G are very similar. Provide gen_lext_DIV_G() a > 'is_double' argument so it can generate DIV.G (divide 32-bit > signed integers). > > With this commit we explicit the template used to generate > opcode for 32/64-bit word variants. Next commits will be less > verbose by providing both variants at once. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/godson2.decode | 1 + > target/mips/loong-ext.decode | 1 + > target/mips/loong_translate.c | 28 ++++++++++++++++++++++------ > target/mips/translate.c | 26 -------------------------- > 4 files changed, 24 insertions(+), 32 deletions(-) With the double-extend pasto fixed, Reviewed-by: Richard Henderson r~