All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,
	dev@dpdk.org, david.marchand@6wind.com
Subject: Re: [PATCH v5] eal: out-of-bounds write
Date: Mon, 20 Jun 2016 12:09:55 +0200	[thread overview]
Message-ID: <5727542.OiCZAjWWDW@xps13> (raw)
In-Reply-To: <d5fc0e16-95c2-70b6-9aee-5232d85e4c5e@intel.com>

2016-06-20 10:38, Sergio Gonzalez Monroy:
> On 20/06/2016 10:14, Thomas Monjalon wrote:
> >> +		RTE_LOG(ERR, EAL,
> >> +			"All memory segments exhausted by IVSHMEM. "
> > There is no evidence that it is related to IVSHMEM.
> > "Not enough memory segments." would be more appropriate.
> 
> Actually we would hit this issue when all memsegs have been used by IVSHMEM.
> So I think the message is accurate.

I think it's saner to avoid mixing "potential root cause of a use case" and
"accurate description of the error".
One day, the root cause could be different and the message will become wrong.
Here there is not enough memory segment.

  reply	other threads:[~2016-06-20 10:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 14:52 [PATCH v5] eal: out-of-bounds write Slawomir Mrozowicz
2016-06-20  9:14 ` Thomas Monjalon
2016-06-20  9:38   ` Sergio Gonzalez Monroy
2016-06-20 10:09     ` Thomas Monjalon [this message]
2016-06-20 11:29       ` Sergio Gonzalez Monroy
2016-07-21 12:01         ` Mrozowicz, SlawomirX
2016-07-21 12:54           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5727542.OiCZAjWWDW@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=slawomirx.mrozowicz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.