From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Build failure on RHEL 7.4
Date: Wed, 11 Apr 2018 22:14:01 +0200
Message-ID: <5728107.6b9GQzpIaH@xps>
References: <cd189dd0-67b4-4431-b709-366009ed8e12@solarflare.com>
 <20180411194627.GA17965@ltp-pvn> <2544114.h6jezT9v71@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, david.marchand@6wind.com
To: Anatoly Burakov <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C4BB81B7EA
 for <dev@dpdk.org>; Wed, 11 Apr 2018 22:14:05 +0200 (CEST)
In-Reply-To: <2544114.h6jezT9v71@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/04/2018 21:56, Thomas Monjalon:
> 11/04/2018 21:46, Pavan Nikhilesh:
> > On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote:
> > > 11/04/2018 21:09, Andrew Rybchenko:
> > > > Hello,
> > > >
> > > > build fails on RHEL 7.4. I've not tried to dig it.
> > >
> > > Thanks for reporting.
> > >
> > > [...]
> > > > =E2=80=98FALLOC_FL_PUNCH_HOLE=E2=80=99 undeclared (first use in thi=
s function)
> > > [...]
> > > > =E2=80=98FALLOC_FL_KEEP_SIZE=E2=80=99 undeclared (first use in this=
 function)
> > >
> > > These constants were defined in Linux 2.6.23 and 2.6.38.
> > >
> > > [...]
> > > > $ uname -r
> > > > 3.10.0-693.el7.x86_64
> > >
> > > It should be OK.
> > >
> > > I think we are just missing
> > > 	#include <linux/falloc.h>
> >=20
> > Currently there is a bug filed in glibc here for the exact same kernel =
version.
> > https://bugzilla.redhat.com/show_bug.cgi?id=3D1476120
>=20
> The man page says: "The FALLOC_FL_* flags are defined in glibc headers
> only since version 2.18."
>=20
> I guess we can workaround with a direct include.

=46ixed and rebased
Tested by David, thanks