From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1axxT3-0002nV-Fp
	for qemu-devel@nongnu.org; Wed, 04 May 2016 10:08:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1axxSr-0004fy-UJ
	for qemu-devel@nongnu.org; Wed, 04 May 2016 10:07:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1axxSr-0004bX-PP
	for qemu-devel@nongnu.org; Wed, 04 May 2016 10:07:45 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 88A3262678
	for <qemu-devel@nongnu.org>; Wed,  4 May 2016 14:07:34 +0000 (UTC)
References: <1461879932-9020-1-git-send-email-eblake@redhat.com>
	<87twik3bx4.fsf@dusky.pond.sub.org> <572350A5.6050208@redhat.com>
	<87lh3wy32b.fsf@dusky.pond.sub.org> <57236AFD.7010702@redhat.com>
	<87y47qlyi2.fsf@dusky.pond.sub.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <572A0225.4070201@redhat.com>
Date: Wed, 4 May 2016 08:07:33 -0600
MIME-Version: 1.0
In-Reply-To: <87y47qlyi2.fsf@dusky.pond.sub.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="hKnNE4Hj6omoU7q8mBf0fjT92oClnlJA4"
Subject: Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups
 (post-introspection cleanups subset E)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--hKnNE4Hj6omoU7q8mBf0fjT92oClnlJA4
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 05/04/2016 07:54 AM, Markus Armbruster wrote:
> Uh, in visitor.h at the end of this series:
>=20
>  * <example>
>  *  Visitor *v;
>  *  Error *err =3D NULL;
>  *  int value;
>  *
>  *  v =3D ...obtain visitor...
>  *  visit_start_struct(v, NULL, NULL, 0, &err);
>  *  if (err) {
> --->    goto outobj;

>  * outobj:
>  *  visit_end_struct(v);
>  *  error_propagate(errp, err);
>  *  ...clean up v...
>  * </example>
>=20
> The ---> goto is wrong; we call visit_end_struct() after
> visit_start_struct() failed.  Haven't dug through the patches to find
> the guilty one.
>=20

Fairly easy fix, and only affects doc (patch 12/24 introduced it). I've
sent a fixup that you can squash in, since qapi-next is not merged to
master yet.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--hKnNE4Hj6omoU7q8mBf0fjT92oClnlJA4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXKgIlAAoJEKeha0olJ0NqvSkH/1CcJPB0GL3juhFY6OEZDvTC
PwMUljAOpivsRhBUZM5o0xdzeUbRu2wqcNDfP46XA9nGkTZpEw3XAB6SeTX3oFjp
jis10NNuwTSi2090F95ODOInW+kFa9VFcHQh2iGt0fgT9V4w6IMRcRWObwjo4jHl
Q0KxsQqEu55QPwhTfJq7SgcXQ5Vyx+aQxQPffQqadLi8h9klvBxDX0BWfD+CHiKq
VikOOZTZ9wpgCcd5l+tPqgQtbUcMC9uYgyeUC7s6jmzZevSEqlgcaDB3gDmn5b2+
Z5VAeFCZ9Q2ufszIU5NZIjRUkmOOv1Jo1CpPCb3UdBPO55noWN6C2LzhkIoYV7g=
=Upxf
-----END PGP SIGNATURE-----

--hKnNE4Hj6omoU7q8mBf0fjT92oClnlJA4--