From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757188AbcEEOuG (ORCPT ); Thu, 5 May 2016 10:50:06 -0400 Received: from foss.arm.com ([217.140.101.70]:50353 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754807AbcEEOuE (ORCPT ); Thu, 5 May 2016 10:50:04 -0400 Subject: Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver. To: "majun (F)" , Thomas Gleixner References: <1458203641-17172-1-git-send-email-majun258@huawei.com> <56F0B7C3.8070001@huawei.com> Cc: Catalin.Marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com, mark.rutland@arm.com, jason@lakedaemon.net, lizefan@huawei.com, huxinwei@huawei.com, dingtianhong@huawei.com, liguozhu@hisilicon.com, guohanjun@huawei.com, zhaojunhua@hisilicon.com From: Marc Zyngier Organization: ARM Ltd Message-ID: <572B5D97.4090004@arm.com> Date: Thu, 5 May 2016 15:49:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <56F0B7C3.8070001@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/03/16 03:10, majun (F) wrote: > > > 在 2016/3/21 18:29, Thomas Gleixner 写道: >> On Thu, 17 Mar 2016, MaJun wrote: >>> This patch set is used to fix the problem of remap a set of registers >>> repeatedly in current mbigen driver. >>> >>> irqchip/mbigen:Change the mbigen node definition in dt binding file >>> irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition >> >> These subject lines are still horrible as they tell nothing about the nature >> of the change. I fixed them up along with the changelogs and applied them to >> irq/urgent. Can you spot the difference? > > Yes, after you changing, the subject and change log clearly show why we need to > do this change. > I have learned a lot from you :) > >> >> While at it. The config switch for this driver is horrible. It's just in the >> middle of the device driver configs. Why is this configurable by the user at >> all? It simply should be selected by arm64 or some subarch configuration >> there. Please clean that up. >> > will do. So what's the status of this? Do you still plan to respin it? Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Thu, 5 May 2016 15:49:59 +0100 Subject: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver. In-Reply-To: <56F0B7C3.8070001@huawei.com> References: <1458203641-17172-1-git-send-email-majun258@huawei.com> <56F0B7C3.8070001@huawei.com> Message-ID: <572B5D97.4090004@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22/03/16 03:10, majun (F) wrote: > > > ? 2016/3/21 18:29, Thomas Gleixner ??: >> On Thu, 17 Mar 2016, MaJun wrote: >>> This patch set is used to fix the problem of remap a set of registers >>> repeatedly in current mbigen driver. >>> >>> irqchip/mbigen:Change the mbigen node definition in dt binding file >>> irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition >> >> These subject lines are still horrible as they tell nothing about the nature >> of the change. I fixed them up along with the changelogs and applied them to >> irq/urgent. Can you spot the difference? > > Yes, after you changing, the subject and change log clearly show why we need to > do this change. > I have learned a lot from you :) > >> >> While at it. The config switch for this driver is horrible. It's just in the >> middle of the device driver configs. Why is this configurable by the user at >> all? It simply should be selected by arm64 or some subarch configuration >> there. Please clean that up. >> > will do. So what's the status of this? Do you still plan to respin it? Thanks, M. -- Jazz is not dead. It just smells funny...