From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757888AbcEFG2z (ORCPT ); Fri, 6 May 2016 02:28:55 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:55524 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbcEFG2x (ORCPT ); Fri, 6 May 2016 02:28:53 -0400 X-AuditID: cbfec7f5-f792a6d000001302-b2-572c39a12cca Subject: Re: [RFC v2 13/13] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3 To: Javier Martinez Canillas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-14-git-send-email-k.kozlowski@samsung.com> <9dff13ae-5863-2b45-0e6a-00b345a19019@osg.samsung.com> Cc: tjakobi@math.uni-bielefeld.de, m.szyprowski@samsung.com, hverkuil@xs4all.nl, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <572C39A0.8030701@samsung.com> Date: Fri, 06 May 2016 08:28:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <9dff13ae-5863-2b45-0e6a-00b345a19019@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t/xa7oLLXXCDVZvUrDYOGM9q8XUh0/Y LCY9ec9sMf/IOVaLiSsnM1s0L17PZnFq8jMmizdv1zBZvH5haLHp8TVWi8u75rBZHPnfz2jx ufcIo8WM8/uYLBYta2W2WHvkLrvF6d0lFm2rP7BaHF8b7iDssXPWXXaPzSu0PDat6mTzuHNt D5vH/rlrgEJL6j3+HWP32NIPlO/bsorR4/MmOY9TXz+zB3BHcdmkpOZklqUW6dslcGUcfviF sWA7d8X5RRoNjDM5uxg5OSQETCR+Nn5khbDFJC7cW88GYgsJLGWU2Nvs1MXIBWQ/Y5Ro3/6Q sYuRg0NYIEdi13RLkLiIQC+LxIVz55kgGvYzSpxqZAVJMAu0M0psPbUbbBKbgLHE5uVLwGxe AS2JRzM6mUFsFgFViRe/zrGA2KICERKr111jhqgRlPgx+R5YnFPAWaJ/9Wx2kMXMAnoS9y9q gYSZBeQlNq95yzyBUWAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRES iV93MC49ZnWIUYCDUYmHN+OkdrgQa2JZcWXuIUYJDmYlEV5VM51wId6UxMqq1KL8+KLSnNTi Q4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBKNTAeDN7HaJ5R7f3ydP3nD1UXjj/7VjJB zlE+QHDHm+nNuv2GrrLyopPafF9n/WgR+a4elpY2KW//mva+gquNvi/jrC06Hi+WTryy8qn0 QZmMG3OrD7v6zg+6toGvINS67gX7zvu29sotgv9uiYtyfEoz964vcrtn9/any6w1fCkaHkfW 695+JaDEUpyRaKjFXFScCACD6wmFwAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2016 10:16 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> On Odroid U3 (Exynos4412-based) board if USB was initialized by >> bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) >> and LAN (smsc95xx) after after successful probing were not visible in the >> system ("lsusb"). >> >> In such case the devices had to be fully reset before configuring. >> Reset by GPIO (called RESET_N pin) and by RESET field in STCD register >> in usb3503 HUB are not sufficient. Instead full reset has to be done by >> disabling and enabling regulator. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> >> + lan_pwrseq: pwrseq2 { >> + compatible = "mmc-pwrseq-simple"; > > It feels strange to have a "mmc-pwrseq-simple" compatible for a USB power > sequence provider. As I mentioned in the other patch, I think there should > either be a DT binding for the USB pwrseq-simple with a "usb-pwrseq-simple" > compatible that binds to the same pwrseq-simple driver or maybe having a > generic DT binding for any device with a new "pwrseq-simple" compatible. > > Patch looks good to me though, so after having a DT binding and changing > the compatible string: > > Reviewed-by: Javier Martinez Canillas Probably this will change after Rob's feedback. :) Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 06 May 2016 08:28:48 +0200 Subject: [RFC v2 13/13] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3 In-Reply-To: <9dff13ae-5863-2b45-0e6a-00b345a19019@osg.samsung.com> References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-14-git-send-email-k.kozlowski@samsung.com> <9dff13ae-5863-2b45-0e6a-00b345a19019@osg.samsung.com> Message-ID: <572C39A0.8030701@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/05/2016 10:16 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> On Odroid U3 (Exynos4412-based) board if USB was initialized by >> bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) >> and LAN (smsc95xx) after after successful probing were not visible in the >> system ("lsusb"). >> >> In such case the devices had to be fully reset before configuring. >> Reset by GPIO (called RESET_N pin) and by RESET field in STCD register >> in usb3503 HUB are not sufficient. Instead full reset has to be done by >> disabling and enabling regulator. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> >> + lan_pwrseq: pwrseq2 { >> + compatible = "mmc-pwrseq-simple"; > > It feels strange to have a "mmc-pwrseq-simple" compatible for a USB power > sequence provider. As I mentioned in the other patch, I think there should > either be a DT binding for the USB pwrseq-simple with a "usb-pwrseq-simple" > compatible that binds to the same pwrseq-simple driver or maybe having a > generic DT binding for any device with a new "pwrseq-simple" compatible. > > Patch looks good to me though, so after having a DT binding and changing > the compatible string: > > Reviewed-by: Javier Martinez Canillas Probably this will change after Rob's feedback. :) Best regards, Krzysztof