From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH V2 13/14] dt-bindings: arm-gic: Add documentation for Tegra210 AGIC Date: Fri, 6 May 2016 09:32:38 +0100 Message-ID: <572C56A6.7020408@nvidia.com> References: <1461150237-15580-1-git-send-email-jonathanh@nvidia.com> <1461150237-15580-14-git-send-email-jonathanh@nvidia.com> <20160422100052.GA10606@leverpostej> <571A0739.3090502@nvidia.com> <20160422112239.GF10606@leverpostej> <5720DC1D.1080802@nvidia.com> <20160427173810.GC7359@leverpostej> <5721C597.1010105@nvidia.com> <20160428095525.GB21145@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160428095525.GB21145@leverpostej> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Mark, On 28/04/16 10:55, Mark Rutland wrote: [...] > The "nvidia,tegra210-agic" string can be taken as describing any > Tegra-210 specific integration quirks, though I agree that's also not > fantastic for extending PM support beyond Tegra 210 and variants > thereof. > > So maybe the best approach is bailing out in the presence of clocks > and/or power domains after all, on the assumption that nothing today has > those properties, though I fear we may have problems with that later > down the line if/when people describe those for the root GIC to describe > those must be hogged, even if not explicitly managed. On further testing, by bailing out in the presence of clocks and/or power-domains, the problem I now see is that although the primary gic-400 has been registered, we still try to probe it again later as it matches the platform driver. One way to avoid this would be ... diff --git a/drivers/of/irq.c b/drivers/of/irq.c index e7bfc175b8e1..631da7ad0dbf 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -556,6 +556,8 @@ void __init of_irq_init(const struct of_device_id *matches) * its children can get processed in a subsequent pass. */ list_add_tail(&desc->list, &intc_parent_list); + + of_node_set_flag(desc->dev, OF_POPULATED); } If this is not appropriate then I guess I will just need to use "tegra210-agic" for the compatibility flag. Cheers Jon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758054AbcEFIct (ORCPT ); Fri, 6 May 2016 04:32:49 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:2962 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbcEFIcq (ORCPT ); Fri, 6 May 2016 04:32:46 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 06 May 2016 01:32:03 -0700 Subject: Re: [PATCH V2 13/14] dt-bindings: arm-gic: Add documentation for Tegra210 AGIC To: Mark Rutland References: <1461150237-15580-1-git-send-email-jonathanh@nvidia.com> <1461150237-15580-14-git-send-email-jonathanh@nvidia.com> <20160422100052.GA10606@leverpostej> <571A0739.3090502@nvidia.com> <20160422112239.GF10606@leverpostej> <5720DC1D.1080802@nvidia.com> <20160427173810.GC7359@leverpostej> <5721C597.1010105@nvidia.com> <20160428095525.GB21145@leverpostej> CC: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , , , , From: Jon Hunter Message-ID: <572C56A6.7020408@nvidia.com> Date: Fri, 6 May 2016 09:32:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160428095525.GB21145@leverpostej> X-Originating-IP: [10.21.132.133] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 28/04/16 10:55, Mark Rutland wrote: [...] > The "nvidia,tegra210-agic" string can be taken as describing any > Tegra-210 specific integration quirks, though I agree that's also not > fantastic for extending PM support beyond Tegra 210 and variants > thereof. > > So maybe the best approach is bailing out in the presence of clocks > and/or power domains after all, on the assumption that nothing today has > those properties, though I fear we may have problems with that later > down the line if/when people describe those for the root GIC to describe > those must be hogged, even if not explicitly managed. On further testing, by bailing out in the presence of clocks and/or power-domains, the problem I now see is that although the primary gic-400 has been registered, we still try to probe it again later as it matches the platform driver. One way to avoid this would be ... diff --git a/drivers/of/irq.c b/drivers/of/irq.c index e7bfc175b8e1..631da7ad0dbf 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -556,6 +556,8 @@ void __init of_irq_init(const struct of_device_id *matches) * its children can get processed in a subsequent pass. */ list_add_tail(&desc->list, &intc_parent_list); + + of_node_set_flag(desc->dev, OF_POPULATED); } If this is not appropriate then I guess I will just need to use "tegra210-agic" for the compatibility flag. Cheers Jon