From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757850AbcEFJLN (ORCPT ); Fri, 6 May 2016 05:11:13 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:42857 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbcEFJLM (ORCPT ); Fri, 6 May 2016 05:11:12 -0400 Subject: Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver. To: Marc Zyngier , Thomas Gleixner References: <1458203641-17172-1-git-send-email-majun258@huawei.com> <56F0B7C3.8070001@huawei.com> <572B5D97.4090004@arm.com> <572BEF97.5020003@huawei.com> <572C4883.20106@arm.com> CC: , , , , , , , , , , , From: "majun (F)" Message-ID: <572C5EC4.4010204@huawei.com> Date: Fri, 6 May 2016 17:07:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <572C4883.20106@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.235.245] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.572C5EE7.011B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f1ef7f8aea03fe238a1c993a1aa65d9b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc: 在 2016/5/6 15:32, Marc Zyngier 写道: > On 06/05/16 02:12, majun (F) wrote: >> Hi Marc: >> >> 在 2016/5/5 22:49, Marc Zyngier 写道: >>> On 22/03/16 03:10, majun (F) wrote: >>>> >>>> >>>> 在 2016/3/21 18:29, Thomas Gleixner 写道: >>>>> On Thu, 17 Mar 2016, MaJun wrote: >>>>>> This patch set is used to fix the problem of remap a set of registers >>>>>> repeatedly in current mbigen driver. >>>>>> >>>>>> irqchip/mbigen:Change the mbigen node definition in dt binding file >>>>>> irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition >>>>> >>>>> These subject lines are still horrible as they tell nothing about the nature >>>>> of the change. I fixed them up along with the changelogs and applied them to >>>>> irq/urgent. Can you spot the difference? >>>> >>>> Yes, after you changing, the subject and change log clearly show why we need to >>>> do this change. >>>> I have learned a lot from you :) >>>> >>>>> >>>>> While at it. The config switch for this driver is horrible. It's just in the >>>>> middle of the device driver configs. Why is this configurable by the user at >>>>> all? It simply should be selected by arm64 or some subarch configuration >>>>> there. Please clean that up. >>>>> >>>> will do. >>> >>> So what's the status of this? Do you still plan to respin it? >>> >> >> This patch set had been ACK by Thomas. > > Interesting. Somehow, the ARM email server has decided not to deliver > the tip-bot messages, so I didn't see it was already in. > > Sorry for the noise. Not at all. Thank you for your attention. MaJun Thanks! > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: majun258@huawei.com (majun (F)) Date: Fri, 6 May 2016 17:07:16 +0800 Subject: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver. In-Reply-To: <572C4883.20106@arm.com> References: <1458203641-17172-1-git-send-email-majun258@huawei.com> <56F0B7C3.8070001@huawei.com> <572B5D97.4090004@arm.com> <572BEF97.5020003@huawei.com> <572C4883.20106@arm.com> Message-ID: <572C5EC4.4010204@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marc: ? 2016/5/6 15:32, Marc Zyngier ??: > On 06/05/16 02:12, majun (F) wrote: >> Hi Marc: >> >> ? 2016/5/5 22:49, Marc Zyngier ??: >>> On 22/03/16 03:10, majun (F) wrote: >>>> >>>> >>>> ? 2016/3/21 18:29, Thomas Gleixner ??: >>>>> On Thu, 17 Mar 2016, MaJun wrote: >>>>>> This patch set is used to fix the problem of remap a set of registers >>>>>> repeatedly in current mbigen driver. >>>>>> >>>>>> irqchip/mbigen:Change the mbigen node definition in dt binding file >>>>>> irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition >>>>> >>>>> These subject lines are still horrible as they tell nothing about the nature >>>>> of the change. I fixed them up along with the changelogs and applied them to >>>>> irq/urgent. Can you spot the difference? >>>> >>>> Yes, after you changing, the subject and change log clearly show why we need to >>>> do this change. >>>> I have learned a lot from you :) >>>> >>>>> >>>>> While at it. The config switch for this driver is horrible. It's just in the >>>>> middle of the device driver configs. Why is this configurable by the user at >>>>> all? It simply should be selected by arm64 or some subarch configuration >>>>> there. Please clean that up. >>>>> >>>> will do. >>> >>> So what's the status of this? Do you still plan to respin it? >>> >> >> This patch set had been ACK by Thomas. > > Interesting. Somehow, the ARM email server has decided not to deliver > the tip-bot messages, so I didn't see it was already in. > > Sorry for the noise. Not at all. Thank you for your attention. MaJun Thanks! > > M. >