From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204AbcEINB3 (ORCPT ); Mon, 9 May 2016 09:01:29 -0400 Received: from mail-am1on0142.outbound.protection.outlook.com ([157.56.112.142]:65072 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751536AbcEINB1 (ORCPT ); Mon, 9 May 2016 09:01:27 -0400 Authentication-Results: kvack.org; dkim=none (message not signed) header.d=none;kvack.org; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH v2 1/2] mm, kasan: improve double-free detection To: "Luruo, Kuthonuzo" , "glider@google.com" , "dvyukov@google.com" , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" References: <20160506114727.GA2571@cherokee.in.rdlabs.hpecorp.net> <573065BD.2020708@virtuozzo.com> <20E775CA4D599049A25800DE5799F6DD1F627919@G4W3225.americas.hpqcorp.net> CC: "kasan-dev@googlegroups.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" From: Andrey Ryabinin Message-ID: <57308A20.2050501@virtuozzo.com> Date: Mon, 9 May 2016 16:01:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20E775CA4D599049A25800DE5799F6DD1F627919@G4W3225.americas.hpqcorp.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [84.47.128.244] X-ClientProxiedBy: AM3PR08CA0006.eurprd08.prod.outlook.com (10.160.207.144) To DB6PR0801MB1302.eurprd08.prod.outlook.com (10.168.11.20) X-MS-Office365-Filtering-Correlation-Id: 1dff1455-70ce-43ee-ee01-08d3780a061d X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;2:9qbB9L4fQ4gsu3fUY1LhxXqv0bEEFNC9F2H/d07WEPyibCTmw6pA+RcnY1nR8mVF4vzlP9VK7xpAJ1nqco/DqFEmoG5z7itBgBZRHyd38unYCBNIWse4u2hHTy9CKOpZW2KBS/aDkVrGcc0ayw4ZSROqmS66Cks/v0Ead+KeKPCFnfQQ+IYih//3RG4rMbaP;3:fbcRsiasMoNBTlI3KDP3F6gteIbu2SwDAt86RixIrgMaccH09v3/DJ8YtgP5c3yRFIT3zmQ75JxWCMKOK7a4WlawApm823/Gqc0Jq7g28RBhhPYo0ggKYtqW09EaUdBQ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1302; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;25:zLWrKP0fW0V2i/36GlURELn8qdQiRrKKdOCvLeyYt7t4Uy2fBTZ5betlkiY8bzK3GygmX1SUXDPOv/leplHdxSK27DTua6EHyyGuLu+rF0HDgKL2TgCU5SiKycuFTACTGk8VefdydrbKXUZVxXicC3V89VgUUAKVFk1aBmCwqACOBJ4dFg5cJSG8pDA0HcudJ4iTgi3VYdIKGkS0JF+ef/jgywYIiUEhpQCXB6qDM7lW59IETTlFnlZf5iVd5PGKUvBCytxd8r5TXeN7qWuLidJL6DRF9pyv26KuDjFZpnE8Il+MSpZcvqbT2EnW64YWBmLeI4QY+wV/UFFaNvckC6k8h14ZbSMCAnLJCBH1fqyw/W+Vm6LHnAh5jVDhZXyu2rRPfLM3B8IExiQjgZKhido/wuRySaLbrOWUc7SJYvzSNqznRC+OQrz/iudXycH81bNfA14j3DiYNbM/mm6wfIx2sR9MCOkfcS9P/t9LRbF9swv+PipZ0IFqO/TRITr78tO2wYl49s0MZpu7yuj2dIysf+uR9ZNTyvrh91WQm4GP3hglzUaAAb/t5bkhJCkIeEI2sA+Gt+QQ1QBsyzXnee1qLmH4TLk4z/3/JmSzEjELhYn22ibOPWqV2EVUNtu1zl/2+qplkx6MEQvdBN60EqTzivTkKdbUrzv+ZbjHaAkJUkKKfUB45iCtu9ln7iaw1xbldYEwp8LW6TG4wLPzBuu3pXJi4C3HMBobH7/XOIA8BM0fsqKD4D5DUrSLxAxkRG9TxQ4ue3P9LOrLqQdPuQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:DB6PR0801MB1302;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1302; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;4:4Y0m56iEoqYfKR3Iks7GQAas1bWATra59B2KeAFddXgdvNScFmOeu8FjglJ2UT03X8kB+ekGxhtLCmpwdxm4rD/NN/ZFjrl9+2mXHOqp3H+ZrQxcjOPSfGQlThJpyUBkA8Qt4qKJz0x43yRA4uEudx4JuROfOI4EfJAYdgR8V5UbwXgaf6ehtl5Olug0zutPLPhkSVSP+xVh9ySaOm1mlHdPA1FN7MzCcQ07skwhJQA2DniNDNqZXy7GNwiQ6n8jNPFfoe6ZgwOFx9t1Ii/zGtlvTwyZgfM9B2ELmeEITMYsR+hWFVbAbOzorRGlL3lPHG56Csnlx/OtdceIosbIn8ZRy/s+d0//iVCRWSL52u4bV93MFAI5trB89X5hYtzEPAQwN8/HBUU8rmyRCRFeGB0n30mAGRjUm6KxVZEfji4= X-Forefront-PRVS: 0937FB07C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(24454002)(377454003)(9170700001)(5008740100001)(42186005)(4326007)(66066001)(87266999)(65956001)(65816999)(50466002)(92566002)(23676002)(47776003)(2501003)(230700001)(81166005)(6116002)(3846002)(189998001)(2950100001)(33656002)(586003)(76176999)(77096005)(50986999)(4001350100001)(54356999)(99136001)(5004730100002)(86362001)(5001770100001)(36756003)(2201001)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB1302;H:[10.52.82.2];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDFNQjEzMDI7MjM6YnJWeHlqam16aTlWTmlva1FkNjZLQU5m?= =?utf-8?B?QmQ0QVFJYXhrZ2R5NEI1YVJxTmNMMWpZMVpaTDcrbnY2bGYxZ2NQa05GMnE4?= =?utf-8?B?SUZ1VUpicTlXR1IyZkZvcUsrT0ozV2lsVGk3RWxkVTM1a1NFdXM0TWlJaG0r?= =?utf-8?B?bXZoQ2V0K0w0U0ZiekFpei9Ob20vK1E2SVNNWVQzc0d4ejRza1ZDYnZ5LzF0?= =?utf-8?B?SklTUXNqRmpNeDVXbzFWMTdVTVZNb0JYNk1Qc3NlZXErbGplVUtNUTNUZE9q?= =?utf-8?B?bS8ycDdFbEViWlZNT2VNM0cxZEZ3Z091cWs4Ukt3aWxOcHZwUnJxTk9nYmNX?= =?utf-8?B?ZkdRY05Sc2docHIvTXBlNm1wei9UVEZ0RjlpVmRFdnRQNGJjUk1rNXZqVHpX?= =?utf-8?B?RWl6WDRwQXphQ0IrRjF0WE4rayt5YUZLNDN2cEpaTHpraDZUY2RsK3pXWmg2?= =?utf-8?B?eFREVm9vVTVjWjB4SDR6WHVKeWwxNzluMDZPRnIxczZoM25ucWQyemF6ZkFu?= =?utf-8?B?Y1QxK0tLNEtGOU9EYzBPYjhnWDBQYlo4WFdrQ0pnakk2Ri9zVmw4OGhmRVJW?= =?utf-8?B?QThTelliTUlOUm82OHpZQUIrY0RBOSs0dDJhbHk5aGJRSTh6emRyUFBabVVv?= =?utf-8?B?S3F2c2JtQU5EZmw1cW41NU1QVENTOXl1Tkp5bDVQVU82bHp5Sm9hcDBZQ0hk?= =?utf-8?B?M095RDhON2FOQ2QyemtwM3VQRXhBY2hwNVRMWlNGbFYyK0VUUit2Z2tSZ1lk?= =?utf-8?B?cTN4eFA3YllGTmtpOWVicU1UNWJqb3JoSSt2L01YV0I5OTZPeXVoSTQ0TlMw?= =?utf-8?B?SFRweThIejZZR2R3YXBOZWpjUVJtb3pRQUxDLzFRcThFWlNURm9pM1M3eWtE?= =?utf-8?B?L1VGNmVOR2NheHRoKyttWjZkUkhSQm1wUTkzM0lIb2lCUnoxYVRQWnRZcXZF?= =?utf-8?B?aTBmQ0J5cU5VY09hMnZ1OVRkeVk3K2dZOXNvNWt2MmRsVnVEZmVDekxZMDZw?= =?utf-8?B?UzFqYnMxUWR3d05mcTRSSStqclVIbm5KN2RBQTU2RWI4cEJwV1VhdS9EblVD?= =?utf-8?B?VXFOdWdqYUZVTyt1TC9zbGhtaWg1QW5mK0h6VEg0NlN1QXdQbEdUT1V6bTF0?= =?utf-8?B?Q0ZPS2RqdGluUnlxWjR4Tmg2WGE5VDdWQ29PWGpiR0JBSC9ibVJYSTAyQWwv?= =?utf-8?B?bkhUVTZiK1V1YnN4VUptc20vUDlTYUg5b2g5b0ZLSU9LaUw4YUZPZTcrMUZY?= =?utf-8?B?UWVHN3l5aEF2USt6UGxJeENaSnJraXlvYTJYNGRqbXV2ekhDWmhJeURTYzZS?= =?utf-8?B?a0xtT2RYU3p4L3krU25saExIY1VXVm9UNEg3eHpuZXhmb1JqaE9WMTE3Y0pK?= =?utf-8?B?TEFobnZpTy9NWWlSNndMcmY3RlJ1N3VveGwzc25TdHc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;5:ZDGPfS4dWyM1CkUrtcjWCT32QyTR1nb8SfjbFgSDCkM8g7FpDkIOgyVC59dW/BtPCwXo82uwkTbA+7VhrbAznDcEN4xncDvv4/Teui+i2496Z/1BTT5a8A3dXugWjv6b+sV1S8kQbdu++dGePsJ4dQ==;24:ev76YGwu9AZp8sLbgwhc0tvsL1v57moB+QnUEnhcN14mC7ZiQrLVxov5h0yynNVnCGP57VFr2zfst4f+ik3KEhJddtiwan2h/ODaLNxc300=;7:lLlJV9fpVUs0s75gEbhlmghSBFsOEak79+CY6bZ7S6sEoDcq/j5Bc9oCajsloV8bedVABLVVFmUnK1vd9JK49uhoQJanOkFe6AFlV9ya9Sl6H7/UdFaqJlLku5YvTogMMPbbCtsIaTNd8PkN/4qCrtb3s4p7TfwOBnYAja3u/vgRGwxBHeMdPNdfXxAkGcmN;20:3BzsZ4GEq7YXKWHImmzcBd3so1lBaGpZLKywopsX4aZv0rvo1Q4erjJnOqKrlYAdZ7pdICqAFYeYlGCTbsEf6UEGmdxTyYFepoIFToBOD81NdCjpxN2dYlHIaayVmrrEb6/jcV9R1RJ+9HL+r0KA85ef1O1OmJ6Jgpyn5eyivXM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2016 13:01:22.7314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1302 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2016 02:35 PM, Luruo, Kuthonuzo wrote: > > This patch with atomic bit op is similar in spirit to v1 except that it increases metadata size. > I don't think that this is a big deal. That will slightly increase size of objects <= (128 - 32) bytes. And if someone think otherwise, we can completely remove 'alloc_size' (we use it only to print size in report - not very useful). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f198.google.com (mail-ig0-f198.google.com [209.85.213.198]) by kanga.kvack.org (Postfix) with ESMTP id 9BD286B025E for ; Mon, 9 May 2016 09:01:34 -0400 (EDT) Received: by mail-ig0-f198.google.com with SMTP id kj7so242765408igb.3 for ; Mon, 09 May 2016 06:01:34 -0700 (PDT) Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0120.outbound.protection.outlook.com. [157.56.112.120]) by mx.google.com with ESMTPS id s131si12082168oie.110.2016.05.09.06.01.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 May 2016 06:01:25 -0700 (PDT) Subject: Re: [PATCH v2 1/2] mm, kasan: improve double-free detection References: <20160506114727.GA2571@cherokee.in.rdlabs.hpecorp.net> <573065BD.2020708@virtuozzo.com> <20E775CA4D599049A25800DE5799F6DD1F627919@G4W3225.americas.hpqcorp.net> From: Andrey Ryabinin Message-ID: <57308A20.2050501@virtuozzo.com> Date: Mon, 9 May 2016 16:01:20 +0300 MIME-Version: 1.0 In-Reply-To: <20E775CA4D599049A25800DE5799F6DD1F627919@G4W3225.americas.hpqcorp.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Luruo, Kuthonuzo" , "glider@google.com" , "dvyukov@google.com" , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" Cc: "kasan-dev@googlegroups.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" On 05/09/2016 02:35 PM, Luruo, Kuthonuzo wrote: > > This patch with atomic bit op is similar in spirit to v1 except that it increases metadata size. > I don't think that this is a big deal. That will slightly increase size of objects <= (128 - 32) bytes. And if someone think otherwise, we can completely remove 'alloc_size' (we use it only to print size in report - not very useful). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org