From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbcEIPPc (ORCPT ); Mon, 9 May 2016 11:15:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbcEIPPb (ORCPT ); Mon, 9 May 2016 11:15:31 -0400 Subject: Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <20160505082423.GB534@pd.tnic> <573097F2.1090406@redhat.com> <20160509144712.GB7809@potion> Cc: Borislav Petkov , Brooks Moses , linux-kernel@vger.kernel.org, Ian Kasprzak From: Paolo Bonzini Message-ID: <5730A98F.3080405@redhat.com> Date: Mon, 9 May 2016 17:15:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160509144712.GB7809@potion> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 09 May 2016 15:15:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2016 16:47, Radim Krčmář wrote: > 2016-05-09 16:00+0200, Paolo Bonzini: >> On 05/05/2016 10:24, Borislav Petkov wrote: >>> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote: >>>> When I run "make ARCH=x86 headers_install", and then write a simple C >>>> file that #includes "asm/kvm.h" from the resulting tree, I get a >>>> compiler error: the BIT() macro used on line 219 of that file is >>>> undefined: >>> >>> The below patch should help... >>> >>> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in >>> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in >>> stone? >> >> Unfortuntely it is cast in stone. The patch below is good though. > > We can "fix" it by introducing a second name for the entry. Do you > think it's worth? I don't think so, but perhaps there are precedents for doing that? >> Radim, please commit it >> (http://article.gmane.org/gmane.linux.kernel/2215443/raw) or pass the >> tree back to me so that I can. :) > > I've committed the patch. The tree is yours now -- there probably is a > lot I missed ... No problem, I "only" have 1300 messages to go in my inbox but I'll take a closer look at those that you didn't reply to. Thanks, Paolo