From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbcEJHo7 (ORCPT ); Tue, 10 May 2016 03:44:59 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:34516 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbcEJHkC (ORCPT ); Tue, 10 May 2016 03:40:02 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: wulf@rock-chips.com X-FST-TO: balbi@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wulf@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57319045.9050907@rock-chips.com> Date: Tue, 10 May 2016 15:39:49 +0800 From: William Wu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Felipe Balbi , Doug Anderson CC: Greg Kroah-Hartman , =?ISO-8859-1?Q?Heiko?= =?ISO-8859-1?Q?_St=FCbner?= , Brian Norris , Kever Yang , Tao Huang , frank.wang@rock-chips.com, Eddie Cai , John Youn , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip References: <1462794377-6528-1-git-send-email-william.wu@rock-chips.com> <1462794377-6528-2-git-send-email-william.wu@rock-chips.com> <8737pq8jvi.fsf@linux.intel.com> In-Reply-To: <8737pq8jvi.fsf@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Felipe & Doug, Thanks for your proposal. It's a good idea to sort the list. I'll fix it next patch version. On 05/10/2016 03:14 PM, Felipe Balbi wrote: > Hi, > > Doug Anderson writes: >> William, >> >> On Mon, May 9, 2016 at 4:46 AM, William Wu wrote: >>> Signed-off-by: William Wu >>> --- >>> drivers/usb/dwc3/dwc3-of-simple.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c >>> index 9743353..1f3665b 100644 >>> --- a/drivers/usb/dwc3/dwc3-of-simple.c >>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c >>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { >>> static const struct of_device_id of_dwc3_simple_match[] = { >>> { .compatible = "qcom,dwc3" }, >>> { .compatible = "xlnx,zynqmp-dwc3" }, >>> + { .compatible = "rockchip,dwc3" }, >> It is, of course, up to Felipe. ...but personally I'd prefer that >> things here be sorted alphabetically. Sorting things in a consistent >> manner tends to reduce merge conflicts as the list gets longer and >> also makes it easier to find things. > I agree, let's keep it sorted :-) >