From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbcEKOvA (ORCPT ); Wed, 11 May 2016 10:51:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:52149 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbcEKOu7 (ORCPT ); Wed, 11 May 2016 10:50:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,608,1455004800"; d="scan'208";a="101290749" Subject: Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES To: Yu-cheng Yu , linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar References: <33faa9b05447cd1b5bee02b1292249df7951b433.1462914897.git.yu-cheng.yu@intel.com> Cc: Andy Lutomirski , Borislav Petkov , Sai Praneeth Prakhya , "Ravi V. Shankar" , Fenghua Yu From: Dave Hansen Message-ID: <573346D0.7040508@linux.intel.com> Date: Wed, 11 May 2016 07:50:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <33faa9b05447cd1b5bee02b1292249df7951b433.1462914897.git.yu-cheng.yu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2016 04:29 PM, Yu-cheng Yu wrote: > XSAVES uses compacted format and is a kernel instruction. The kernel > should use standard-format, non-supervisor state data for PTRACE. > > Signed-off-by: Yu-cheng Yu This looks fine. There are a few comments that could use some sprucing up, like: + /* + * Reject if the user sets any forbidden features. + */ But it's minor stuff. Reviewed-by: Dave Hansen