From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] qede: fix icc build error
Date: Wed, 11 May 2016 18:17:20 +0100
Message-ID: <57336920.5060409@intel.com>
References: <1462879407-27649-1-git-send-email-ferruh.yigit@intel.com>
 <D3578A37.18DDD%harish.patil@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Rasesh Mody <rasesh.mody@qlogic.com>, Sony Chacko <sony.chacko@qlogic.com>
To: Harish Patil <harish.patil@qlogic.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 6EA67677C
 for <dev@dpdk.org>; Wed, 11 May 2016 19:17:23 +0200 (CEST)
In-Reply-To: <D3578A37.18DDD%harish.patil@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/10/2016 9:02 PM, Harish Patil wrote:
> Hi Ferruh,
>=20
>> fix errors:
>> icc: command line warning #10006: ignoring unknown option
>> '-Wno-unused-value'
>> icc: command line warning #10006: ignoring unknown option
>> '-Wno-format-nonliteral'
>> icc: command line warning #10006: ignoring unknown option
>> '-Wno-shift-negative-value'
>> qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with
>> another type
>>        return 0;
>>               ^
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> drivers/net/qede/Makefile | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
>> index 47e01be..d0c1361 100644
>> --- a/drivers/net/qede/Makefile
>> +++ b/drivers/net/qede/Makefile
>> @@ -27,7 +27,6 @@ OS_TYPE :=3D $(shell uname -s)
>> # CFLAGS
>> #
>> CFLAGS_BASE_DRIVER =3D -Wno-unused-parameter
>> -CFLAGS_BASE_DRIVER +=3D -Wno-unused-value
>> CFLAGS_BASE_DRIVER +=3D -Wno-sign-compare
>> CFLAGS_BASE_DRIVER +=3D -Wno-missing-prototypes
>> CFLAGS_BASE_DRIVER +=3D -Wno-cast-qual
>> @@ -35,12 +34,16 @@ CFLAGS_BASE_DRIVER +=3D -Wno-unused-function
>> CFLAGS_BASE_DRIVER +=3D -Wno-unused-variable
>> CFLAGS_BASE_DRIVER +=3D -Wno-strict-aliasing
>> CFLAGS_BASE_DRIVER +=3D -Wno-missing-prototypes
>> +
>> +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
>> +CFLAGS_BASE_DRIVER +=3D -Wno-unused-value
>=20
> This change is not for the actual build error but to mask the warning:
>=20
> icc: command line warning #10006: ignoring unknown option
> '-Wno-unused-value=E2=80=99, right?
>=20
>=20
> If so, what about for Wno-format-nonliteral and Wno-shift-negative-valu=
e?

These three flags are not supported by icc, please check commit log, it
has three of them in warnings, so removing them for icc. This doesn't
cause a compilation error, just warnings from compiler but it is too
noisy, I believe good to remove.

>=20
>> CFLAGS_BASE_DRIVER +=3D -Wno-format-nonliteral
>> ifeq ($(OS_TYPE),Linux)
>> ifeq ($(shell clang -Wno-shift-negative-value -Werror -E - < /dev/null=
 >
>> /dev/null 2>&1; echo $$?),0)
>> CFLAGS_BASE_DRIVER +=3D -Wno-shift-negative-value
>> endif
>> endif
>> +endif
>>
>> ifneq (,$(filter gcc gcc48,$(CC)))
>> CFLAGS_BASE_DRIVER +=3D -Wno-unused-but-set-variable
>> @@ -57,7 +60,7 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion
>> -Werror -E - < /dev/null > /dev
>> CFLAGS_BASE_DRIVER +=3D -Wno-pointer-bool-conversion
>> endif
>> else
>> -#icc flags
>> +CFLAGS_BASE_DRIVER +=3D -wd188 #188: enumerated type mixed with anoth=
er
>> type
>> endif
>>
>> #
>> --=20
>> 2.5.5
>>
>>
> Looks good.=20
> I hope its retested against gcc/clang also to make sure the change does=
n=E2=80=99t
> cause build errors.

Yes, did a gcc and clang compile test.


> Acked-by: Harish Patil <harish.patil@qlogic.com>
>=20
>=20