From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbcEMIzL (ORCPT ); Fri, 13 May 2016 04:55:11 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:14282 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbcEMIzJ (ORCPT ); Fri, 13 May 2016 04:55:09 -0400 Subject: Re: [PATCH v3 1/7] perf tools: Set vdso name to vdso[64,32] depending on platform To: Adrian Hunter , , , , , , , , , , , , , , , , References: <1463042596-61703-1-git-send-email-hekuang@huawei.com> <1463042596-61703-2-git-send-email-hekuang@huawei.com> <573455BA.1070707@intel.com> CC: From: Hekuang Message-ID: <573595F9.8090903@huawei.com> Date: Fri, 13 May 2016 16:53:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <573455BA.1070707@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.110.55.166] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5735960A.0046,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: da8c2931a76937a88cf66214be2e134b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/5/12 18:06, Adrian Hunter 写道: > On 12/05/16 11:43, He Kuang wrote: >> This is a preparation for cross-platform vdso lookup. >> >> There is a naming confusion about vdso name, vdso buildid generated by >> a 32-bit machine stores it with the name 'vdso', but when processing >> buildid on a 64-bit machine with the same 'perf.data', perf will >> search for vdso named as 'vdso32' and get failed. >> >> This patch uses different names when storing the buildid, i.e. vdso64 >> for 64-bit machine and vdso32 for 32-bit machine, and eliminates this >> naming confusion. > That looks like it will break existing perf.data files because they will > have a different name recorded in the buildid section. > > Also it doesn't look like it would work the other way around i.e. recording > on a 64-bit machine and processing on a 32-bit machine. Yes, please have a look at the new patch. Thanks >> Signed-off-by: He Kuang >> --- >> tools/perf/util/vdso.h | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/vdso.h b/tools/perf/util/vdso.h >> index cdc4fab..45e9ef4 100644 >> --- a/tools/perf/util/vdso.h >> +++ b/tools/perf/util/vdso.h >> @@ -4,10 +4,15 @@ >> #include >> #include >> #include >> +#include "util.h" >> >> #define VDSO__MAP_NAME "[vdso]" >> >> -#define DSO__NAME_VDSO "[vdso]" >> +#if BITS_PER_LONG == 64 >> +#define DSO__NAME_VDSO "[vdso64]" >> +#else >> +#define DSO__NAME_VDSO "[vdso32]" >> +#endif >> #define DSO__NAME_VDSO32 "[vdso32]" >> #define DSO__NAME_VDSOX32 "[vdsox32]" >> >> >