From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755007AbcIELTk (ORCPT ); Mon, 5 Sep 2016 07:19:40 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:51688 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbcIELTi (ORCPT ); Mon, 5 Sep 2016 07:19:38 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: james.smart@avagotech.com, dick.kennedy@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] lpfc: mark symbols static where possible Date: Mon, 05 Sep 2016 13:14:26 +0200 Message-ID: <5736452.ArzUdR1RZm@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472972847-5174-1-git-send-email-baoyou.xie@linaro.org> References: <1472972847-5174-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:nE9YciMBNgkGr2zELjEmJQXRd2SVRqRLLWB5SgL5qmghm5X5iHI Lt00DbIK8dy3QQt5+NIKxFB3wNOGODatvsInfxSMueyrhDnFAW2Q+meI+iDryK0UBaBTNXW MsqXl0rcCOK2oGA2HdOX9aZi4Kkny8t8nXJE4WAp8JH6j0pTgr7gGsdHpx/2gfJfbYvg1OX NYSXLuyYziHQg/2SFkbig== X-UI-Out-Filterresults: notjunk:1;V01:K0:X9sK2vVWqm8=:5spLbEY+wJM0zfzbKVbIqa FnrV841bYAO5cPCq2EvrI/X/o1yeaKl8IKZyIKmMbRYIRDjwYBAqdp9sdnS2AQgKd8XwqWS5G 3GLFeqz+CINkW3qveAapfJRTNFYsFZ3PLDGLMLpzgsf2zi2diIGbmBIm1acxrRf7uN0kmqXY3 WX+HtdgFEGO0NM05U40GiuGVsjaBU2asDRE/TVshwdp6E174j9oJKbvQfJCmXIGlJ7dzkvLgs e1zp7QuD7RWdlBszOtyIn21zO06RlxLN7nw/iDlMw8fjhDV4kCUbypOJR3/Mr4mL8b6mpk2DV hMY1wg5QPko+Mu4k3BSuYWC+Cks+cd8GJjIBADUlxRk2xfy2hox5Oe40YKxfZGt4ypCta55Jp hTtZySeqiIG1ycQfke0OWZAvIGX2VR4HiBKwfWsu4shf7d4B9FhLg1jTpxPccmFueQSd/w3kN /2wq7RqTGqoXGDYgqduRswCQv8oXOIfmERQcgXqqlqO5rv4XqFh2JIVqkG3lWUBQGAiiNlXwf B7TsHvpdcQevnkdhzbWitWDwU3i70QVsJNvhkZ+Fb+yNhdakyRMz/fDKaZIOxeUvtdbH131fA StNA3twnAMOX2EOTYqBDNV0PH/4i/CkgdAthOOOcarxSh/lL1G7nQLSnpjrJut63ea/1lbBSV sPl38IhwlNiz7/zrvWyqzrWLTpy/Hvhg5GJBbIrCenr3ER4GcRCEBMFeXWzdugW5LqonpqxwD /vYFS7BA2aRrmAMo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, September 4, 2016 3:07:27 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/scsi/lpfc/lpfc_sli.c:5693:1: warning: no previous prototype for 'lpfc_set_features' [-Wmissing-prototypes] > drivers/scsi/lpfc/lpfc_sli.c:8972:1: warning: no previous prototype for 'lpfc_sli_calc_ring' [-Wmissing-prototypes] > drivers/scsi/lpfc/lpfc_mbox.c:2264:1: warning: no previous prototype for 'lpfc_mbx_cmpl_rdp_link_stat' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann