From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50F7C43460 for ; Wed, 19 May 2021 12:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC4BD600D1 for ; Wed, 19 May 2021 12:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353460AbhESMsM (ORCPT ); Wed, 19 May 2021 08:48:12 -0400 Received: from mail-sn1anam02on2040.outbound.protection.outlook.com ([40.107.96.40]:5583 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233234AbhESMsL (ORCPT ); Wed, 19 May 2021 08:48:11 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IyKwzhcvtW/lhgGP82q140p+GmNdzILOHitzMRBWMwr1l0t6AQMM/PIG5WsPtQJrVE4t0e4XtKMgegXpTAUz1Tcoz/WPtc2bSBSi7uO+RjAyMexopsvJ/rDws2cDNoe9nSqaTHZEyirvmiPV+k10LKe2brXOOOcTTLhoqKSBDDqUtb/mAeQ3sll6oiZfrDtR4zplj9Ag2hb7+vUdK+3PmglwoK3glGYy022j8z2rqBpB3+HuEMDzIO32HfiV0Z/CeKLL0H541zVIDeNHOO8n/ll0ANni54+26J7gk2aI3bEWd4QS5wEvBr9tqApNSVPfBhKnqCBhzXVSsG4on3bVRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oosbLLmOYjnmDW3tRYGgPE5W5l+qu0QAxSKrkPk5Puc=; b=erJ9pKjC+1gKQBX+qWrpvWbRiuvS0ppAXTcr+i/l+Q8HGqomTos250hZ394sThNf3c0eLXLyhUyEzVrZ/vwKIR9pDYZApy7AjSDj0j/FQAA0Sq1HqO9cuY/0YTZ+OnH486U7da/67gIAgFSLhTIMKOd2drMFPbz2GR94qM6vGlow0q5nD8ZNJVbo1W5g6gFp32SjVIdTf/XM5maNvp3asRKUT8bTQ0Xp09CuqWl2L4yde2bUnuPr4Y3ixLLuKwdIejCokCg23l5aCuN/VQtF/V8WJoe9pid19pz/5GO+0ktkxtwbbMb6PnVh/0DBZe58DoZnjqZeT9sKlyQLnR83dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oosbLLmOYjnmDW3tRYGgPE5W5l+qu0QAxSKrkPk5Puc=; b=f5pHp0x3E+bdS6lBz3Cupa8UKuaVa8nZYuuC4c8ltrVBnzzgc3uiVxjZQ3ey8NHE4P02Re3TXKE/KO6tzeqvQpMpOHTsB1DObh5pYrjgArsu6p1ipvTllQhlDRoiMXAgt+N4tmHCyY0Yhk8MLEiPq7HZpsIkxTfkL76Gw86GVigK1Brx8hF9Ts4joSLC7OloEKxN1kCHBPS/igdt/I9JyRmPDAGcJrvWR5A8714XMLHTAlyPJo0K6PIrnHN2F3yFoAKT5d6Ei5sVzDrrmifaXnh9Az8rzsME3djFBPLcqWc1Oyb/p5MBvUGugAvCFn2FXFiY6YrGq2Cj63BoY4OfXg== Received: from DM3PR03CA0002.namprd03.prod.outlook.com (2603:10b6:0:50::12) by MN2PR12MB3582.namprd12.prod.outlook.com (2603:10b6:208:cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 12:46:49 +0000 Received: from DM6NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:0:50:cafe::d9) by DM3PR03CA0002.outlook.office365.com (2603:10b6:0:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 12:46:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT063.mail.protection.outlook.com (10.13.172.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 12:46:49 +0000 Received: from nvdebian.localnet (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 12:46:45 +0000 From: Alistair Popple To: Peter Xu CC: , , , , , , , , , , , , , , , Christoph Hellwig Subject: Re: [PATCH v8 5/8] mm: Device exclusive memory access Date: Wed, 19 May 2021 22:46:43 +1000 Message-ID: <5737557.YXifvZZQQ8@nvdebian> In-Reply-To: References: <20210407084238.20443-1-apopple@nvidia.com> <2217153.lfGrokb94b@nvdebian> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f4ab20d-e196-4841-2c75-08d91ac42b5c X-MS-TrafficTypeDiagnostic: MN2PR12MB3582: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mtz9r1gp+6oIBQ5wmu3a19rzGJ7KQ8u27vWB+S3SYTf/19BPkbkJk0tRPuFACNdGVvOULeJGrPGGGtheCYc+xewJ/0DTM7LvVAj7G9qDR9igSP+1Uzmhp1+H74AZzSIq/v5jOENjrZ1lzEFMTkalyrdi3/1BfYhpUbn0d22aDguM3dCdOVhgbO8aBs+qZWf7IWa54KLVII3vY9LtzR0iMW5FophMd3eFQAA61gB5mnHL179pv53ruov98cbm9Hj+dfh3k/n1WLx//s+/HIA7tXdHqkidhA0ga9iNqH2OPAdoWbZd6beevp47QliuV7L7PhrSGAtBx6aXHWSgX66GNiWvKl56nZU5xVBz5a+BxyCFHpSHitMHBNTs/YqfnIAYrX4ztqQHS2Wl0fo4N0SxNR4pD6tRVW5TlU0jJOjeX8cI/vQEmGC11E5U1g4nY6eX/Cm39ZMaFgy8413+d+LGR0MXTZE26f2kK1EolguQU7qC9cohl42XB9N9vTJp/dVeRDS15d6DVUVrw41Urk8EmJ01Mlph3rjZcQyxtNEuGH3JIvjYUb1WZYQB9xhxU4zSyGRBPxPe+r+KEVa1g3Z+A5fLJALIHTuyUCxEkaODdDrMHuDAu+us6X1Chqtfbuv+UbSxapORYAQpQHCjFEMAPaCbSb5rKFdNvO+fzq4MI4K/KRPoxvRxDp127V7Fcyeu X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(9686003)(316002)(426003)(36906005)(8936002)(8676002)(54906003)(33716001)(26005)(356005)(478600001)(4744005)(16526019)(336012)(5660300002)(82740400003)(9576002)(7416002)(70206006)(83380400001)(36860700001)(86362001)(47076005)(82310400003)(6916009)(7636003)(4326008)(2906002)(70586007)(186003)(39026012);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2021 12:46:49.1889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4ab20d-e196-4841-2c75-08d91ac42b5c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3582 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, 19 May 2021 10:21:08 PM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Wed, May 19, 2021 at 09:35:10PM +1000, Alistair Popple wrote: > > I think the approach you are describing is similar to what > > migrate_vma_collect()/migrate_vma_unamp() does now and I think it could be > > made to work. I ended up going with the GUP+unmap approach in part because > > Christoph suggested it but primarily because it required less code > > especially given we needed to call something to fault the page in/break > > COW anyway (or extend what was there to call handle_mm_fault(), etc.). > > I see, thank. Would you mind add a short paragraph in the commit message > talking about these two solutions and why we choose the GUP way? Sure. - Alistair > -- > Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C1EAC43462 for ; Wed, 19 May 2021 12:46:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 486CC61074 for ; Wed, 19 May 2021 12:46:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 486CC61074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 707386EDA2; Wed, 19 May 2021 12:46:52 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2074.outbound.protection.outlook.com [40.107.223.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DE4E6ED9D; Wed, 19 May 2021 12:46:51 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IyKwzhcvtW/lhgGP82q140p+GmNdzILOHitzMRBWMwr1l0t6AQMM/PIG5WsPtQJrVE4t0e4XtKMgegXpTAUz1Tcoz/WPtc2bSBSi7uO+RjAyMexopsvJ/rDws2cDNoe9nSqaTHZEyirvmiPV+k10LKe2brXOOOcTTLhoqKSBDDqUtb/mAeQ3sll6oiZfrDtR4zplj9Ag2hb7+vUdK+3PmglwoK3glGYy022j8z2rqBpB3+HuEMDzIO32HfiV0Z/CeKLL0H541zVIDeNHOO8n/ll0ANni54+26J7gk2aI3bEWd4QS5wEvBr9tqApNSVPfBhKnqCBhzXVSsG4on3bVRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oosbLLmOYjnmDW3tRYGgPE5W5l+qu0QAxSKrkPk5Puc=; b=erJ9pKjC+1gKQBX+qWrpvWbRiuvS0ppAXTcr+i/l+Q8HGqomTos250hZ394sThNf3c0eLXLyhUyEzVrZ/vwKIR9pDYZApy7AjSDj0j/FQAA0Sq1HqO9cuY/0YTZ+OnH486U7da/67gIAgFSLhTIMKOd2drMFPbz2GR94qM6vGlow0q5nD8ZNJVbo1W5g6gFp32SjVIdTf/XM5maNvp3asRKUT8bTQ0Xp09CuqWl2L4yde2bUnuPr4Y3ixLLuKwdIejCokCg23l5aCuN/VQtF/V8WJoe9pid19pz/5GO+0ktkxtwbbMb6PnVh/0DBZe58DoZnjqZeT9sKlyQLnR83dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oosbLLmOYjnmDW3tRYGgPE5W5l+qu0QAxSKrkPk5Puc=; b=f5pHp0x3E+bdS6lBz3Cupa8UKuaVa8nZYuuC4c8ltrVBnzzgc3uiVxjZQ3ey8NHE4P02Re3TXKE/KO6tzeqvQpMpOHTsB1DObh5pYrjgArsu6p1ipvTllQhlDRoiMXAgt+N4tmHCyY0Yhk8MLEiPq7HZpsIkxTfkL76Gw86GVigK1Brx8hF9Ts4joSLC7OloEKxN1kCHBPS/igdt/I9JyRmPDAGcJrvWR5A8714XMLHTAlyPJo0K6PIrnHN2F3yFoAKT5d6Ei5sVzDrrmifaXnh9Az8rzsME3djFBPLcqWc1Oyb/p5MBvUGugAvCFn2FXFiY6YrGq2Cj63BoY4OfXg== Received: from DM3PR03CA0002.namprd03.prod.outlook.com (2603:10b6:0:50::12) by MN2PR12MB3582.namprd12.prod.outlook.com (2603:10b6:208:cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 12:46:49 +0000 Received: from DM6NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:0:50:cafe::d9) by DM3PR03CA0002.outlook.office365.com (2603:10b6:0:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 12:46:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT063.mail.protection.outlook.com (10.13.172.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 12:46:49 +0000 Received: from nvdebian.localnet (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 12:46:45 +0000 From: Alistair Popple To: Peter Xu Date: Wed, 19 May 2021 22:46:43 +1000 Message-ID: <5737557.YXifvZZQQ8@nvdebian> In-Reply-To: References: <20210407084238.20443-1-apopple@nvidia.com> <2217153.lfGrokb94b@nvdebian> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f4ab20d-e196-4841-2c75-08d91ac42b5c X-MS-TrafficTypeDiagnostic: MN2PR12MB3582: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mtz9r1gp+6oIBQ5wmu3a19rzGJ7KQ8u27vWB+S3SYTf/19BPkbkJk0tRPuFACNdGVvOULeJGrPGGGtheCYc+xewJ/0DTM7LvVAj7G9qDR9igSP+1Uzmhp1+H74AZzSIq/v5jOENjrZ1lzEFMTkalyrdi3/1BfYhpUbn0d22aDguM3dCdOVhgbO8aBs+qZWf7IWa54KLVII3vY9LtzR0iMW5FophMd3eFQAA61gB5mnHL179pv53ruov98cbm9Hj+dfh3k/n1WLx//s+/HIA7tXdHqkidhA0ga9iNqH2OPAdoWbZd6beevp47QliuV7L7PhrSGAtBx6aXHWSgX66GNiWvKl56nZU5xVBz5a+BxyCFHpSHitMHBNTs/YqfnIAYrX4ztqQHS2Wl0fo4N0SxNR4pD6tRVW5TlU0jJOjeX8cI/vQEmGC11E5U1g4nY6eX/Cm39ZMaFgy8413+d+LGR0MXTZE26f2kK1EolguQU7qC9cohl42XB9N9vTJp/dVeRDS15d6DVUVrw41Urk8EmJ01Mlph3rjZcQyxtNEuGH3JIvjYUb1WZYQB9xhxU4zSyGRBPxPe+r+KEVa1g3Z+A5fLJALIHTuyUCxEkaODdDrMHuDAu+us6X1Chqtfbuv+UbSxapORYAQpQHCjFEMAPaCbSb5rKFdNvO+fzq4MI4K/KRPoxvRxDp127V7Fcyeu X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(9686003)(316002)(426003)(36906005)(8936002)(8676002)(54906003)(33716001)(26005)(356005)(478600001)(4744005)(16526019)(336012)(5660300002)(82740400003)(9576002)(7416002)(70206006)(83380400001)(36860700001)(86362001)(47076005)(82310400003)(6916009)(7636003)(4326008)(2906002)(70586007)(186003)(39026012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2021 12:46:49.1889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4ab20d-e196-4841-2c75-08d91ac42b5c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3582 Subject: Re: [Nouveau] [PATCH v8 5/8] mm: Device exclusive memory access X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcampbell@nvidia.com, willy@infradead.org, daniel@ffwll.ch, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, bsingharora@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hch@infradead.org, linux-mm@kvack.org, bskeggs@redhat.com, jgg@nvidia.com, akpm@linux-foundation.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wednesday, 19 May 2021 10:21:08 PM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Wed, May 19, 2021 at 09:35:10PM +1000, Alistair Popple wrote: > > I think the approach you are describing is similar to what > > migrate_vma_collect()/migrate_vma_unamp() does now and I think it could be > > made to work. I ended up going with the GUP+unmap approach in part because > > Christoph suggested it but primarily because it required less code > > especially given we needed to call something to fault the page in/break > > COW anyway (or extend what was there to call handle_mm_fault(), etc.). > > I see, thank. Would you mind add a short paragraph in the commit message > talking about these two solutions and why we choose the GUP way? Sure. - Alistair > -- > Peter Xu _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D80C433ED for ; Wed, 19 May 2021 12:46:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3118C61074 for ; Wed, 19 May 2021 12:46:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3118C61074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CC806ED9D; Wed, 19 May 2021 12:46:51 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2074.outbound.protection.outlook.com [40.107.223.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DE4E6ED9D; Wed, 19 May 2021 12:46:51 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IyKwzhcvtW/lhgGP82q140p+GmNdzILOHitzMRBWMwr1l0t6AQMM/PIG5WsPtQJrVE4t0e4XtKMgegXpTAUz1Tcoz/WPtc2bSBSi7uO+RjAyMexopsvJ/rDws2cDNoe9nSqaTHZEyirvmiPV+k10LKe2brXOOOcTTLhoqKSBDDqUtb/mAeQ3sll6oiZfrDtR4zplj9Ag2hb7+vUdK+3PmglwoK3glGYy022j8z2rqBpB3+HuEMDzIO32HfiV0Z/CeKLL0H541zVIDeNHOO8n/ll0ANni54+26J7gk2aI3bEWd4QS5wEvBr9tqApNSVPfBhKnqCBhzXVSsG4on3bVRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oosbLLmOYjnmDW3tRYGgPE5W5l+qu0QAxSKrkPk5Puc=; b=erJ9pKjC+1gKQBX+qWrpvWbRiuvS0ppAXTcr+i/l+Q8HGqomTos250hZ394sThNf3c0eLXLyhUyEzVrZ/vwKIR9pDYZApy7AjSDj0j/FQAA0Sq1HqO9cuY/0YTZ+OnH486U7da/67gIAgFSLhTIMKOd2drMFPbz2GR94qM6vGlow0q5nD8ZNJVbo1W5g6gFp32SjVIdTf/XM5maNvp3asRKUT8bTQ0Xp09CuqWl2L4yde2bUnuPr4Y3ixLLuKwdIejCokCg23l5aCuN/VQtF/V8WJoe9pid19pz/5GO+0ktkxtwbbMb6PnVh/0DBZe58DoZnjqZeT9sKlyQLnR83dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oosbLLmOYjnmDW3tRYGgPE5W5l+qu0QAxSKrkPk5Puc=; b=f5pHp0x3E+bdS6lBz3Cupa8UKuaVa8nZYuuC4c8ltrVBnzzgc3uiVxjZQ3ey8NHE4P02Re3TXKE/KO6tzeqvQpMpOHTsB1DObh5pYrjgArsu6p1ipvTllQhlDRoiMXAgt+N4tmHCyY0Yhk8MLEiPq7HZpsIkxTfkL76Gw86GVigK1Brx8hF9Ts4joSLC7OloEKxN1kCHBPS/igdt/I9JyRmPDAGcJrvWR5A8714XMLHTAlyPJo0K6PIrnHN2F3yFoAKT5d6Ei5sVzDrrmifaXnh9Az8rzsME3djFBPLcqWc1Oyb/p5MBvUGugAvCFn2FXFiY6YrGq2Cj63BoY4OfXg== Received: from DM3PR03CA0002.namprd03.prod.outlook.com (2603:10b6:0:50::12) by MN2PR12MB3582.namprd12.prod.outlook.com (2603:10b6:208:cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 12:46:49 +0000 Received: from DM6NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:0:50:cafe::d9) by DM3PR03CA0002.outlook.office365.com (2603:10b6:0:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 12:46:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT063.mail.protection.outlook.com (10.13.172.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 12:46:49 +0000 Received: from nvdebian.localnet (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 12:46:45 +0000 From: Alistair Popple To: Peter Xu Subject: Re: [PATCH v8 5/8] mm: Device exclusive memory access Date: Wed, 19 May 2021 22:46:43 +1000 Message-ID: <5737557.YXifvZZQQ8@nvdebian> In-Reply-To: References: <20210407084238.20443-1-apopple@nvidia.com> <2217153.lfGrokb94b@nvdebian> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f4ab20d-e196-4841-2c75-08d91ac42b5c X-MS-TrafficTypeDiagnostic: MN2PR12MB3582: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mtz9r1gp+6oIBQ5wmu3a19rzGJ7KQ8u27vWB+S3SYTf/19BPkbkJk0tRPuFACNdGVvOULeJGrPGGGtheCYc+xewJ/0DTM7LvVAj7G9qDR9igSP+1Uzmhp1+H74AZzSIq/v5jOENjrZ1lzEFMTkalyrdi3/1BfYhpUbn0d22aDguM3dCdOVhgbO8aBs+qZWf7IWa54KLVII3vY9LtzR0iMW5FophMd3eFQAA61gB5mnHL179pv53ruov98cbm9Hj+dfh3k/n1WLx//s+/HIA7tXdHqkidhA0ga9iNqH2OPAdoWbZd6beevp47QliuV7L7PhrSGAtBx6aXHWSgX66GNiWvKl56nZU5xVBz5a+BxyCFHpSHitMHBNTs/YqfnIAYrX4ztqQHS2Wl0fo4N0SxNR4pD6tRVW5TlU0jJOjeX8cI/vQEmGC11E5U1g4nY6eX/Cm39ZMaFgy8413+d+LGR0MXTZE26f2kK1EolguQU7qC9cohl42XB9N9vTJp/dVeRDS15d6DVUVrw41Urk8EmJ01Mlph3rjZcQyxtNEuGH3JIvjYUb1WZYQB9xhxU4zSyGRBPxPe+r+KEVa1g3Z+A5fLJALIHTuyUCxEkaODdDrMHuDAu+us6X1Chqtfbuv+UbSxapORYAQpQHCjFEMAPaCbSb5rKFdNvO+fzq4MI4K/KRPoxvRxDp127V7Fcyeu X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(9686003)(316002)(426003)(36906005)(8936002)(8676002)(54906003)(33716001)(26005)(356005)(478600001)(4744005)(16526019)(336012)(5660300002)(82740400003)(9576002)(7416002)(70206006)(83380400001)(36860700001)(86362001)(47076005)(82310400003)(6916009)(7636003)(4326008)(2906002)(70586007)(186003)(39026012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2021 12:46:49.1889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4ab20d-e196-4841-2c75-08d91ac42b5c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3582 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcampbell@nvidia.com, willy@infradead.org, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, bsingharora@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hch@infradead.org, linux-mm@kvack.org, jglisse@redhat.com, bskeggs@redhat.com, jgg@nvidia.com, jhubbard@nvidia.com, akpm@linux-foundation.org, Christoph Hellwig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wednesday, 19 May 2021 10:21:08 PM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Wed, May 19, 2021 at 09:35:10PM +1000, Alistair Popple wrote: > > I think the approach you are describing is similar to what > > migrate_vma_collect()/migrate_vma_unamp() does now and I think it could be > > made to work. I ended up going with the GUP+unmap approach in part because > > Christoph suggested it but primarily because it required less code > > especially given we needed to call something to fault the page in/break > > COW anyway (or extend what was there to call handle_mm_fault(), etc.). > > I see, thank. Would you mind add a short paragraph in the commit message > talking about these two solutions and why we choose the GUP way? Sure. - Alistair > -- > Peter Xu